From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] Revert "drm/i915: write backlight harder"
Date: Fri, 22 Mar 2013 16:06:14 +0100
Message-ID: <s5hehf7a2zd.wl%tiwai@suse.de>
References: <20130322140129.GU9021@phenom.ffwll.local>
	<1363963486-7891-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
	by gabe.freedesktop.org (Postfix) with ESMTP id 5B67DE5C5B
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 22 Mar 2013 08:06:16 -0700 (PDT)
In-Reply-To: <1363963486-7891-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Jani Nikula <jani.nikula@intel.com>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

At Fri, 22 Mar 2013 15:44:46 +0100,
Daniel Vetter wrote:
> 
> This reverts commit cf0a6584aa6d382f802f2c3cacac23ccbccde0cd.
> 
> Turns out that cargo-culting breaks systems. Note that we can't revert
> further, since
> 
> commit 770c12312ad617172b1a65b911d3e6564fc5aca8
> Author: Takashi Iwai <tiwai@suse.de>
> Date:   Sat Aug 11 08:56:42 2012 +0200
> 
>     drm/i915: Fix blank panel at reopening lid
> 
> fixed a regression in 3.6-rc kernels for which we've never figured out
> the exact root cause. But some further inspection of the backlight
> code reveals that it's seriously lacking locking. And especially the
> asle backlight update is know to get fired (through some smm magic)
> when writing specific backlight control registers. So the possibility
> of suffering from races is rather real.
> 
> Until those races are fixed I don't think it makes sense to try
> further hacks. Which sucks a bit, but sometimes that's how it is :(
> 
> References: http://www.mail-archive.com/intel-gfx@lists.freedesktop.org/msg18788.html
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Feel free to add my tested-by tags to all three.

  Tested-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi