From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips" Date: Thu, 25 Jul 2019 12:44:08 +0200 Message-ID: References: <20190725080300.1913-1-chris@chris-wilson.co.uk> <156404342516.31349.4825957285152464339@skylake-alporthouse-com> <156405007115.31349.12271294234555423244@skylake-alporthouse-com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id C56216E6E4 for ; Thu, 25 Jul 2019 10:44:09 +0000 (UTC) In-Reply-To: <156405007115.31349.12271294234555423244@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAyNSBKdWwgMjAxOSAxMjoyMToxMSArMDIwMCwKQ2hyaXMgV2lsc29uIHdyb3RlOgo+ IAo+IFF1b3RpbmcgQ2hyaXMgV2lsc29uICgyMDE5LTA3LTI1IDA5OjMwOjI1KQo+ID4gUXVvdGlu ZyBUYWthc2hpIEl3YWkgKDIwMTktMDctMjUgMDk6MjY6NTYpCj4gPiA+IE9uIFRodSwgMjUgSnVs IDIwMTkgMTA6MTY6MDcgKzAyMDAsCj4gPiA+IFRha2FzaGkgSXdhaSB3cm90ZToKPiA+ID4gPiAK PiA+ID4gPiBPbiBUaHUsIDI1IEp1bCAyMDE5IDEwOjAzOjAwICswMjAwLAo+ID4gPiA+IENocmlz IFdpbHNvbiB3cm90ZToKPiA+ID4gPiA+IAo+ID4gPiA+ID4gSnVzdCBhIGhlYWRzIHVwIHRoYXQg aWNsIGlzIGNvbnNpc3RlbnRseSBzaG93aW5nCj4gPiA+ID4gPiAKPiA+ID4gPiA+IDw0PiBbMzE1 LjQ3ODgzMF0gc25kX2hkYV9pbnRlbCAwMDAwOjAwOjFmLjM6IGF6eF9nZXRfcmVzcG9uc2UgdGlt ZW91dCwgc3dpdGNoaW5nIHRvIHBvbGxpbmcgbW9kZTogbGFzdCBjbWQ9MHgyMDJmODEwMAo+ID4g PiA+ID4gPDQ+IFszMTYuNDgyNzk5XSBzbmRfaGRhX2ludGVsIDAwMDA6MDA6MWYuMzogTm8gcmVz cG9uc2UgZnJvbSBjb2RlYywgZGlzYWJsaW5nIE1TSTogbGFzdCBjbWQ9MHgyMDJmODEwMAo+ID4g PiA+ID4gPDM+IFs1MDguNDEyOTE1XSBzbmRfaGRhX2NvZGVjX2hkbWkgaGRhdWRpb0MwRDI6IFVu YWJsZSB0byBzeW5jIHJlZ2lzdGVyIDB4MmY4MTAwLiAtMTEKPiA+ID4gPiA+IAo+ID4gPiA+ID4g Zm9sbG93aW5nIGNvbW1pdHMgMjc1NmQ5MTQzYWE1ICgiQUxTQTogaGRhIC0gRml4IGludGVybWl0 dGVudCBDT1JCL1JJUkIKPiA+ID4gPiA+IHN0YWxsIG9uIEludGVsIGNoaXBzIikgYW5kIGEzMGYx NzQzZTRmNSAoIkFMU0E6IGxpbmU2OiBzaXplb2YgKGJ5dGUpIGlzCj4gPiA+ID4gPiBhbHdheXMg MSwgdXNlIHRoYXQgZmFjdC4iKQo+ID4gPiA+IAo+ID4gPiA+IFRoZSB2ZXJiIHRoYXQgc3RhbGxz ICgweDIwMmY4MTAwKSBpcyBhIHJlYWQgdmVyYiAoMHhmODEsIEludGVsCj4gPiA+ID4gdmVuZG9y LXNwZWNpZmljIHZlcmIgZm9yIEhETUkpLCBzbyBpdCBzaG91bGRuJ3QgbWF0dGVyIHdoZXRoZXIg d2l0aCBvcgo+ID4gPiA+IHdpdGhvdXQgd3JpdGUgc3luYywgYmVjYXVzZSBpdCBuZWVkcyB0byBy ZWFkIHRoZSByZXNwb25zZSBpbiBhbnl3YXkuCj4gPiA+ID4gCj4gPiA+ID4gSWYgdGhhdCBwYXRj aCBicm9rZSBhbnl0aGluZywgaXQgbWVhbnMgdGhhdCBzb21ldGhpbmcgZWxzZSB3YXMgYWxyZWFk eQo+ID4gPiA+IGJyb2tlbi4gIE9oIHdlbGwsIHRoYXQgSUNMIGNyYXAuLi4KPiA+ID4gPiAKPiA+ ID4gPiBJcyBpdCBhYm91dCB0aGUgcnVudGltZSBQTSwgb3IgUzMgb3IgUzQ/ICBUaGUgb25seSBj YXNlIHdlIG5lZWQgdG8KPiA+ID4gPiByZS1pc3N1ZSB0aGlzIHZlcmIgaXMgb25seSBTNCwgSSBz dXBwb3NlLCBzbyB3ZSBtYXkgc2tpcCB0aGF0IGluIG1vc3QKPiA+ID4gPiBjYXNlcy4KPiA+ID4g Cj4gPiA+IE5vdyBjaGVja2luZyB0aGUgY29kZSwgYW5kIEkgYmVsaWV2ZSB0aGUgd29ya2Fyb3Vu ZCBhcHBsaWVkIHRoZXJlIGNhbgo+ID4gPiBiZSBza2lwcGVkIGZvciBub24tSGFzd2VsbCBjaGlw cy4gIENvdWxkIHlvdSB0cnkgdGhlIHBhdGNoIGJlbG93IGluCj4gPiA+IGFkZGl0aW9uPwo+ID4g Cj4gPiBEdWUgdG8gdGhlIHdheSBwYXRjaHdvcmsgd29ya3MsIHRoaXMgcGF0Y2ggd2lsbCBub3cg YmUgdGVzdGVkIGluc3RlYWQgb2YKPiA+IHRoZSByZXZlcnQuIFNvIHdhdGNoIHRoaXMgc3BhY2Uu Cj4gCj4gU2FkbHksIG5vIGNoYW5nZS4gUGF0Y2h3b3JrIGRlZmluaXRlbHkgbGlzdHMgdGhpcyBw YXRjaCBhcyBiZWluZyB0aGUgb25lCj4gdGVzdGVkLCBidXQgbWF5YmUgc2VuZCBpdCBzZXBhcmF0 ZWx5IGp1c3QgaW4gY2FzZS4KCkhtLCBkb2VzIHRoZSBlcnJvciBpbmRpY2F0ZSB0aGUgc2FtZSBt ZXNzYWdlICgibGFzdCBjbWQ9MHgyMDJmODEwMCIpPwpJZiB5ZXMsIHdlIG1pZ2h0IG5lZWQgYW5v dGhlciB3b3JrYXJvdW5kLiAgVGhpcyBpcyBhIHNwZWNpYWwgdmVyYiBmb3IKSW50ZWwgd2l0aCBz b21lIGJsYWNrIG1hZ2ljIHRvIGNvbW11bmljYXRlIHdpdGggR1BVLiAgVGhlIHR3ZWFrIHZpYQp0 aGlzIHZlcmIgaXMgbmVlZGVkIGZvciBvdGhlciBwbGF0Zm9ybXMgdG8gYXNzdXJlIHRoZSBlbmFi bGVtZW50IG9mCmFsbCBwaW5zIGFuZCBEUCAxLjIsIGJ1dCBpdCBtaWdodCBiZSBpbmNvcnJlY3Qg Zm9yIElDTC4KCkNhbiBhbnlvbmUgYXQgSW50ZWwgY2hlY2sgd2hldGhlciB0aGUgdmVyYiAoMHg3 ODEvMHhmODEpIGlzIHN0aWxsCnZhbGlkIGZvciBJQ0w/CgpBbnl3YXlzIGJlbG93IGlzIGEgcGF0 Y2ggdG8gbGVhdmUgdGhlIHZlcmIgYWNjZXNzIGZvciBJQ0wuCkxldCdzIHNlZS4uLgoKCnRoYW5r cywKClRha2FzaGkKCi0tIDg8IC0tCkZyb206IFRha2FzaGkgSXdhaSA8dGl3YWlAc3VzZS5kZT4K U3ViamVjdDogW1BBVENIXSBBTFNBOiBoZGEvaGRtaSAtIERvbid0IGFwcGx5IGJsYWNrIG1hZ2lj IHRvIEljZWxha2UgSERNSQogY29kZWNzCgpUaGUgSW50ZWwtc3BlY2lmaWMgdmVyYiB0byBlbmFi bGUgYWxsIHBpbnMgYW5kIERQIDEuMiBzZWVtcyBjYXVzaW5nIGEKcHJvYmxlbSBvbiBJQ0wgYnkg c29tZSByZWFzb24uICBTa2lwIGFwcGx5aW5nIHRoZSB2ZXJiIGZvciBJQ0wgYXMgYQp3b3JrYXJv dW5kLgoKU2lnbmVkLW9mZi1ieTogVGFrYXNoaSBJd2FpIDx0aXdhaUBzdXNlLmRlPgotLS0KIHNv dW5kL3BjaS9oZGEvcGF0Y2hfaGRtaS5jIHwgOSArKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCA2 IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc291bmQvcGNpL2hk YS9wYXRjaF9oZG1pLmMgYi9zb3VuZC9wY2kvaGRhL3BhdGNoX2hkbWkuYwppbmRleCAyMDk2OTkz ZWFmMjguLjdlODIzNmU1ZWFjMCAxMDA2NDQKLS0tIGEvc291bmQvcGNpL2hkYS9wYXRjaF9oZG1p LmMKKysrIGIvc291bmQvcGNpL2hkYS9wYXRjaF9oZG1pLmMKQEAgLTI4MDQsMTIgKzI4MDQsMTUg QEAgc3RhdGljIGludCBpbnRlbF9oc3dfY29tbW9uX2luaXQoc3RydWN0IGhkYV9jb2RlYyAqY29k ZWMsIGhkYV9uaWRfdCB2ZW5kb3JfbmlkLAogCXNwZWMtPnBvcnRfbWFwID0gcG9ydF9tYXA7CiAJ c3BlYy0+cG9ydF9udW0gPSBwb3J0X251bTsKIAotCWludGVsX2hhc3dlbGxfZW5hYmxlX2FsbF9w aW5zKGNvZGVjLCB0cnVlKTsKLQlpbnRlbF9oYXN3ZWxsX2ZpeHVwX2VuYWJsZV9kcDEyKGNvZGVj KTsKKwlpZiAoIWlzX2ljZWxha2UoY29kZWMpKSB7CisJCWludGVsX2hhc3dlbGxfZW5hYmxlX2Fs bF9waW5zKGNvZGVjLCB0cnVlKTsKKwkJaW50ZWxfaGFzd2VsbF9maXh1cF9lbmFibGVfZHAxMihj b2RlYyk7CisJfQogCiAJY29kZWMtPmRpc3BsYXlfcG93ZXJfY29udHJvbCA9IDE7CiAKLQljb2Rl Yy0+cGF0Y2hfb3BzLnNldF9wb3dlcl9zdGF0ZSA9IGhhc3dlbGxfc2V0X3Bvd2VyX3N0YXRlOwor CWlmICghaXNfaWNlbGFrZShjb2RlYykpCisJCWNvZGVjLT5wYXRjaF9vcHMuc2V0X3Bvd2VyX3N0 YXRlID0gaGFzd2VsbF9zZXRfcG93ZXJfc3RhdGU7CiAJY29kZWMtPmRlcG9wX2RlbGF5ID0gMDsK IAljb2RlYy0+YXV0b19ydW50aW1lX3BtID0gMTsKIAotLSAKMi4xNi40CgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4