public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jerome Anand <jerome.anand@intel.com>
Cc: alsa-devel@alsa-project.org, intel-gfx@lists.freedesktop.org,
	broonie@kernel.org, rakesh.a.ughreja@intel.com
Subject: Re: [PATCH v4 4/5] ALSA: x86: hdmi: Add audio support for BYT and CHT
Date: Fri, 20 Jan 2017 12:15:24 +0100	[thread overview]
Message-ID: <s5ho9z2q8xf.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170120222232.27791-5-jerome.anand@intel.com>

On Fri, 20 Jan 2017 23:22:31 +0100,
Jerome Anand wrote:
> 
> +	had_ops_v1 = had_ops_v1;	/* unused */

Until now I didn't realize that the whole v1 stuff is never used in
the current patchset.  Will it be ever used in future?  If not, can't
we clean it up?  It's a bunch of codes, including the messy union
definitions.  If there is no v3 or whatever, we can even get rid of
the whole indirect calls.

And if v1 (and the indirect ops calls) should be kept, actually what
is the difference between v1 and v2, why both implementations do
exist?  Please elaborate in comments.


thanks,

Takashi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-01-20 11:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-20 22:22 [PATCH v4 0/5] Add support for Legacy HDMI audio drivers Jerome Anand
2017-01-20 11:54 ` ✗ Fi.CI.BAT: failure for Add support for Legacy HDMI audio drivers (rev5) Patchwork
2017-01-20 22:22 ` [PATCH v4 1/5] drm/i915: setup bridge for HDMI LPE audio driver Jerome Anand
2017-01-23 10:54   ` Jani Nikula
2017-01-24  8:21     ` Anand, Jerome
2017-01-20 22:22 ` [PATCH v4 2/5] drm/i915: Add support for audio driver notifications Jerome Anand
2017-01-23 10:57   ` Jani Nikula
2017-01-23 16:32     ` Pierre-Louis Bossart
2017-01-24  7:00       ` Jani Nikula
2017-01-24  8:42         ` Anand, Jerome
2017-01-20 22:22 ` [PATCH v4 3/5] ALSA: add Intel HDMI LPE audio driver for BYT/CHT-T Jerome Anand
2017-01-20 22:22 ` [PATCH v4 4/5] ALSA: x86: hdmi: Add audio support for BYT and CHT Jerome Anand
2017-01-20 11:15   ` Takashi Iwai [this message]
2017-01-20 16:45     ` [alsa-devel] " Pierre-Louis Bossart
2017-01-20 19:09       ` Takashi Iwai
2017-01-20 22:22 ` [PATCH v4 5/5] ALSA: x86: hdmi: continue playback even when display resolution changes Jerome Anand
2017-01-23 10:18 ` [PATCH v4 0/5] Add support for Legacy HDMI audio drivers Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5ho9z2q8xf.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jerome.anand@intel.com \
    --cc=rakesh.a.ughreja@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox