From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 3/7] drm/i915: refactoring audio component functions Date: Mon, 30 Nov 2015 15:57:18 +0100 Message-ID: References: <1448890671-2983-1-git-send-email-tiwai@suse.de> <1448890671-2983-4-git-send-email-tiwai@suse.de> <20151130141403.GS17050@phenom.ffwll.local> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 00F906E5E5 for ; Mon, 30 Nov 2015 06:57:19 -0800 (PST) In-Reply-To: <20151130141403.GS17050@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: alsa-devel@alsa-project.org, Mengdong Lin , Vinod Koul , intel-gfx@lists.freedesktop.org, Daniel Vetter , David Henningsson List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAzMCBOb3YgMjAxNSAxNToxNDowMyArMDEwMCwKRGFuaWVsIFZldHRlciB3cm90ZToK PiAKPiBPbiBNb24sIE5vdiAzMCwgMjAxNSBhdCAwMjozNzo0N1BNICswMTAwLCBUYWthc2hpIEl3 YWkgd3JvdGU6Cj4gPiBXZSBoYXZlIGEgY29tbW9uIGxvb3Agb2YgZW5jb2RlciB0byBsb29rIGZv ciB0aGUgZ2l2ZW4gYXVkaW8gcG9ydCBpbgo+ID4gdHdvIGF1ZGlvIGNvbXBvbmVudCBmdW5jdGlv bnMuICBTcGxpdCBvdXQgYSBsb2NhbCBoZWxwZXIgZnVuY3Rpb24gdG8KPiA+IGRvIGl0IGZvciB0 aGUgY29kZSBzaW1wbGlmaWNhdGlvbi4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogVGFrYXNoaSBJ d2FpIDx0aXdhaUBzdXNlLmRlPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfYXVkaW8uYyB8IDYxICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCj4g PiAgMSBmaWxlIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyksIDI5IGRlbGV0aW9ucygtKQo+ID4g Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXVkaW8uYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F1ZGlvLmMKPiA+IGluZGV4IDZiMzE4YThkNWRjOS4u MDI0ZTg4YWU2MzA1IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf YXVkaW8uYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXVkaW8uYwo+ID4g QEAgLTYzMCwxNyArNjMwLDMzIEBAIHN0YXRpYyBpbnQgaTkxNV9hdWRpb19jb21wb25lbnRfZ2V0 X2NkY2xrX2ZyZXEoc3RydWN0IGRldmljZSAqZGV2KQo+ID4gIAlyZXR1cm4gcmV0Owo+ID4gIH0K PiA+ICAKPiA+ICtzdGF0aWMgc3RydWN0IGludGVsX2VuY29kZXIgKmF1ZGlvX3BvcnRfdG9fZW5j b2RlcihzdHJ1Y3QgZHJtX2RldmljZSAqZHJtX2RldiwKPiA+ICsJCQkJCQkgICBpbnQgcG9ydCkK PiA+ICt7Cj4gPiArCXN0cnVjdCBpbnRlbF9lbmNvZGVyICppbnRlbF9lbmNvZGVyOwo+ID4gKwlz dHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICppbnRlbF9kaWdfcG9ydDsKPiA+ICsKPiA+ICsJZm9y X2VhY2hfaW50ZWxfZW5jb2Rlcihkcm1fZGV2LCBpbnRlbF9lbmNvZGVyKSB7Cj4gPiArCQlpZiAo aW50ZWxfZW5jb2Rlci0+dHlwZSAhPSBJTlRFTF9PVVRQVVRfSERNSSAmJgo+ID4gKwkJICAgIGlu dGVsX2VuY29kZXItPnR5cGUgIT0gSU5URUxfT1VUUFVUX0RJU1BMQVlQT1JUKQo+ID4gKwkJCWNv bnRpbnVlOwo+ID4gKwkJaW50ZWxfZGlnX3BvcnQgPSBlbmNfdG9fZGlnX3BvcnQoJmludGVsX2Vu Y29kZXItPmJhc2UpOwo+ID4gKwkJaWYgKHBvcnQgPT0gaW50ZWxfZGlnX3BvcnQtPnBvcnQpCj4g Cj4gSWYgdGhpcyBpcyBzdGF0aWMsIG1heWJlIGp1c3QgbWFpbnRhaW4gYSBzbmRfcGluX3RvX3Bv cnQgbWFwcGluZyBpbgo+IGRldl9wcml2PyBUaGF0J3MgdGhlIGFwcHJvYWNoIHdlJ3JlIHVzdWFs bHkgdGFraW5nLCBhbmQgaXQgaGFzIHRoZSBiZW5lZml0Cj4gb2YgbWFraW5nIGl0IGNsZWFyKGVy KSB0aGF0IHRoZSBiaW5kaW5nIGlzIHN0YXRpYyAuLi4gT3IgaXMgaXQgbm90PwoKWWVzLCBJICpn dWVzcyogdGhpcyBpcyBzdGF0aWMsIGJ1dCBuZWVkIGEgZG91YmxlLWNoZWNrLiAgVGhlIGN1cnJl bnQKcGF0Y2hzZXQganVzdCBkZXJpdmVzIGZyb20gdGhlIGV4aXN0aW5nIGNvZGUuCgoKdGhhbmtz LAoKVGFrYXNoaQoKPiBNYWtlcyBzZW5zZSBvdGhlcndpc2UuCj4gLURhbmllbAo+IAo+ID4gKwkJ CXJldHVybiBpbnRlbF9lbmNvZGVyOwo+ID4gKwl9Cj4gPiArCXJldHVybiBOVUxMOwo+ID4gK30K PiA+ICsKPiA+ICBzdGF0aWMgaW50IGk5MTVfYXVkaW9fY29tcG9uZW50X3N5bmNfYXVkaW9fcmF0 ZShzdHJ1Y3QgZGV2aWNlICpkZXYsCj4gPiAgCQkJCQkJaW50IHBvcnQsIGludCByYXRlKQo+ID4g IHsKPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2X3RvX2k5MTUo ZGV2KTsKPiA+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRybV9kZXYgPSBkZXZfcHJpdi0+ZGV2Owo+ ID4gIAlzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqaW50ZWxfZW5jb2RlcjsKPiA+IC0Jc3RydWN0IGlu dGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQ7Cj4gPiAgCXN0cnVjdCBpbnRlbF9jcnRj ICpjcnRjOwo+ID4gIAlzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZTsKPiA+ICAJc3RydWN0 IGk5MTVfYXVkaW9fY29tcG9uZW50ICphY29tcCA9IGRldl9wcml2LT5hdWRpb19jb21wb25lbnQ7 Cj4gPiAtCWVudW0gcGlwZSBwaXBlID0gLTE7Cj4gPiArCWVudW0gcGlwZSBwaXBlOwo+ID4gIAl1 MzIgdG1wOwo+ID4gIAlpbnQgbjsKPiA+ICAKPiA+IEBAIC02NTIsMjIgKzY2OCwxNCBAQCBzdGF0 aWMgaW50IGk5MTVfYXVkaW9fY29tcG9uZW50X3N5bmNfYXVkaW9fcmF0ZShzdHJ1Y3QgZGV2aWNl ICpkZXYsCj4gPiAgCj4gPiAgCW11dGV4X2xvY2soJmRldl9wcml2LT5hdl9tdXRleCk7Cj4gPiAg CS8qIDEuIGdldCB0aGUgcGlwZSAqLwo+ID4gLQlmb3JfZWFjaF9pbnRlbF9lbmNvZGVyKGRybV9k ZXYsIGludGVsX2VuY29kZXIpIHsKPiA+IC0JCWlmIChpbnRlbF9lbmNvZGVyLT50eXBlICE9IElO VEVMX09VVFBVVF9IRE1JKQo+ID4gLQkJCWNvbnRpbnVlOwo+ID4gLQkJaW50ZWxfZGlnX3BvcnQg PSBlbmNfdG9fZGlnX3BvcnQoJmludGVsX2VuY29kZXItPmJhc2UpOwo+ID4gLQkJaWYgKHBvcnQg PT0gaW50ZWxfZGlnX3BvcnQtPnBvcnQpIHsKPiA+IC0JCQljcnRjID0gdG9faW50ZWxfY3J0Yyhp bnRlbF9lbmNvZGVyLT5iYXNlLmNydGMpOwo+ID4gLQkJCXBpcGUgPSBjcnRjLT5waXBlOwo+ID4g LQkJCWJyZWFrOwo+ID4gLQkJfQo+ID4gLQl9Cj4gPiAtCj4gPiAtCWlmIChwaXBlID09IElOVkFM SURfUElQRSkgewo+ID4gKwlpbnRlbF9lbmNvZGVyID0gYXVkaW9fcG9ydF90b19lbmNvZGVyKGRy bV9kZXYsIHBvcnQpOwo+ID4gKwlpZiAoIWludGVsX2VuY29kZXIgfHwgaW50ZWxfZW5jb2Rlci0+ dHlwZSAhPSBJTlRFTF9PVVRQVVRfSERNSSkgewo+ID4gIAkJRFJNX0RFQlVHX0tNUygibm8gcGlw ZSBmb3IgdGhlIHBvcnQgJWNcbiIsIHBvcnRfbmFtZShwb3J0KSk7Cj4gPiAgCQltdXRleF91bmxv Y2soJmRldl9wcml2LT5hdl9tdXRleCk7Cj4gPiAgCQlyZXR1cm4gLUVOT0RFVjsKPiA+ICAJfQo+ ID4gKwljcnRjID0gdG9faW50ZWxfY3J0YyhpbnRlbF9lbmNvZGVyLT5iYXNlLmNydGMpOwo+ID4g KwlwaXBlID0gY3J0Yy0+cGlwZTsKPiA+ICAJRFJNX0RFQlVHX0tNUygicGlwZSAlYyBjb25uZWN0 cyBwb3J0ICVjXG4iLAo+ID4gIAkJCQkgIHBpcGVfbmFtZShwaXBlKSwgcG9ydF9uYW1lKHBvcnQp KTsKPiA+ICAJbW9kZSA9ICZjcnRjLT5jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZTsKPiA+IEBA IC03MTcsMjMgKzcyNSwxOCBAQCBzdGF0aWMgaW50IGk5MTVfYXVkaW9fY29tcG9uZW50X2dldF9l bGQoc3RydWN0IGRldmljZSAqZGV2LCBpbnQgcG9ydCwKPiA+ICAJaW50IHJldCA9IC1FSU5WQUw7 Cj4gPiAgCj4gPiAgCW11dGV4X2xvY2soJmRldl9wcml2LT5hdl9tdXRleCk7Cj4gPiAtCWZvcl9l YWNoX2ludGVsX2VuY29kZXIoZHJtX2RldiwgaW50ZWxfZW5jb2Rlcikgewo+ID4gLQkJaWYgKGlu dGVsX2VuY29kZXItPnR5cGUgIT0gSU5URUxfT1VUUFVUX0RJU1BMQVlQT1JUICYmCj4gPiAtCQkg ICAgaW50ZWxfZW5jb2Rlci0+dHlwZSAhPSBJTlRFTF9PVVRQVVRfSERNSSkKPiA+IC0JCQljb250 aW51ZTsKPiA+ICsJaW50ZWxfZW5jb2RlciA9IGF1ZGlvX3BvcnRfdG9fZW5jb2Rlcihkcm1fZGV2 LCBwb3J0KTsKPiA+ICsJaWYgKGludGVsX2VuY29kZXIpIHsKPiA+ICsJCXJldCA9IDA7Cj4gPiAg CQlpbnRlbF9kaWdfcG9ydCA9IGVuY190b19kaWdfcG9ydCgmaW50ZWxfZW5jb2Rlci0+YmFzZSk7 Cj4gPiAtCQlpZiAocG9ydCA9PSBpbnRlbF9kaWdfcG9ydC0+cG9ydCkgewo+ID4gLQkJCXJldCA9 IDA7Cj4gPiAtCQkJKmVuYWJsZWQgPSBpbnRlbF9kaWdfcG9ydC0+YXVkaW9fZW5hYmxlZDsKPiA+ IC0JCQlpZiAoISplbmFibGVkKQo+ID4gLQkJCQlicmVhazsKPiA+ICsJCSplbmFibGVkID0gaW50 ZWxfZGlnX3BvcnQtPmF1ZGlvX2VuYWJsZWQ7Cj4gPiArCQlpZiAoKmVuYWJsZWQpIHsKPiA+ICAJ CQljb25uZWN0b3IgPSBkcm1fc2VsZWN0X2VsZCgmaW50ZWxfZW5jb2Rlci0+YmFzZSk7Cj4gPiAt CQkJaWYgKCFjb25uZWN0b3IpCj4gPiAtCQkJCWJyZWFrOwo+ID4gLQkJCWVsZCA9IGNvbm5lY3Rv ci0+ZWxkOwo+ID4gLQkJCXJldCA9IG1pbihtYXhfYnl0ZXMsIGRybV9lbGRfc2l6ZShlbGQpKTsK PiA+IC0JCQltZW1jcHkoYnVmLCBlbGQsIHJldCk7Cj4gPiAtCQkJYnJlYWs7Cj4gPiArCQkJaWYg KGNvbm5lY3Rvcikgewo+ID4gKwkJCQllbGQgPSBjb25uZWN0b3ItPmVsZDsKPiA+ICsJCQkJcmV0 ID0gbWluKG1heF9ieXRlcywgZHJtX2VsZF9zaXplKGVsZCkpOwo+ID4gKwkJCQltZW1jcHkoYnVm LCBlbGQsIHJldCk7Cj4gPiArCQkJfQo+ID4gIAkJfQo+ID4gIAl9Cj4gPiAgCj4gPiAtLSAKPiA+ IDIuNi4zCj4gPiAKPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCj4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCj4gPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cj4gCj4gLS0gCj4gRGFuaWVsIFZldHRlcgo+IFNvZnR3YXJlIEVuZ2lu ZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+IGh0dHA6Ly9ibG9nLmZmd2xsLmNoCj4gCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==