Re: [PATCH v2 2/9] drm/i915: Add get_eld audio component

Takashi Iwai
2015-12-04T16:03:57Z

On Fri, 04 Dec 2015 16:54:32 +0100,
Daniel Vetter wrote:
>
> On Fri, Dec 04, 2015 at 04:15:24PM +0100, Takashi Iwai wrote:
> > diff --git a/include/drm/i915_component.h b/include/drm/i915_component.h
> > index 30d89e0da2c6..058d39e8d57f 100644
> > --- a/include/drm/i915_component.h
> > +++ b/include/drm/i915_component.h
> > @@ -38,6 +38,7 @@
> > * @codec_wake_override: Enable/Disable generating the codec wake signal
> > * @get_cdclk_freq: get the Core Display Clock in KHz
> > * @sync_audio_rate: set n/cts based on the sample rate
> > + * @get_eld: fill the audio state and ELD bytes for the given port
>
> One more: You seem to still be on an old baseline, with switched to the
> new in-line comment layout. That allows you to spec the callback semantics
> in much more detail since it allows real paragraphs.

Yes, I've been waiting for your (or Dave's) answer to my previous
question: which branch can I use as a solid base?

Takashi