From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] drm/i915: Suppress hotplug work during	PM
	suspend/resume
Date: Thu, 10 May 2012 10:40:52 +0200
Message-ID: <s5hwr4kv36z.wl%tiwai@suse.de>
References: <s5hlilr4s9h.wl%tiwai@suse.de> <1334858104.32618.28.camel@atropine>
	<s5hty0f7frq.wl%tiwai@suse.de> <s5hd36w2pok.wl%tiwai@suse.de>
	<s5hehqswnlo.wl%tiwai@suse.de>
	<20120510082919.GA4867@phenom.ffwll.local>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
	by gabe.freedesktop.org (Postfix) with ESMTP id ED4E69EC29
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 10 May 2012 01:40:53 -0700 (PDT)
In-Reply-To: <20120510082919.GA4867@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

At Thu, 10 May 2012 10:29:19 +0200,
Daniel Vetter wrote:
> 
> On Thu, May 10, 2012 at 08:34:43AM +0200, Takashi Iwai wrote:
> > At Wed, 25 Apr 2012 10:14:51 +0200,
> > Takashi Iwai wrote:
> > > 
> > > At Thu, 19 Apr 2012 20:11:53 +0200,
> > > Takashi Iwai wrote:
> > > > 
> > > > At Thu, 19 Apr 2012 13:55:04 -0400,
> > > > Adam Jackson wrote:
> > > > > 
> > > > > On Thu, 2012-04-19 at 18:10 +0200, Takashi Iwai wrote:
> > > > > 
> > > > > > This patch adds a flag to disable the hotplug during PM operation for
> > > > > > avoiding such a race.
> > > > > > 
> > > > > > Cc: <stable@kernel.org>
> > > > > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > > > > 
> > > > > This seems simpler (untested):
> > > > 
> > > > This looks promising.  I'll ask a test with your patch.
> > > 
> > > Tester reported a positive feedback.  But he also experienced with a
> > > blank screen after a couple of S4 resumes.  Now it's being checked
> > > whether it's a regression by the patch or not.
> > 
> > It seems unrelated with the patch itself.  So, from my side,
> > 	Reviewed-by: Takashi Iwai <tiwai@suse.de>
> > 
> > Adam, could you resubmit it with a proper sign-off so that it can be
> > merged for 3.4 or 3.5, preferably with Cc to stable kernel?
> 
> Note that
> 
> daniel@phenom:~/linux/src$ git show
> 8b2e326dc7c5aa6952c88656d04d0d81fd85a6f8
> commit 8b2e326dc7c5aa6952c88656d04d0d81fd85a6f8
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Tue Apr 24 22:59:41 2012 +0100
> 
>     drm/i915: Unconditionally initialise the interrupt workers
> 
> in drm-intel-next is closes a race around suspend/resume that could lead
> to an oops somewhere on resume.

I don't think it's missing hotplug initializations. It's no Oops but
the race between the resume procedure being processed and the hotplug
work triggered during the resume procedure.


thanks,

Takashi