From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] drm/i915: Acquire audio powerwell for HD-Audio registers Date: Thu, 04 Aug 2016 23:03:38 +0200 Message-ID: References: <1470240540-29004-1-git-send-email-chris@chris-wilson.co.uk> <20160804164411.GS6232@phenom.ffwll.local> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id F149F6EA6E for ; Thu, 4 Aug 2016 21:03:40 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Hans de Goede , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org W2Ryb3BwZWQgc3RhYmxlIE1MIGFuZCBhZGQgYSBmZXcgb3RoZXIgcmVsZXZhbnQgcGVvcGxlIHRv IENjXQoKT24gVGh1LCAwNCBBdWcgMjAxNiAyMDowNToyNyArMDIwMCwKVGFrYXNoaSBJd2FpIHdy b3RlOgo+IAo+IE9uIFRodSwgMDQgQXVnIDIwMTYgMTg6NDQ6MTEgKzAyMDAsCj4gRGFuaWVsIFZl dHRlciB3cm90ZToKPiA+IAo+ID4gT24gV2VkLCBBdWcgMDMsIDIwMTYgYXQgMDU6MDk6MDBQTSAr MDEwMCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+ID4gPiBPbiBIYXN3ZWxsL0Jyb2Fkd2VsbCwgdGhl IEhELUF1ZGlvIGJsb2NrIGlzIGluc2lkZSB0aGUgSERNSS9kaXNwbGF5Cj4gPiA+IHBvd2VyIHdl bGwgYW5kIHNvIHRoZSBzbmEtaGRhIGF1ZGlvIGNvZGVjIGFjcXVpcmVzIHRoZSBkaXNwbGF5IHBv d2VyCj4gPiA+IHdlbGwgd2hpbGUgaXQgaXMgb3BlcmF0aW9uYWwuIEhvd2V2ZXIsIFNreWxha2Ug c2VwYXJhdGVzIHRoZSBwb3dlcndlbGxzCj4gPiA+IGFnYWluLCBidXQgeWV0IHdlIHN0aWxsIG5l ZWQgdGhlIGF1ZGlvIHBvd2Vyd2VsbCB0byBzZXR1cCB0aGUgcmVnaXN0ZXJzLgo+ID4gPiAoQnV0 IHRoZW4gdGhlIGhhcmR3YXJlIHVzZXMgdGhvc2UgcmVnaXN0ZXJzIGV2ZW4gd2hpbGUgcG93ZXJl ZCBvZmY/Pz8pCj4gPiAKPiA+IFllYWggZmVlbHMgZmlzaHksIGJ1dCB3aWxsIGF0IGxlYXN0IGR1 Y3QtdGFwZSBvdmVyIHRoZSBicmVha2FnZSBmcm9tIHRoZQo+ID4gYXVkaW8gc2lkZS4gTW9zdCBs aWtlbHkgdGhlIHJlZyB3cml0ZXMgZ28gZXhhY3RseSBub3doZXJlIGFuZCB0aGVyZSdzIGEKPiA+ IGJ1ZyBvbiB0aGUgYXVkaW8gc2lkZS4gQW5kIHRoaXMgcGF0Y2ggZG9lc24ndCBmaXggdGhhdC4K PiAKPiBXZWxsLCBpZiB0aGUgcmVsZXZhbnQgY29kZSBwYXRocyBhcmUgb25seSBvdmVyIHRoZXNl IGNhbGxiYWNrcywgSQo+IGd1ZXNzIHRoZSBmb2xsb3dpbmcgZml4IHdvdWxkIHdvcmsgaW5zdGVh ZC4KPiAKPiBDYW4gYW55b25lIGNoZWNrPwoKU2NyYXRjaCB0aGUgcHJldmlvdXMgb25lLiAgVGhl cmUgaXMgYW5vdGhlciBwbGFjZSBjYWxsaW5nIHNpbWlsYXJseS4KCk5vdyBsb29raW5nIGJhY2sg YXQgdGhlIGNvZGUgYWdhaW4sIEkgYmVsaWV2ZSB0aGF0IHRoZSBiZXR0ZXIgd2F5CndvdWxkIGJl IHRvIHByb3Blcmx5IGRvIHBvd2VyIHVwIC8gZG93biBhdCB0aGUgcmVzdW1lIGNhbGxiYWNrcy4K CkJlbG93IGlzIGFuIHVudGVzdGVkIHBhdGNoLiAgTGV0IG1lIGtub3cgaWYgdGhpcyBhY3R1YWxs eSB3b3Jrcy4KCgp0aGFua3MsCgpUYWthc2hpCgotLSA4PCAtLQpGcm9tOiBUYWthc2hpIEl3YWkg PHRpd2FpQHN1c2UuZGU+ClN1YmplY3Q6IFtQQVRDSF0gQUxTQTogaGRhIC0gTWFuYWdlIHBvd2Vy IHdlbGwgcHJvcGVybHkgZm9yIHJlc3VtZQoKRm9yIFNLTCBhbmQgbGF0ZXIgSW50ZWwgY2hpcHMs IHdlIGNvbnRyb2wgdGhlIHBvd2VyIHdlbGwgcGVyIGNvZGVjCmJhc2lzIHZpYSBsaW5rX3Bvd2Vy IGNhbGxiYWNrIHNpbmNlIHRoZSBjb21taXQgWzAzYjEzNWNlYmM0NzogQUxTQToKaGRhIC0gcmVt b3ZlIGRlcGVuZGVuY3kgb24gaTkxNSBwb3dlciB3ZWxsIGZvciBTS0xdLgpIb3dldmVyLCB0aGVy ZSBhcmUgYSBmZXcgZXhjZXB0aW9uYWwgY2FzZXMgd2hlcmUgdGhlIGdmeCByZWdpc3RlcnMgYXJl CmFjY2Vzc2VkIGZyb20gdGhlIGF1ZGlvIGRyaXZlcjogbmFtZWx5IHRoZSB3YWtldXAgb3ZlcnJp ZGUgYml0CnRvZ2dsaW5nIGF0IChib3RoIHN5c3RlbSBhbmQgcnVudGltZSkgcmVzdW1lLiAgVGhp cyBzZWVtcyBjYXVzaW5nIGEKa2VybmVsIHdhcm5pbmcgd2hlbiBhY2Nlc3NlZCBkdXJpbmcgdGhl IHBvd2VyIHdlbGwgZG93biAoYW5kIGxpa2VseQpyZXN1bHRpbmcgaW4gdGhlIGJvZ3VzIHJlZ2lz dGVyIGFjY2Vzc2VzKS4KClRoaXMgcGF0Y2ggcHV0cyB0aGUgcHJvcGVyIHBvd2VyIHVwIC8gZG93 biBzZXF1ZW5jZSBhcm91bmQgdGhlIHJlc3VtZQpjb2RlIHNvIHRoYXQgdGhlIHdha2V1cCBiaXQg aXMgZmlkZGxlZCBwcm9wZXJseSB3aGlsZSB0aGUgcG93ZXIgaXMKdXAuICAoVGhlIG90aGVyIGNh bGxiYWNrLCBzeW5jX2F1ZGlvX3JhdGUsIGlzIHVzZWQgb25seSBpbiB0aGUgUENNCmNhbGxiYWNr LCBzbyBpdCdzIGd1YXJhbnRlZWQgaW4gdGhlIHBvd2VyLW9uLikKCkFsc28sIGJ5IHRoaXMgcHJv cGVyIHBvd2VyIHVwL2Rvd24sIHRoZSBpbnN0YW50YW5lb3VzIGZsaXAgb2Ygd2FrZXVwCmJpdCBp biB0aGUgcmVzdW1lIGNhbGxiYWNrIHRoYXQgd2FzIGludHJvZHVjZWQgYnkgdGhlIGNvbW1pdApb MDMzZWEzNDlhN2NkOiBBTFNBOiBoZGEgLSBGaXggU2t5bGFrZSBjb2RlYyB0aW1lb3V0XSBiZWNv bWVzCnN1cGVyZmx1b3VzLCBhcyBzbmRfaGRhY19kaXNwbGF5X3Bvd2VyKCkgYWxyZWFkeSBkb2Vz IGl0LiAgU28gd2UgY2FuCmNsZWFuIGl0IHVwIHRvZ2V0aGVyLgoKQnVnemlsbGE6IGh0dHBzOi8v YnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTk2MjE0CkZpeGVzOiAwM2IxMzVj ZWJjNDcgKCdBTFNBOiBoZGEgLSByZW1vdmUgZGVwZW5kZW5jeSBvbiBpOTE1IHBvd2VyIHdlbGwg Zm9yIFNLTCcpClNpZ25lZC1vZmYtYnk6IFRha2FzaGkgSXdhaSA8dGl3YWlAc3VzZS5kZT4KLS0t CiBzb3VuZC9wY2kvaGRhL2hkYV9pbnRlbC5jIHwgMzIgKysrKysrKysrKysrKysrKysrKystLS0t LS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9zb3VuZC9wY2kvaGRhL2hkYV9pbnRlbC5jIGIvc291bmQvcGNpL2hk YS9oZGFfaW50ZWwuYwppbmRleCA4OWRhY2Y5YjRlNmMuLjE2MGM3ZjcxMzcyMiAxMDA2NDQKLS0t IGEvc291bmQvcGNpL2hkYS9oZGFfaW50ZWwuYworKysgYi9zb3VuZC9wY2kvaGRhL2hkYV9pbnRl bC5jCkBAIC05MDYsMjAgKzkwNiwyMyBAQCBzdGF0aWMgaW50IGF6eF9yZXN1bWUoc3RydWN0IGRl dmljZSAqZGV2KQogCXN0cnVjdCBzbmRfY2FyZCAqY2FyZCA9IGRldl9nZXRfZHJ2ZGF0YShkZXYp OwogCXN0cnVjdCBhenggKmNoaXA7CiAJc3RydWN0IGhkYV9pbnRlbCAqaGRhOworCXN0cnVjdCBo ZGFjX2J1cyAqYnVzOwogCiAJaWYgKCFjYXJkKQogCQlyZXR1cm4gMDsKIAogCWNoaXAgPSBjYXJk LT5wcml2YXRlX2RhdGE7CiAJaGRhID0gY29udGFpbmVyX29mKGNoaXAsIHN0cnVjdCBoZGFfaW50 ZWwsIGNoaXApOworCWJ1cyA9IGF6eF9idXMoY2hpcCk7CiAJaWYgKGNoaXAtPmRpc2FibGVkIHx8 IGhkYS0+aW5pdF9mYWlsZWQgfHwgIWNoaXAtPnJ1bm5pbmcpCiAJCXJldHVybiAwOwogCi0JaWYg KGNoaXAtPmRyaXZlcl9jYXBzICYgQVpYX0RDQVBTX0k5MTVfUE9XRVJXRUxMCi0JCSYmIGhkYS0+ bmVlZF9pOTE1X3Bvd2VyKSB7Ci0JCXNuZF9oZGFjX2Rpc3BsYXlfcG93ZXIoYXp4X2J1cyhjaGlw KSwgdHJ1ZSk7Ci0JCXNuZF9oZGFjX2k5MTVfc2V0X2JjbGsoYXp4X2J1cyhjaGlwKSk7CisJaWYg KGNoaXAtPmRyaXZlcl9jYXBzICYgQVpYX0RDQVBTX0k5MTVfUE9XRVJXRUxMKSB7CisJCXNuZF9o ZGFjX2Rpc3BsYXlfcG93ZXIoYnVzLCB0cnVlKTsKKwkJaWYgKGhkYS0+bmVlZF9pOTE1X3Bvd2Vy KQorCQkJc25kX2hkYWNfaTkxNV9zZXRfYmNsayhidXMpOwogCX0KKwogCWlmIChjaGlwLT5tc2kp CiAJCWlmIChwY2lfZW5hYmxlX21zaShwY2kpIDwgMCkKIAkJCWNoaXAtPm1zaSA9IDA7CkBAIC05 MjksNiArOTMyLDExIEBAIHN0YXRpYyBpbnQgYXp4X3Jlc3VtZShzdHJ1Y3QgZGV2aWNlICpkZXYp CiAKIAloZGFfaW50ZWxfaW5pdF9jaGlwKGNoaXAsIHRydWUpOwogCisJLyogcG93ZXIgZG93biBh Z2FpbiBmb3IgbGluay1jb250cm9sbGVkIGNoaXBzICovCisJaWYgKChjaGlwLT5kcml2ZXJfY2Fw cyAmIEFaWF9EQ0FQU19JOTE1X1BPV0VSV0VMTCkgJiYKKwkgICAgIWhkYS0+bmVlZF9pOTE1X3Bv d2VyKQorCQlzbmRfaGRhY19kaXNwbGF5X3Bvd2VyKGJ1cywgZmFsc2UpOworCiAJc25kX3Bvd2Vy X2NoYW5nZV9zdGF0ZShjYXJkLCBTTkRSVl9DVExfUE9XRVJfRDApOwogCiAJdHJhY2VfYXp4X3Jl c3VtZShjaGlwKTsKQEAgLTEwMDgsNiArMTAxNiw3IEBAIHN0YXRpYyBpbnQgYXp4X3J1bnRpbWVf cmVzdW1lKHN0cnVjdCBkZXZpY2UgKmRldikKIAogCWNoaXAgPSBjYXJkLT5wcml2YXRlX2RhdGE7 CiAJaGRhID0gY29udGFpbmVyX29mKGNoaXAsIHN0cnVjdCBoZGFfaW50ZWwsIGNoaXApOworCWJ1 cyA9IGF6eF9idXMoY2hpcCk7CiAJaWYgKGNoaXAtPmRpc2FibGVkIHx8IGhkYS0+aW5pdF9mYWls ZWQpCiAJCXJldHVybiAwOwogCkBAIC0xMDE1LDE1ICsxMDI0LDkgQEAgc3RhdGljIGludCBhenhf cnVudGltZV9yZXN1bWUoc3RydWN0IGRldmljZSAqZGV2KQogCQlyZXR1cm4gMDsKIAogCWlmIChj aGlwLT5kcml2ZXJfY2FwcyAmIEFaWF9EQ0FQU19JOTE1X1BPV0VSV0VMTCkgewotCQlidXMgPSBh enhfYnVzKGNoaXApOwotCQlpZiAoaGRhLT5uZWVkX2k5MTVfcG93ZXIpIHsKLQkJCXNuZF9oZGFj X2Rpc3BsYXlfcG93ZXIoYnVzLCB0cnVlKTsKKwkJc25kX2hkYWNfZGlzcGxheV9wb3dlcihidXMs IHRydWUpOworCQlpZiAoaGRhLT5uZWVkX2k5MTVfcG93ZXIpCiAJCQlzbmRfaGRhY19pOTE1X3Nl dF9iY2xrKGJ1cyk7Ci0JCX0gZWxzZSB7Ci0JCQkvKiB0b2dnbGUgY29kZWMgd2FrZXVwIGJpdCBm b3IgU1RBVEVTVFMgcmVhZCAqLwotCQkJc25kX2hkYWNfc2V0X2NvZGVjX3dha2V1cChidXMsIHRy dWUpOwotCQkJc25kX2hkYWNfc2V0X2NvZGVjX3dha2V1cChidXMsIGZhbHNlKTsKLQkJfQogCX0K IAogCS8qIFJlYWQgU1RBVEVTVFMgYmVmb3JlIGNvbnRyb2xsZXIgcmVzZXQgKi8KQEAgLTEwNDMs NiArMTA0NiwxMSBAQCBzdGF0aWMgaW50IGF6eF9ydW50aW1lX3Jlc3VtZShzdHJ1Y3QgZGV2aWNl ICpkZXYpCiAJYXp4X3dyaXRldyhjaGlwLCBXQUtFRU4sIGF6eF9yZWFkdyhjaGlwLCBXQUtFRU4p ICYKIAkJCX5TVEFURVNUU19JTlRfTUFTSyk7CiAKKwkvKiBwb3dlciBkb3duIGFnYWluIGZvciBs aW5rLWNvbnRyb2xsZWQgY2hpcHMgKi8KKwlpZiAoKGNoaXAtPmRyaXZlcl9jYXBzICYgQVpYX0RD QVBTX0k5MTVfUE9XRVJXRUxMKSAmJgorCSAgICAhaGRhLT5uZWVkX2k5MTVfcG93ZXIpCisJCXNu ZF9oZGFjX2Rpc3BsYXlfcG93ZXIoYnVzLCBmYWxzZSk7CisKIAl0cmFjZV9henhfcnVudGltZV9y ZXN1bWUoY2hpcCk7CiAJcmV0dXJuIDA7CiB9Ci0tIAoyLjkuMgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==