* [PATCH] drm/i915/selftests: Add RPS debug info for power test failure
@ 2025-08-20 9:45 Sk Anirban
2025-08-20 10:02 ` Andi Shyti
2025-08-20 10:35 ` ✗ i915.CI.BAT: failure for " Patchwork
0 siblings, 2 replies; 5+ messages in thread
From: Sk Anirban @ 2025-08-20 9:45 UTC (permalink / raw)
To: intel-gfx; +Cc: badal.nilawar, anshuman.gupta, riana.tauro, Sk Anirban
Add debug logging to show RPS frequency configuration when the
live_rps_power selftest fails to conserve power at lower frequencies.
This helps diagnose frequency scaling issues by showing max_freq,
rp0_freq, and max_freq_softlimit values.
Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13774
Signed-off-by: Sk Anirban <sk.anirban@intel.com>
---
drivers/gpu/drm/i915/gt/selftest_rps.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
index 73bc91c6ea07..4012213ab1b7 100644
--- a/drivers/gpu/drm/i915/gt/selftest_rps.c
+++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
@@ -1216,6 +1216,11 @@ int live_rps_power(void *arg)
if (11 * min.power > 10 * max.power) {
pr_err("%s: did not conserve power when setting lower frequency!\n",
engine->name);
+ pr_debug("%s: RPS Debug - max_freq:%u:%uMHz, rp0_freq:%u:%uMHz, max_freq_softlimit:%u:%uMHz\n",
+ engine->name, rps->max_freq, intel_gpu_freq(rps, rps->max_freq),
+ rps->rp0_freq, intel_gpu_freq(rps, rps->rp0_freq),
+ rps->max_freq_softlimit, intel_gpu_freq(rps,
+ rps->max_freq_softlimit));
err = -EINVAL;
break;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/selftests: Add RPS debug info for power test failure
2025-08-20 9:45 [PATCH] drm/i915/selftests: Add RPS debug info for power test failure Sk Anirban
@ 2025-08-20 10:02 ` Andi Shyti
2025-08-20 10:11 ` Anirban, Sk
2025-08-20 10:35 ` ✗ i915.CI.BAT: failure for " Patchwork
1 sibling, 1 reply; 5+ messages in thread
From: Andi Shyti @ 2025-08-20 10:02 UTC (permalink / raw)
To: Sk Anirban; +Cc: intel-gfx, badal.nilawar, anshuman.gupta, riana.tauro
Hi,
On Wed, Aug 20, 2025 at 03:15:28PM +0530, Sk Anirban wrote:
> Add debug logging to show RPS frequency configuration when the
> live_rps_power selftest fails to conserve power at lower frequencies.
> This helps diagnose frequency scaling issues by showing max_freq,
> rp0_freq, and max_freq_softlimit values.
>
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13774
how is this helping to close the issue?
Andi
> Signed-off-by: Sk Anirban <sk.anirban@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/selftests: Add RPS debug info for power test failure
2025-08-20 10:02 ` Andi Shyti
@ 2025-08-20 10:11 ` Anirban, Sk
2025-08-20 13:57 ` Andi Shyti
0 siblings, 1 reply; 5+ messages in thread
From: Anirban, Sk @ 2025-08-20 10:11 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx, badal.nilawar, anshuman.gupta, riana.tauro
Hi,
On 20-08-2025 15:32, Andi Shyti wrote:
> Hi,
>
> On Wed, Aug 20, 2025 at 03:15:28PM +0530, Sk Anirban wrote:
>> Add debug logging to show RPS frequency configuration when the
>> live_rps_power selftest fails to conserve power at lower frequencies.
>> This helps diagnose frequency scaling issues by showing max_freq,
>> rp0_freq, and max_freq_softlimit values.
>>
>> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13774
> how is this helping to close the issue?
>
> Andi
Good point - this patch adds debugging capability to investigate the
issue rather than solving it. I'll switch to "References:" instead of
"Closes:" for the proper context.
Thanks,
Anirban
>
>> Signed-off-by: Sk Anirban <sk.anirban@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ i915.CI.BAT: failure for drm/i915/selftests: Add RPS debug info for power test failure
2025-08-20 9:45 [PATCH] drm/i915/selftests: Add RPS debug info for power test failure Sk Anirban
2025-08-20 10:02 ` Andi Shyti
@ 2025-08-20 10:35 ` Patchwork
1 sibling, 0 replies; 5+ messages in thread
From: Patchwork @ 2025-08-20 10:35 UTC (permalink / raw)
To: Anirban, Sk; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 9548 bytes --]
== Series Details ==
Series: drm/i915/selftests: Add RPS debug info for power test failure
URL : https://patchwork.freedesktop.org/series/153205/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_17036 -> Patchwork_153205v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_153205v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_153205v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/index.html
Participating hosts (43 -> 43)
------------------------------
Additional (1): bat-adls-6
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_153205v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@gtt:
- bat-arlh-3: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17036/bat-arlh-3/igt@i915_selftest@live@gtt.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-arlh-3/igt@i915_selftest@live@gtt.html
Known issues
------------
Here are the changes found in Patchwork_153205v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_auth@basic-auth:
- bat-adlp-6: [PASS][3] -> [DMESG-WARN][4] ([i915#13890])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17036/bat-adlp-6/igt@core_auth@basic-auth.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-adlp-6/igt@core_auth@basic-auth.html
* igt@gem_lmem_swapping@parallel-random-engines:
- bat-adls-6: NOTRUN -> [SKIP][5] ([i915#4613]) +3 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-adls-6/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_tiled_pread_basic:
- bat-adls-6: NOTRUN -> [SKIP][6] ([i915#3282])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-adls-6/igt@gem_tiled_pread_basic.html
* igt@i915_selftest@live:
- bat-dg2-8: [PASS][7] -> [ABORT][8] ([i915#14201]) +1 other test abort
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17036/bat-dg2-8/igt@i915_selftest@live.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-dg2-8/igt@i915_selftest@live.html
* igt@i915_selftest@live@reset:
- bat-atsm-1: [PASS][9] -> [ABORT][10] ([i915#14201])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17036/bat-atsm-1/igt@i915_selftest@live@reset.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-atsm-1/igt@i915_selftest@live@reset.html
* igt@i915_selftest@live@workarounds:
- bat-arls-5: [PASS][11] -> [DMESG-FAIL][12] ([i915#12061]) +1 other test dmesg-fail
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17036/bat-arls-5/igt@i915_selftest@live@workarounds.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-arls-5/igt@i915_selftest@live@workarounds.html
- bat-mtlp-6: [PASS][13] -> [DMESG-FAIL][14] ([i915#12061]) +1 other test dmesg-fail
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17036/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
* igt@intel_hwmon@hwmon-read:
- bat-adls-6: NOTRUN -> [SKIP][15] ([i915#7707]) +1 other test skip
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-adls-6/igt@intel_hwmon@hwmon-read.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-adls-6: NOTRUN -> [SKIP][16] ([i915#4103]) +1 other test skip
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-adls-6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_dsc@dsc-basic:
- bat-adls-6: NOTRUN -> [SKIP][17] ([i915#3555] / [i915#3840])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-adls-6/igt@kms_dsc@dsc-basic.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-adls-6: NOTRUN -> [SKIP][18]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-adls-6/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pm_backlight@basic-brightness:
- bat-adls-6: NOTRUN -> [SKIP][19] ([i915#5354])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-adls-6/igt@kms_pm_backlight@basic-brightness.html
* igt@kms_psr@psr-primary-mmap-gtt:
- bat-adls-6: NOTRUN -> [SKIP][20] ([i915#1072] / [i915#9732]) +3 other tests skip
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-adls-6/igt@kms_psr@psr-primary-mmap-gtt.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-adls-6: NOTRUN -> [SKIP][21] ([i915#3555])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-adls-6/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-read:
- bat-adls-6: NOTRUN -> [SKIP][22] ([i915#3291]) +2 other tests skip
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-adls-6/igt@prime_vgem@basic-fence-read.html
#### Possible fixes ####
* {igt@core_debugfs@read-all-entries}:
- bat-adlp-6: [DMESG-WARN][23] ([i915#13890]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17036/bat-adlp-6/igt@core_debugfs@read-all-entries.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-adlp-6/igt@core_debugfs@read-all-entries.html
* igt@i915_selftest@live@workarounds:
- bat-arlh-3: [DMESG-FAIL][25] ([i915#12061]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17036/bat-arlh-3/igt@i915_selftest@live@workarounds.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-arlh-3/igt@i915_selftest@live@workarounds.html
- bat-mtlp-9: [DMESG-FAIL][27] ([i915#12061]) -> [PASS][28] +1 other test pass
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17036/bat-mtlp-9/igt@i915_selftest@live@workarounds.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-mtlp-9/igt@i915_selftest@live@workarounds.html
#### Warnings ####
* igt@i915_selftest@live:
- bat-arlh-3: [DMESG-FAIL][29] ([i915#12061]) -> [INCOMPLETE][30] ([i915#14764] / [i915#14837])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17036/bat-arlh-3/igt@i915_selftest@live.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-arlh-3/igt@i915_selftest@live.html
- bat-atsm-1: [DMESG-FAIL][31] ([i915#12061] / [i915#14204]) -> [ABORT][32] ([i915#14201])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17036/bat-atsm-1/igt@i915_selftest@live.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-atsm-1/igt@i915_selftest@live.html
* igt@i915_selftest@live@mman:
- bat-atsm-1: [DMESG-FAIL][33] ([i915#14204]) -> [DMESG-FAIL][34] ([i915#13929])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17036/bat-atsm-1/igt@i915_selftest@live@mman.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/bat-atsm-1/igt@i915_selftest@live@mman.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#13890]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13890
[i915#13929]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13929
[i915#14201]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14201
[i915#14204]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14204
[i915#14764]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14764
[i915#14837]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14837
[i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#7707]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7707
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
Build changes
-------------
* Linux: CI_DRM_17036 -> Patchwork_153205v1
CI-20190529: 20190529
CI_DRM_17036: 75c7076379611a94502e5a15f26e5b11ea80b465 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8498: 8498
Patchwork_153205v1: 75c7076379611a94502e5a15f26e5b11ea80b465 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_153205v1/index.html
[-- Attachment #2: Type: text/html, Size: 11404 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/selftests: Add RPS debug info for power test failure
2025-08-20 10:11 ` Anirban, Sk
@ 2025-08-20 13:57 ` Andi Shyti
0 siblings, 0 replies; 5+ messages in thread
From: Andi Shyti @ 2025-08-20 13:57 UTC (permalink / raw)
To: Anirban, Sk; +Cc: intel-gfx, badal.nilawar, anshuman.gupta, riana.tauro
Hi,
On Wed, Aug 20, 2025 at 03:41:23PM +0530, Anirban, Sk wrote:
> On 20-08-2025 15:32, Andi Shyti wrote:
> > On Wed, Aug 20, 2025 at 03:15:28PM +0530, Sk Anirban wrote:
> > > Add debug logging to show RPS frequency configuration when the
> > > live_rps_power selftest fails to conserve power at lower frequencies.
> > > This helps diagnose frequency scaling issues by showing max_freq,
> > > rp0_freq, and max_freq_softlimit values.
> > >
> > > Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13774
> > how is this helping to close the issue?
> >
> > Andi
> Good point - this patch adds debugging capability to investigate the issue
> rather than solving it. I'll switch to "References:" instead of "Closes:"
> for the proper context.
no need to resend, it can be changed before applying.
Do you want me to take care of it?
BTW, I don't have anything against the patch itself:
Acked-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks,
Andi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-08-20 13:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-20 9:45 [PATCH] drm/i915/selftests: Add RPS debug info for power test failure Sk Anirban
2025-08-20 10:02 ` Andi Shyti
2025-08-20 10:11 ` Anirban, Sk
2025-08-20 13:57 ` Andi Shyti
2025-08-20 10:35 ` ✗ i915.CI.BAT: failure for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).