From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Packard <keithp@keithp.com>
Subject: Re: [PATCH] drm/i915: limit PM related interrupt enable
	to those we handle
Date: Tue, 09 Aug 2011 10:02:54 -0700
Message-ID: <yun4o1q8qm9.fsf@aiko.keithp.com>
References: <1312907360-2469-1-git-send-email-jbarnes@virtuousgeek.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1612475976=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from keithp.com (home.keithp.com [63.227.221.253])
	by gabe.freedesktop.org (Postfix) with ESMTP id E3CD59E8B8
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  9 Aug 2011 10:02:57 -0700 (PDT)
In-Reply-To: <1312907360-2469-1-git-send-email-jbarnes@virtuousgeek.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============1612475976==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Tue,  9 Aug 2011 09:29:20 -0700, Jesse Barnes <jbarnes@virtuousgeek.org>=
 wrote:

> -	I915_WRITE(GEN6_PMIMR, 0);
> +	I915_WRITE(GEN6_PMIMR, ~GEN6_PM_DEFERRED_EVENTS);
>  	spin_unlock_irq(&dev_priv->rps_lock);
> -	/* enable all PM interrupts */
> -	I915_WRITE(GEN6_PMINTRMSK, 0);
> +	/* Enable only those we respond to in the deferred work handler */
> +	I915_WRITE(GEN6_PMINTRMSK, GEN6_PMINTR_DEFERRED_EVENTS);

I think this is supposed to only enable the DEFERRED_EVENTS, right? In
which case, I think you want to invert that (as 0 enables and 1 disables):

 +	I915_WRITE(GEN6_PMINTRMSK, ~GEN6_PMINTR_DEFERRED_EVENTS);

just like you did for the PMIMR register?

=2D-=20
keith.packard@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFOQWg+Qp8BWwlsTdMRAi89AJ900QpidB1gNLcNp0wUfwG4reaRhACfVeuF
fGYQfN+GmHvGgHYuMNuQgu4=
=n7U4
-----END PGP SIGNATURE-----
--=-=-=--

--===============1612475976==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1612475976==--