From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH] drm/i915: Seperate fence pin counting from normal bind pin counting Date: Sat, 04 Jun 2011 10:38:07 -0700 Message-ID: References: <1307177743-3195-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0121991301==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id A1E569E839 for ; Sat, 4 Jun 2011 10:38:14 -0700 (PDT) In-Reply-To: <1307177743-3195-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org --===============0121991301== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Sat, 4 Jun 2011 09:55:43 +0100, Chris Wilson = wrote: > In order to correctly account for reserving space in the GTT and fences > for a batch buffer, we need to independently track whether the fence is > pinned due to a fenced GPU access in the batch from from whether the > buffer is pinned in the aperture. Currently we count the fenced as > pinned if the buffer has already been seen in the execbuffer. This leads > to a false accounting of available fence registers, causing frequent > mass evictions. Worse, if coupled with the change to make > i915_gem_object_get_fence() report EDADLK upon fence starvation, the > batchbuffer can fail with only one fence required... I'm afraid you've completely lost me here. Can you provide a small example (libdrm?) program which exhibits the failure so I can follow what the problem is? And, if I understand any of this at all, I should remove the patch to return -EDEADLK from i915_gem_object_get_fence as we may run out of fence registers even if the client is accounting for them correctly. If so, I'll remove that from my list of -fixes patches. As this is a performance optimization, I also expect to see convincing benchmark data before this patch could be considered for merging. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFN6m1/Qp8BWwlsTdMRAk0LAJ9UtREo7N9Xqw1fCiQY7GVEAmnBIgCgzbYn w58JUkxNoe3W82lAcmAhgPc= =yiCY -----END PGP SIGNATURE----- --=-=-=-- --===============0121991301== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0121991301==--