public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Keith Packard <keithp@keithp.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/crt: Explicitly return false if connected to a digital monitor
Date: Mon, 04 Apr 2011 09:27:09 -0700	[thread overview]
Message-ID: <yun4o6easo2.fsf@aiko.keithp.com> (raw)
In-Reply-To: <b7da2f$qvddbq@fmsmga001.fm.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 448 bytes --]

On Mon, 04 Apr 2011 16:25:27 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:

> This doesn't change the nature of the test, just adds a debug
> message so that we explain why it was rejected. Vital information should
> anyone report a bug with a connected VGA monitor.

Sorry, I didn't look at the context of the patch closely enough. This
looks good.

Reviewed-by: Keith Packard <keithp@keithp.com>

-- 
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2011-04-04 16:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-04  6:26 [PATCH 1/2] drm/i915/crt: Remove 0xa0 probe for CRT Chris Wilson
2011-04-04  6:26 ` [PATCH 2/2] drm/i915/crt: Explicitly return false if connected to a digital monitor Chris Wilson
2011-04-04 15:09   ` Keith Packard
2011-04-04 15:25     ` Chris Wilson
2011-04-04 16:27       ` Keith Packard [this message]
2011-04-04 15:08 ` [PATCH 1/2] drm/i915/crt: Remove 0xa0 probe for CRT Keith Packard
2011-04-04 15:29   ` Chris Wilson
2011-04-04 16:26     ` Keith Packard
2011-04-05  0:19       ` Dave Airlie
2011-04-05  1:04         ` Keith Packard
2011-04-05  9:18       ` Chris Wilson
2011-04-05  1:57 ` Keith Packard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yun4o6easo2.fsf@aiko.keithp.com \
    --to=keithp@keithp.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox