From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH] i915: Enable SDVO hotplug interrupts for HDMI and DVI Date: Mon, 19 Sep 2011 21:24:08 -0700 Message-ID: References: <1313574741-31193-1-git-send-email-simon.farnsworth@onelan.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2003712074==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D12EA0223 for ; Mon, 19 Sep 2011 21:24:13 -0700 (PDT) In-Reply-To: <1313574741-31193-1-git-send-email-simon.farnsworth@onelan.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Simon Farnsworth , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org --===============2003712074== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Wed, 17 Aug 2011 10:52:21 +0100, Simon Farnsworth wrote: > static bool > intel_sdvo_multifunc_encoder(struct intel_sdvo *intel_sdvo) > @@ -2062,7 +2053,10 @@ intel_sdvo_dvi_init(struct intel_sdvo *intel_sdvo,= int device) >=20=20 > intel_connector =3D &intel_sdvo_connector->base; > connector =3D &intel_connector->base; > - connector->polled =3D DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_D= ISCONNECT; > + if (intel_sdvo_supports_hotplug(intel_sdvo) & (1 << device)) > + connector->polled =3D DRM_CONNECTOR_POLL_HPD; > + else > + connector->polled =3D DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_= DISCONNECT; > encoder->encoder_type =3D DRM_MODE_ENCODER_TMDS; > connector->connector_type =3D DRM_MODE_CONNECTOR_DVID; >=20=20 > @@ -2587,6 +2581,11 @@ bool intel_sdvo_init(struct drm_device *dev, int s= dvo_reg) > &intel_sdvo->pixel_clock_max)) > goto err; >=20=20 > + if (intel_sdvo_supports_hotplug(intel_sdvo)) { > + intel_encoder->hot_plug =3D intel_sdvo_do_hotplug; > + intel_sdvo_set_hotplug(intel_sdvo); > + } > + This all looks quite reasonable, about the only thing I would suggest is that you avoid calling intel_sdvo_supports_hotplug twice in intel_sdvo_init and simply look at connector->polled to see if the HPD bit is set. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFOeBVoQp8BWwlsTdMRAtmDAJ9Sf/5ueSwkJIqsssadaX6WNKaKTgCg4LSd Ir7gwlttOM9afNqx2zmqrsg= =Zoq2 -----END PGP SIGNATURE----- --=-=-=-- --===============2003712074== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============2003712074==--