From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 1/2] drm/i915/crt: Remove 0xa0 probe for CRT Date: Mon, 04 Apr 2011 08:08:40 -0700 Message-ID: References: <1301898405-6999-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0533714463==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 58DC69E797 for ; Mon, 4 Apr 2011 08:08:47 -0700 (PDT) In-Reply-To: <1301898405-6999-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0533714463== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Mon, 4 Apr 2011 07:26:44 +0100, Chris Wilson = wrote: > Following the fix to reset the GMBUS controller after a NAK, we finally > utilize the 0xa0 probe for a CRT connection. And discover that it is > useless as it simply detects the presence of the controller and not the > actual monitor. Given that we already probe 0x50 prior to performing the > EDID retrieval, we can simply remove the redundant probe to 0xa0. I don't understand -- are you saying that there is additional hardware somewhere in the machine responding to I2C transactions on the monitor's DDC bus? And if so, how was this extra transaction breaking things? The GMBUS reset patch should only have an effect when there are failed transactions, not successful ones, and then it should only cause future transactions to fail, not succeed. Besides, the 0xA0 transaction looks like the first one on the bus. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFNmd74Qp8BWwlsTdMRAqTBAJ9MTD0V5fGxk9+0jP3ORMYYJvCbSQCdHM1F VnFlAfd+ryNO6BpGsfWp8Kc= =Gtu+ -----END PGP SIGNATURE----- --=-=-=-- --===============0533714463== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0533714463==--