From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Packard <keithp@keithp.com>
Subject: Re: [PATCH 1/5] drm/i915: Initialise g4x watermarks for
	disabled pipes
Date: Tue, 05 Apr 2011 13:56:37 -0700
Message-ID: <yunmxk4fmd6.fsf@aiko.keithp.com>
References: <1301995458-2699-1-git-send-email-chris@chris-wilson.co.uk>
	<1301995458-2699-2-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0310811987=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from keithp.com (home.keithp.com [63.227.221.253])
	by gabe.freedesktop.org (Postfix) with ESMTP id 2AFDC9E734
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  5 Apr 2011 13:56:41 -0700 (PDT)
In-Reply-To: <1301995458-2699-2-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============0310811987==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Tue,  5 Apr 2011 10:24:14 +0100, Chris Wilson <chris@chris-wilson.co.uk>=
 wrote:

>  	crtc =3D intel_get_crtc_for_plane(dev, plane);
> -	if (crtc->fb =3D=3D NULL || !crtc->enabled)
> +	if (crtc->fb =3D=3D NULL || !crtc->enabled) {
> +		*cursor_wm =3D *plane_wm =3D display->guard_size;
>  		return false;
> +	}

Would it be clearer to have g4x_update_wm set these instead?

I'm also a bit concerned about the default value; it would be lovely to
have the docs say what the value should be for disabled pipes, but I
couldn't find any mention of them.

=2D-=20
keith.packard@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFNm4IFQp8BWwlsTdMRAhX/AKCp1yLfcjnWvFUUm/LeDaTi9dHGvwCg1CXW
c7WUpjTRZuCyeG6j5ezg+u0=
=PbZ0
-----END PGP SIGNATURE-----
--=-=-=--

--===============0310811987==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============0310811987==--