From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 08/17] drm/i915: Move the tracking of dpms_mode down into crtc enable/disable Date: Wed, 04 May 2011 12:10:06 -0700 Message-ID: References: <1303420712-6369-1-git-send-email-chris@chris-wilson.co.uk> <1303420712-6369-9-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0046035650==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id C68BC9EB08 for ; Wed, 4 May 2011 12:10:10 -0700 (PDT) In-Reply-To: <1303420712-6369-9-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0046035650== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Thu, 21 Apr 2011 22:18:23 +0100, Chris Wilson = wrote: > As we failed to update the dpms_mode after modeset, where it is presumed > to have been changed to DRM_MODE_DPMS_ON by the upper layers the dpms sta= te > on the crtc became inconsistent with its actual active state. This > notably confused code and left the pipe active when it was meant to be > disabled, leading to PGTBL_ER if the fb was subsequently moved. >=20 > As we use the dpms_mode state for restoring the crtc after load-detection, > we can not simply remove it in favour of simply using the active > state. I don't understand this comment -- this patch changes the code so that dpms_mode exactly tracks active, instead of tracking the desired DPMS state. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFNwaSPQp8BWwlsTdMRAvwJAKCscBpV1U9Jm+NOzXN4KH+SiET6rACeK2QZ JsMmm19sfVYRX86uRtRn644= =h8Kq -----END PGP SIGNATURE----- --=-=-=-- --===============0046035650== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0046035650==--