From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 2/3] drm/i915: Attach a fb to the load-detect pipe Date: Tue, 19 Apr 2011 14:26:04 -0700 Message-ID: References: <1303245123-27172-1-git-send-email-chris@chris-wilson.co.uk> <1303245123-27172-3-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1009636797==" Return-path: Received: from keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 3FE549E710 for ; Tue, 19 Apr 2011 14:26:08 -0700 (PDT) In-Reply-To: <1303245123-27172-3-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1009636797== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Tue, 19 Apr 2011 21:32:02 +0100, Chris Wilson = wrote: > We need to ensure that we feed valid memory into the display plane > attached to the pipe when switching the pipe on. Otherwise, the display > engine may read through an invalid PTE and so throw an PGTBL_ER > exception. This seems to rewrite most of the load detection code, but doesn't justify that rewrite in comments (either commit or in-line). You'll need to break this up so that we can actually see what is changing. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQFNrf3sQp8BWwlsTdMRAkmDAKCeo21+URtdW2MhWcQkv+I8H1VYXgCgyVx8 E5QQTdo3lQNLES+Y2xcJ7tI= =UULT -----END PGP SIGNATURE----- --=-=-=-- --===============1009636797== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1009636797==--