[PATCH] drm/i915/lvds: Always return connected in the absence of better information

[PATCH] drm/i915/lvds: Always return connected in the absence of better information

[Chris Wilson]

The LVDS connector should default to connected. We tried our best to
verify the claims of the BIOS that the hardware exists during init(),
and then during detect() we then try to verify that the panel is open.
In the event of an unsucessful query, we should then always report
that the LVDS panel is connected. This was only the case for gen3/4,
later generations leaked the return value from the panel probe instead.

Reported-by: Alessandro Suardi <alessandro.suardi@gmail.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_lvds.c |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
index 1a311ad..86cd30b 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm/i915/intel_lvds.c
@@ -473,19 +473,13 @@ static enum drm_connector_status
 intel_lvds_detect(struct drm_connector *connector, bool force)
 {
 	struct drm_device *dev = connector->dev;
-	enum drm_connector_status status = connector_status_connected;
+	enum drm_connector_status status;
 
 	status = intel_panel_detect(dev);
 	if (status != connector_status_unknown)
 		return status;
 
-	/* ACPI lid methods were generally unreliable in this generation, so
-	 * don't even bother.
-	 */
-	if (IS_GEN2(dev) || IS_GEN3(dev))
-		return connector_status_connected;
-
-	return status;
+	return connector_status_connected;
 }
 
 /**
-- 
1.7.4.1

Re: [PATCH] drm/i915/lvds: Always return connected in the absence of better information

[Alessandro Suardi]

On Thu, Mar 24, 2011 at 2:30 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> The LVDS connector should default to connected. We tried our best to
> verify the claims of the BIOS that the hardware exists during init(),
> and then during detect() we then try to verify that the panel is open.
> In the event of an unsucessful query, we should then always report
> that the LVDS panel is connected. This was only the case for gen3/4,
> later generations leaked the return value from the panel probe instead.
>
> Reported-by: Alessandro Suardi <alessandro.suardi@gmail.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

With this patch on top of 2.6.38-git14, I am back to 1440x900 by default.
Great work, thanks Chris ! FWIW, You can add my

Tested-by: Alessandro Suardi <alessandro.suardi@gmail.com>

> ---
>  drivers/gpu/drm/i915/intel_lvds.c |   10 ++--------
>  1 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
> index 1a311ad..86cd30b 100644
> --- a/drivers/gpu/drm/i915/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/intel_lvds.c
> @@ -473,19 +473,13 @@ static enum drm_connector_status
>  intel_lvds_detect(struct drm_connector *connector, bool force)
>  {
>        struct drm_device *dev = connector->dev;
> -       enum drm_connector_status status = connector_status_connected;
> +       enum drm_connector_status status;
>
>        status = intel_panel_detect(dev);
>        if (status != connector_status_unknown)
>                return status;
>
> -       /* ACPI lid methods were generally unreliable in this generation, so
> -        * don't even bother.
> -        */
> -       if (IS_GEN2(dev) || IS_GEN3(dev))
> -               return connector_status_connected;
> -
> -       return status;
> +       return connector_status_connected;
>  }
>
>  /**
> --
> 1.7.4.1
>
>

--alessandro

 "There's always a siren singing you to shipwreck"

   (Radiohead, "There There")

Re: [PATCH] drm/i915/lvds: Always return connected in the absence of better information

[Keith Packard]

[-- Attachment #1.1: Type: text/plain, Size: 82 bytes --]


Reviewed-by: Keith Packard <keithp@keithp.com>

-- 
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx