From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 903BFF5A8A2 for ; Mon, 20 Apr 2026 23:44:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 2D13C610F0; Mon, 20 Apr 2026 23:44:53 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id zQDilOCTkKRg; Mon, 20 Apr 2026 23:44:51 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org CC376610EB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1776728691; bh=Fn39R49cvvCQiee+nSTgKD5AhfYhQxX0XlPGn3GGFeY=; h=Date:To:CC:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=dceoKjM4gaEZnTkjEgdItwfwPu9KBW0/XqpTl4dFyU22u6hjL/OiA0+YhyOzE3ZEw 4nq9LLLHK1e2DXAQKSWfnGlfgQ6jkzZmAWcl0ut8Rf6J5m9aOXzCyzaDoSCKQMApZL lhT+inrvvGpZcaJhs3jtmJmgUh2BYwDkcPUqdXoOOxVSc37KNBOlFnPKvw4iLFnb4i 6iKszkZIptVOqFBYm1QUaCbqLMm+wkY7XOwc6KIPIcYB/+l3+io8IR8oaznAKSFM45 18R+QTZczwv31Dj7lBLLQy4bRBORZdMZAVkcjd5fbkOVJcNVh2bzbPGrb1EbnSUsyK J7kaPO/FQ/5Vw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id CC376610EB; Mon, 20 Apr 2026 23:44:51 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id 87BB8257 for ; Mon, 20 Apr 2026 23:44:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 6CECE610EB for ; Mon, 20 Apr 2026 23:44:50 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id VAFEaKC-MUsX for ; Mon, 20 Apr 2026 23:44:49 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.12; helo=mgamail.intel.com; envelope-from=jacob.e.keller@intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org E1230610EA DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org E1230610EA Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by smtp3.osuosl.org (Postfix) with ESMTPS id E1230610EA for ; Mon, 20 Apr 2026 23:44:48 +0000 (UTC) X-CSE-ConnectionGUID: vgrewSM5SnuxuROZFDDXGw== X-CSE-MsgGUID: faxX8gLRTlOu/qZxa7CHXQ== X-IronPort-AV: E=McAfee;i="6800,10657,11762"; a="89124035" X-IronPort-AV: E=Sophos;i="6.23,190,1770624000"; d="scan'208";a="89124035" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2026 16:44:46 -0700 X-CSE-ConnectionGUID: wMbx63H6R8uA9OFezW78Kw== X-CSE-MsgGUID: 53a5XD53SZKhHlnjy6ZdSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,190,1770624000"; d="scan'208";a="231737429" Received: from fmsmsx903.amr.corp.intel.com ([10.18.126.92]) by orviesa009.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2026 16:44:46 -0700 Received: from FMSMSX902.amr.corp.intel.com (10.18.126.91) by fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 20 Apr 2026 16:44:45 -0700 Received: from fmsedg902.ED.cps.intel.com (10.1.192.144) by FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Mon, 20 Apr 2026 16:44:45 -0700 Received: from CH1PR05CU001.outbound.protection.outlook.com (52.101.193.53) by edgegateway.intel.com (192.55.55.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 20 Apr 2026 16:44:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gP67qtgKmRpDdnTTwQOZ6ecdZm75aF09AaIqGgkYBJ0yhqAJ6PneWZe8S5xyJiKRDhvgc9ZEjIS5ygDkw03BaJlAC1B/ZRk3FW2r75Wgx2owgeP+H6vkJm0fasYIR644OXzeNPGeDsVv16xIYSSP25BCeSPRdqPNP7Ev9E4fQq7INgm6u0EYKCFcqXsVVC7r/4VFtvmspTZB8IkJfm0yKx0Bh1S/Ouj3Q/drk9PY3aumGKtFaMtlLyErGjtLkGcqs1XsqR14L8Udz/pFwuVdy/xyK9x6NpbCMTdJeAP10NBBdkFl2yg6fT07N5bV4EMyRcZzM7nabDXlXx5Hl0Jj+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fn39R49cvvCQiee+nSTgKD5AhfYhQxX0XlPGn3GGFeY=; b=lOc05c2FJSfNwmolyVUEFK2A9aNhZTvsnMJTY2fEjc+WabUXFC2ZFIcVU7cDSiD1sctR8n+9u6OVKE39kwVJ+MIHjAuPSwPs6G4EOY1j/98eztTk2+bhCzlBBITcc3A2jtKAlGyy+5QICEB4SaxRjWjvybOTXp+aMJfEYQ9nKpiYE8wJhz1KsIztw5y+3tAz0HzoggPJHg9Dc1o4b51uSxyaU9wo8xZwe/mlxjjC3iJDQipNuKfwm4+x61RPz3lzQ4oQbIxRf4MclVNPBIRDLbuMpmmPrJto6DSLVyIE6kXextZfoO9ljKEXtO+h4cAFNoCPTdbL9uXEepcc/rMLdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS0PR11MB7579.namprd11.prod.outlook.com (2603:10b6:8:14d::5) by SA2PR11MB5081.namprd11.prod.outlook.com (2603:10b6:806:118::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.8; Mon, 20 Apr 2026 23:44:40 +0000 Received: from DS0PR11MB7579.namprd11.prod.outlook.com ([fe80::4199:4cb5:cf88:e79e]) by DS0PR11MB7579.namprd11.prod.outlook.com ([fe80::4199:4cb5:cf88:e79e%5]) with mapi id 15.20.9846.014; Mon, 20 Apr 2026 23:44:40 +0000 Message-ID: <0119d579-f847-4c1c-bf4d-a31b352420ea@intel.com> Date: Mon, 20 Apr 2026 16:44:37 -0700 User-Agent: Mozilla Thunderbird To: Li Li , Tony Nguyen , Przemek Kitszel , "David S. Miller" , Jakub Kicinski , Eric Dumazet , CC: , , David Decotigny , Anjali Singhai , "Sridhar Samudrala" , Brian Vazquez , References: <20260419192555.3631327-1-boolli@google.com> Content-Language: en-US From: Jacob Keller In-Reply-To: <20260419192555.3631327-1-boolli@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR04CA0337.namprd04.prod.outlook.com (2603:10b6:303:8a::12) To DS0PR11MB7579.namprd11.prod.outlook.com (2603:10b6:8:14d::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7579:EE_|SA2PR11MB5081:EE_ X-MS-Office365-Filtering-Correlation-Id: 65ed8fd1-a39a-438b-d06d-08de9f36ca09 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|366016|1800799024|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: cjLMZJrJ2BsSjTdWY/8WGJM4YI3CsEW02YHCZHPeWoE4rObEmYTqyJ4aVoVhGR34VeH5VHr95z1BzaJ+1vB9gGfHOlJ3yLA5x0EyqnRYtOSoUzrX4R6JQkGR8h/anHQ81cwz3Cm3wfulKtTNSZrclFGPS0RsBX9s7hAeGuEVtxzjOQJxcitLO89YmgAaNoj9VRzH5QElOUf0vLc7ZEckD1as8+A6jFKQA2uF8cLAq5lIHh7OSpZLrc+19A+0aSk5zkh4LWKV2YDpLNAVg/sgNzFkEBwY/bxBC2tAPV0i8E5eZ7/Fx7I32685e81xODCATQnmsq4CLSX11mFaxeY377PNVCDoID6s6BaWfZzONyv01ivlmF5Uhus/TnxpQxQ9w6DZPbU+SnKb3OZHxoj76mMmEWq7y0tPn4qNrRvQo3tvi6PT6kGmmxfog8WVSGIfHb2TxgieWlzaUuzRHgiWzwqfZKLLcJlXP4gpJBsf9RHWJ/A+i3c9xxGibFRYOSd0ELv8ReT9seZMFV/L5AiFco/r+LiHGQrW0mS0ZsQ6R6tqMY9zioszepgPw1ncKNeM4nfxNGwhCi9Y5IDTBx5WTTjgMHExtViJrkiDIkQfnmuiNfkPCjOmgeOOGCOisOSvZzWQT6txJ2fCu7pI55oMWD+HqM+eTrKG6rggzHjNFmuavBg6vRTRwAcdvckd2Sojk8BoiC3BRzBepEq24iSiCEHyiJzbE9qLL+kAA/5YKqM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7579.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(18002099003)(22082099003)(56012099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFVTSk1ZKzlGK01XOHVnWko1R2lIS015cG5ZL1JEWW40SFNPakRsRzZPNmcy?= =?utf-8?B?YW1wT29CS3UwY2s0UVROWGR5MnRKdml0S3pIWVlDZVZIU0xUTnJDZEVQYlB5?= =?utf-8?B?VFVVaFB2ZkRTblVtQ3JpOGdzeE5YLzdtZ210dnZjeGZKUXlBbmpFU1dCSUdC?= =?utf-8?B?bGs3d3hHMzdpZGxQRW8vNWYzSTVERG1ITXY2eE5tcWdJVUZNeThpOWY3TE9D?= =?utf-8?B?RUJrZ1pMbUdQc0YwM0dmcTlxbkVTYlZBVVhCazI2emNwTDVYZDBScHNYR3Ay?= =?utf-8?B?RmRIaUc3Kys1R0ZGVVl4NGw0WEhLRkRqS28ycnkycFQrc3d5UzlsM0w1Vjdv?= =?utf-8?B?emtTRTl2aWF0a1RrMzRHK1pISDRWUllQYUJjZVpud292Rmx1UXpCSWIzdThR?= =?utf-8?B?TCtaS0VsZkdlWXcxSzVuR1JNQW5heHlXcFA4d29IMzdDYVdvaFNIa3hzeUhV?= =?utf-8?B?Yy9jcE14Y3BUN3ByVjVtdGFZeVZxRm5tM3M3Tk9YWTF0TTlrczlWcXpjRXZh?= =?utf-8?B?WlErYVpXZ2lpdkRkK2V3V3NleTFvMXd1OUp3L3pHaERCUlowTWZpWCtkclU2?= =?utf-8?B?aUdJNXNzSi9FV25UTHcydU4vVUdBNzJmUi9rMUNHT1VhN09BV3FzTkdHTDBk?= =?utf-8?B?TWNSb0t0UmdWSVV6RHJEZGF0NEdQUEh6WjFWNDZYOWdMZG1ORjVCRnFEanhP?= =?utf-8?B?dnJyZ29HNkFWdk1FaWM0MG4yNldDRkt4bVBudnEvNFJuZzYzRngvcVppNmc3?= =?utf-8?B?NUNDU0p0TVY0ZXhWVVRvZ0hXd0xlbTNjRjJHZ0tWMXhyMTR2ck53WFgxZXZn?= =?utf-8?B?TldDUk13endXRmV1Z2NiNzBaaFlpYzJHOUQ4REpNWEd1VGNqbzJPUk1EZlpv?= =?utf-8?B?QUQ3b25Jc0VBWDRxWDJlS0ZldVVuaEZ3NDdnZ3ZDWmsrWlMwdk5mUmtsRllq?= =?utf-8?B?cDFKMDg4QWdUNys5U3dJeUxleUpLK1ljWjFSMUZaUDg3aHRQWERvNFM1NUJp?= =?utf-8?B?a2p6amwzMkwwM09rNGJtVWpZL05pb1pNMUc1ZVU5Q3hNSHovd1h2SE40SE9s?= =?utf-8?B?M2JYbDBNK3JLYlBzaHNJUEI0OWI0OVhJNTFDT3Q4clZEangvZGdISko0MGFF?= =?utf-8?B?a1YvK2JsUkxPNlh0ZklPeWRZV0VwRnd3M3Q2a2Erb3o3cXB6WmFlV1ZOVEZn?= =?utf-8?B?YnU0b2FoUlVDbzhJWllGUzJTb1E2NUU3ZUxoQ1JIVEd5VG9WRUIzUlRtMnhQ?= =?utf-8?B?QXJKd1lFWWZHcCtib2x5aDZEUm92eE9YUHJKdDMrZTRZdERreEo4UHZEclZm?= =?utf-8?B?MS82cWkra2R3WThEMEFBZzl2VVlGcHBkTTNaVmtsNE1TSGJWS3dpUWFWTmRO?= =?utf-8?B?UmJHbEtaWkdYdkd0UmIvNiswd2UrcWpRdGpHUVhBWmdadUZQOHY2K2ZSenVP?= =?utf-8?B?RElWQkNrZXdNckVtNUlLb3ZKc1NBZ2VydUZ6a0JlMng1RnVRUlFxeno0Qk9t?= =?utf-8?B?WGxWN1JSSzh4RC9PQndva2lURnF5Z084TG5sSzFpU3lJRmV6L2E0eVA1N0tn?= =?utf-8?B?ZjI3LzM1WTltRVRqcnBtN3FDMW1iYjV1dnZyak51a1g3djNiMHlKaVVEeHdl?= =?utf-8?B?Z3Y5Y3JxcExWU3UyVXBkM2ozdjE1TXR0UGRueHpPblNTTHpTL3hpNmdOMWkx?= =?utf-8?B?eHAzTjluYktoLzFCUWpzYmkxZllQWDFzUXoyN1B5Q3N2TUZMbDVkK3JWdG04?= =?utf-8?B?VFVEVnVOZnhZWDNpUVZUdVVkbEd5UzNtL2NycE1IcVpvMTJuNTBGWVhKR0dY?= =?utf-8?B?djh4VlIxemxKTmpFOCsvenpwOXEveDFpOFNSOHhwZERxZUNmeko3c3ZHSjQ4?= =?utf-8?B?RmVnY00zdUhhanpsUmpMU096Z211Q05xelBqc3NqbTI2UEwwcjRSSSsweVFT?= =?utf-8?B?NlhLQStTQW1iN2N3UXB5RGsrTmFCa043L04rMXRFalZ6bHVOamlqNFRPemtZ?= =?utf-8?B?K1hEaVEyL2VBUU91eVVPeEpYbVpJTkdWYjh3elFrT1RwTk9ZUjFSbU1yY25m?= =?utf-8?B?NDd1cVFDN1JHdFZPSmYwL0tQZlU3d0k3WG9xMm85V2tpSnBJOThzSzJzSE9S?= =?utf-8?B?RmJ1ditXMDJEbUNyY2RwU1ZrUDlhbER2NldIUUVLNTNNYWljY29KVGk0Mmty?= =?utf-8?B?MC9PV3I0RS9TWGNUUlBLSUgrckV6ZVBoVlNBbHB3WTZGMWFJNnlqMVVDQ003?= =?utf-8?B?a0hJM21NTlVpVVJyR1ZjZVR2UmgzN2JvNy8zTHMya2U3YUZaaFdQR28yTm50?= =?utf-8?B?ekdCUG5QVWtLSEdvcEFOZHZHRTRweGJjbjNwa0IvWjlBSmFxcXBFQT09?= X-Exchange-RoutingPolicyChecked: EbFZUQ+hWUZymx9DIePtDhTYyWEfzUDKGp2MMhs5NB6TFu+RI+BOisdA2hfA0x+Fm1+7/AyftD12RxJdKlE0YtkAqRXbroNxsf+dtSdvKrKCcniGaufj/Ar7q+fwBXcUBfufSrtBOh1lT7I2yvk8g+mDng2st0Rv2GNYfxTmEBQMfY8aqKgpxpvuMwzn05feq+/SplhvPEsfW82qeLAmwyXt8pKph/84wG/NdLJoXU1IxqleBMMbgmEAG9mGGOxG1F3f/QIHR4C7Y42Y4hFVuoUr+b0dl/3sVlE4Ef2wDIzhQg4wNiW9Uho5+PSnxbZ9GpCcLmjEeU0VHDdwV6rULw== X-MS-Exchange-CrossTenant-Network-Message-Id: 65ed8fd1-a39a-438b-d06d-08de9f36ca09 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7579.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2026 23:44:40.2155 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nIhYMNeuDQmYI1+CsM7ae9QT2w3kWDv5+HSYi9jSehIPaGH0tvDmedZ6PC5p4evGfooQOb/u4pGHvWnT6xnRyWKyo4SVG//u546b2qXsNTg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5081 X-OriginatorOrg: intel.com X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776728689; x=1808264689; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=7/86dq+TUwZp4aQDaoYD7s1ooWB+lkeTRj3PQrXX9co=; b=NQ3Vmb+ynsl7mpc0CnntfX1M4OxP5wr34DpyRvWIfm74Y5uZiUixNc+2 go1Zxen9jkg/l4XF3Qy6W8msizOTqw16Ml5f9raSGrWJO6vzDDs4s8Ru0 q3YzqgUi2tORVZGm09KfuSU0MSQttg+PyB5NpsOdAwQ7Yshijts5D4FWn l9YKbBt1aHY1YlVzn4JMLLsN2nq6KrHZkCWj8C2u7INPiTKPyI9iU2dLE 5xWr2qS59vMa38yJaq3FihCqTDQUvMGhrRzWZdaw93XEauto1x1jck0iW qIG6IdSOLkPu5sCafevxM+0wpKsq1uO3jE8b4nEz0zsbuNPHHBqE4OYVE Q==; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=intel.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=NQ3Vmb+y X-Mailman-Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Subject: Re: [Intel-wired-lan] [PATCH] idpf: do not perform flow ops when netdev is detached X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 4/19/2026 12:25 PM, Li Li wrote: > Even though commit 2e281e1155fc ("idpf: detach and close netdevs while > handling a reset") prevents ethtool -N/-n operations to operate on > detached netdevs, we found that out-of-tree workflows like OpenOnload > can bypass ethtool core locks and call idpf_set_rxnfc directly during > an idpf HW reset. When this happens, we could get kernel crashes like > the following: > > [ 4045.787439] BUG: kernel NULL pointer dereference, address: 0000000000000070 > [ 4045.794420] #PF: supervisor read access in kernel mode > [ 4045.799580] #PF: error_code(0x0000) - not-present page > [ 4045.804739] PGD 0 > [ 4045.806772] Oops: Oops: 0000 [#1] SMP NOPTI > ... > [ 4045.836425] Workqueue: onload-wqueue oof_do_deferred_work_fn [onload] > [ 4045.842926] RIP: 0010:idpf_del_flow_steer+0x24/0x170 [idpf] > ... > [ 4045.946323] Call Trace: > [ 4045.948796] > [ 4045.950915] ? show_trace_log_lvl+0x1b0/0x2f0 > [ 4045.955293] ? show_trace_log_lvl+0x1b0/0x2f0 > [ 4045.959672] ? idpf_set_rxnfc+0x6f/0x80 [idpf] > [ 4045.964142] ? __die_body.cold+0x8/0x12 > [ 4045.968000] ? page_fault_oops+0x148/0x160 > [ 4045.972117] ? exc_page_fault+0x6f/0x160 > [ 4045.976060] ? asm_exc_page_fault+0x22/0x30 > [ 4045.980262] ? idpf_del_flow_steer+0x24/0x170 [idpf] > [ 4045.985245] idpf_set_rxnfc+0x6f/0x80 [idpf] > [ 4045.989535] af_xdp_filter_remove+0x7c/0xb0 [sfc_resource] > [ 4045.995069] oo_hw_filter_clear_hwports+0x6f/0xa0 [onload] > [ 4046.000589] oo_hw_filter_update+0x65/0x210 [onload] > [ 4046.005587] oof_hw_filter_update.constprop.0+0xe7/0x140 [onload] > [ 4046.011716] oof_manager_update_all_filters+0xad/0x270 [onload] > [ 4046.017671] __oof_do_deferred_work+0x15e/0x190 [onload] > [ 4046.023014] oof_do_deferred_work+0x2c/0x40 [onload] > [ 4046.028018] oof_do_deferred_work_fn+0x12/0x30 [onload] > [ 4046.033277] process_one_work+0x174/0x330 > [ 4046.037304] worker_thread+0x246/0x390 > [ 4046.041074] ? __pfx_worker_thread+0x10/0x10 > [ 4046.045364] kthread+0xf6/0x240 > [ 4046.048530] ? __pfx_kthread+0x10/0x10 > [ 4046.052297] ret_from_fork+0x2d/0x50 > [ 4046.055896] ? __pfx_kthread+0x10/0x10 > [ 4046.059664] ret_from_fork_asm+0x1a/0x30 > [ 4046.063613] > > To prevent this, we need to add checks in idpf_set_rxnfc and > idpf_get_rxnfc to error out if the netdev is already detached. > > Tested: implemented the following patch to synthetically force idpf into > a HW reset: > > diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethernet/intel/idpf/idpf_txrx.c > index 4fc0bb14c5b1..27476d57bcf0 100644 > --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c > +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c > @@ -10,6 +10,9 @@ > #define idpf_tx_buf_next(buf) (*(u32 *)&(buf)->priv) > LIBETH_SQE_CHECK_PRIV(u32); > Patchwork, and likely other git tools based around plain text mail do not work kindly with an embedded diff inside the commit message. Could you please resubmit with an updated commit message that doesn't simply insert the raw diff? Perhaps you could indent the diff by a few spaces, or simply describe what modifications were required to force the failure. Also you didn't mention the target tree, which I think should be iwl-net. Thanks, Jake > +static bool SIMULATE_TX_TIMEOUT; > +module_param(SIMULATE_TX_TIMEOUT, bool, 0644); > + > /** > * idpf_chk_linearize - Check if skb exceeds max descriptors per packet > * @skb: send buffer > @@ -46,6 +49,8 @@ void idpf_tx_timeout(struct net_device *netdev, unsigned int txqueue) > > adapter->tx_timeout_count++; > > + SIMULATE_TX_TIMEOUT = false; > + > netdev_err(netdev, "Detected Tx timeout: Count %d, Queue %d\n", > adapter->tx_timeout_count, txqueue); > if (!idpf_is_reset_in_prog(adapter)) { > @@ -2225,6 +2230,8 @@ static bool idpf_tx_clean_complq(struct idpf_compl_queue *complq, int budget, > goto fetch_next_desc; > } > tx_q = complq->txq_grp->txqs[rel_tx_qid]; > + if (unlikely(SIMULATE_TX_TIMEOUT && (tx_q->idx % 2 == 1))) > + goto fetch_next_desc; > > /* Determine completion type */ > ctype = le16_get_bits(tx_desc->common.qid_comptype_gen, > diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c > index be66f9b2e101..ba5da2a86c15 100644 > --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c > +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c > @@ -8,6 +8,9 @@ > #include "idpf_virtchnl.h" > #include "idpf_ptp.h" > > +static bool VIRTCHNL_FAILED; > +module_param(VIRTCHNL_FAILED, bool, 0644); > + > /** > * struct idpf_vc_xn_manager - Manager for tracking transactions > * @ring: backing and lookup for transactions > @@ -3496,6 +3499,11 @@ int idpf_vc_core_init(struct idpf_adapter *adapter) > switch (adapter->state) { > case __IDPF_VER_CHECK: > err = idpf_send_ver_msg(adapter); > + > + if (unlikely(VIRTCHNL_FAILED)) { > + err = -EIO; > + } > + > switch (err) { > case 0: > /* success, move state machine forward */ > > And tested by writing 1 to /sys/module/idpf/parameters/VIRTCHNL_FAILED > and /sys/module/idpf/parameters/SIMULATE_TX_TIMEOUT, and running > idpf_get_rxnfc() right after the HW reset. > > Without the patch: encountered NULL pointer and kernel crash. > > With the patch: no crashes. > > Fixes: 2e281e1155fc ("idpf: detach and close netdevs while handling a reset") > Signed-off-by: Li Li > --- > drivers/net/ethernet/intel/idpf/idpf_ethtool.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c > index bb99d9e7c65d..8368a7e6a754 100644 > --- a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c > +++ b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c > @@ -43,6 +43,9 @@ static int idpf_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd, > unsigned int cnt = 0; > int err = 0; > > + if (!netdev || !netif_device_present(netdev)) > + return -ENODEV; > + > idpf_vport_ctrl_lock(netdev); > vport = idpf_netdev_to_vport(netdev); > vport_config = np->adapter->vport_config[np->vport_idx]; > @@ -349,6 +352,9 @@ static int idpf_set_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *cmd) > { > int ret = -EOPNOTSUPP; > > + if (!netdev || !netif_device_present(netdev)) > + return -ENODEV; > + > idpf_vport_ctrl_lock(netdev); > switch (cmd->cmd) { > case ETHTOOL_SRXCLSRLINS: