Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net] ixgbe: check return value of napi_complete_done()
Date: Thu, 20 Sep 2018 16:49:06 -0700	[thread overview]
Message-ID: <028b4cea-0e3f-fab5-7a74-cf003bbd1134@gmail.com> (raw)
In-Reply-To: <E4A7BD0D-B091-4FBD-94A9-F0104729DCF6@fb.com>



On 09/20/2018 04:43 PM, Song Liu wrote:
> 

> I tried to totally skip ndo_poll_controller() here. It did avoid hitting
> the issue. However, netpoll will drop (fail to send) more packets. 
>

Why is it failing ?

If you are under high memory pressure, then maybe if you absolutely want memory to send
netpoll packets, you want to grab all NAPI contexts as a way to prevent other cpus 
from feeding incoming packets to the host and add more memory pressure ;)


  reply	other threads:[~2018-09-20 23:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20 19:01 [Intel-wired-lan] [PATCH net] ixgbe: check return value of napi_complete_done() Song Liu
2018-09-20 20:35 ` Eric Dumazet
2018-09-20 21:01   ` Jeff Kirsher
2018-09-20 22:42     ` Song Liu
2018-09-20 23:22       ` Eric Dumazet
2018-09-20 23:43         ` Song Liu
2018-09-20 23:49           ` Eric Dumazet [this message]
2018-09-21  7:17             ` Song Liu
2018-09-21 13:33               ` Eric Dumazet
2018-09-21 14:55                 ` Alexei Starovoitov
2018-09-21 14:59                   ` Eric Dumazet
2018-09-21 15:14                     ` Alexei Starovoitov
2018-09-21 15:43                       ` Eric Dumazet
2018-09-27 16:12 ` Bowers, AndrewX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=028b4cea-0e3f-fab5-7a74-cf003bbd1134@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox