From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Mateusz Palczewski <mateusz.palczewski@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: Michal Jaron <michalx.jaron@intel.com>,
Slawomir Laba <slawomirx.laba@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net v1 2/2] i40e: Refactor i40e_set_rss_hash_opt
Date: Mon, 11 Jul 2022 16:25:36 -0700 [thread overview]
Message-ID: <038ce77b-153c-4122-021d-992f8e318be9@intel.com> (raw)
In-Reply-To: <20220704074405.1221585-1-mateusz.palczewski@intel.com>
On 7/4/2022 12:44 AM, Mateusz Palczewski wrote:
> From: Michal Jaron <michalx.jaron@intel.com>
>
> Refactor bitwise operations for rx-flow-hash for improved readability.
Refactor patches should not be sent to net.
> Fixes: eb0dd6e4a3b3 (i40e: Allow RSS Hash set with less than four parameters)
Why is there a Fixes? If it's a refactor, it shouldn't be
changing/fixing anything.
> Signed-off-by: Michal Jaron <michalx.jaron@intel.com>
> Signed-off-by: Slawomir Laba <slawomirx.laba@intel.com>
> Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
> ---
> .../net/ethernet/intel/i40e/i40e_ethtool.c | 75 +++++++++++--------
> 1 file changed, 42 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> index 114c68598e41..19d415d6462e 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> @@ -3528,9 +3528,12 @@ static int i40e_set_rss_hash_opt(struct i40e_pf *pf, struct ethtool_rxnfc *nfc)
> struct i40e_hw *hw = &pf->hw;
> u64 hena = (u64)i40e_read_rx_ctl(hw, I40E_PFQF_HENA(0)) |
> ((u64)i40e_read_rx_ctl(hw, I40E_PFQF_HENA(1)) << 32);
> - u8 flow_pctype = 0;
> +#define FLOW_PCTYPES_SIZE 64
defines should be outside of the function.
> + DECLARE_BITMAP(flow_pctypes, FLOW_PCTYPES_SIZE);
> u64 i_set, i_setc;
>
> + bitmap_zero(flow_pctypes, FLOW_PCTYPES_SIZE);
> +
> if (pf->flags & I40E_FLAG_MFP_ENABLED) {
> dev_err(&pf->pdev->dev,
> "Change of RSS hash input set is not supported when MFP mode is enabled\n");
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2022-07-11 23:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 7:44 [Intel-wired-lan] [PATCH net v1 2/2] i40e: Refactor i40e_set_rss_hash_opt Mateusz Palczewski
2022-07-11 23:25 ` Tony Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=038ce77b-153c-4122-021d-992f8e318be9@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=mateusz.palczewski@intel.com \
--cc=michalx.jaron@intel.com \
--cc=slawomirx.laba@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox