From: Bowers, AndrewX <andrewx.bowers@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH S37 10/15] ice: Remove possible null dereference
Date: Fri, 24 Jan 2020 23:17:09 +0000 [thread overview]
Message-ID: <04f5bfa20a4d46a382c1fc3c8bc722e8@intel.com> (raw)
In-Reply-To: <20200122152041.41498-10-anthony.l.nguyen@intel.com>
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Tony Nguyen
> Sent: Wednesday, January 22, 2020 7:21 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S37 10/15] ice: Remove possible null
> dereference
>
> Commit 1f45ebe0d8fb ("ice: add extra check for null Rx descriptor") moved
> the call to ice_construct_skb() under a null check as Coverity reported a
> possible use of null skb. However, the original call was not deleted, do so
> now.
>
> Fixes: 1f45ebe0d8fb ("ice: add extra check for null Rx descriptor")
> Reported-by: Bruce Allan <bruce.w.allan@intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_txrx.c | 2 --
> 1 file changed, 2 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
next prev parent reply other threads:[~2020-01-24 23:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 15:20 [Intel-wired-lan] [PATCH S37 01/15] ice: Fix DCB rebuild after reset Tony Nguyen
2020-01-22 15:20 ` [Intel-wired-lan] [PATCH S37 02/15] ice: Fix switch between FW and SW LLDP Tony Nguyen
2020-01-24 23:17 ` Bowers, AndrewX
2020-01-22 15:20 ` [Intel-wired-lan] [PATCH S37 03/15] ice: display supported and advertised link modes Tony Nguyen
2020-01-24 23:17 ` Bowers, AndrewX
2020-01-22 15:20 ` [Intel-wired-lan] [PATCH S37 04/15] ice: Don't allow same value for Rx tail to be written twice Tony Nguyen
2020-01-24 23:17 ` Bowers, AndrewX
2020-01-22 15:20 ` [Intel-wired-lan] [PATCH S37 05/15] ice: Remove ice_dev_onetime_setup() Tony Nguyen
2020-01-24 23:17 ` Bowers, AndrewX
2020-01-22 15:20 ` [Intel-wired-lan] [PATCH S37 06/15] ice: Remove CONFIG_PCI_IOV wrap in ice_set_pf_caps Tony Nguyen
2020-01-24 23:17 ` Bowers, AndrewX
2020-01-22 15:20 ` [Intel-wired-lan] [PATCH S37 07/15] ice: Modify link message logging Tony Nguyen
2020-01-24 23:17 ` Bowers, AndrewX
2020-01-22 15:20 ` [Intel-wired-lan] [PATCH S37 08/15] ice: fix and consolidate logging of NVM/firmware version information Tony Nguyen
2020-01-24 23:17 ` Bowers, AndrewX
2020-01-22 15:20 ` [Intel-wired-lan] [PATCH S37 09/15] ice: update Unit Load Status bitmask to check after reset Tony Nguyen
2020-01-24 23:17 ` Bowers, AndrewX
2020-01-22 15:20 ` [Intel-wired-lan] [PATCH S37 10/15] ice: Remove possible null dereference Tony Nguyen
2020-01-24 23:17 ` Bowers, AndrewX [this message]
2020-01-22 15:20 ` [Intel-wired-lan] [PATCH S37 11/15] ice: Use ice_pf_to_dev Tony Nguyen
2020-01-24 23:17 ` Bowers, AndrewX
2020-01-22 15:20 ` [Intel-wired-lan] [PATCH S37 12/15] ice: Make print statements more compact Tony Nguyen
2020-01-24 23:17 ` Bowers, AndrewX
2020-01-22 15:20 ` [Intel-wired-lan] [PATCH S37 13/15] ice: Cleanup ice_vsi_alloc_q_vectors Tony Nguyen
2020-01-24 23:17 ` Bowers, AndrewX
2020-01-22 15:20 ` [Intel-wired-lan] [PATCH S37 14/15] ice: Use correct netif error function Tony Nguyen
2020-01-24 23:17 ` Bowers, AndrewX
2020-01-22 15:20 ` [Intel-wired-lan] [PATCH S37 15/15] ice: Trivial fixes Tony Nguyen
2020-01-24 23:17 ` Bowers, AndrewX
2020-01-24 23:17 ` [Intel-wired-lan] [PATCH S37 01/15] ice: Fix DCB rebuild after reset Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04f5bfa20a4d46a382c1fc3c8bc722e8@intel.com \
--to=andrewx.bowers@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox