Re: [Intel-wired-lan] [PATCH 4/6 iwl-next] idpf: refactor remaining virtchnl messages

["Brady, Alan" <alan.brady@intel.com>]

On 1/24/2024 7:17 PM, Willem de Bruijn wrote:
> Alan Brady wrote:
>> This takes care of RSS/SRIOV/MAC and other misc virtchnl messages. This
>> again is mostly mechanical. There's some added functionality with MAC
>> filters which makes sure we remove bad filters now that we can better
>> handle asynchronous messages.
> Can you split the part that is pure refactor and the part that is new
> functionality?
>
> That will make reviewing both easier. The first should be a NOOP.


Sure thing. Added functionality is fairly well isolated to 
idpf_mac_filter_async_handler so should be straightforward to split it.

-Alan


>> There's still a bit more cleanup we can do here to remove stuff that's
>> not being used anymore now; follow-up patch will take care of loose
>> ends.
>>
>> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>> Reviewed-by: Igor Bagnucki <igor.bagnucki@intel.com>
>> Signed-off-by: Alan Brady <alan.brady@intel.com>
>> ---
>>   .../net/ethernet/intel/idpf/idpf_virtchnl.c   | 933 +++++++-----------
>>   1 file changed, 375 insertions(+), 558 deletions(-)