From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Jacob Keller <jacob.e.keller@intel.com>,
Intel Wired LAN <intel-wired-lan@lists.osuosl.org>
Cc: Anthony Nguyen <anthony.l.nguyen@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: move E810T functions to before device agnostic ones
Date: Wed, 12 Jul 2023 10:30:16 +0200 [thread overview]
Message-ID: <07aefe7a-67e4-e523-a2e0-c5e64db91db2@intel.com> (raw)
In-Reply-To: <20230711234734.312895-1-jacob.e.keller@intel.com>
On 7/12/23 01:47, Jacob Keller wrote:
> Commit 885fe6932a11 ("ice: Add support for SMA control multiplexer")
> accidentally placed all of the E810T SMA control functions in the middle of
> the device agnostic functions section of ice_ptp_hw.c
>
> This works fine, but makes it harder for readers to follow. The
> ice_ptp_hw.c file is layed out such that each hardware family has the
> specific functions in one block, with the access functions placed at the
> end of the file.
>
> Move the E810T functions so that they are in a block just after the E810
> functions. Also move the ice_get_phy_tx_tstamp_ready_e810 which got added
> at the end of the E810T block.
>
> This keeps the functions laid out in a logical order and avoids intermixing
> the generic access functions with the device specific implementations.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 396 ++++++++++----------
> 1 file changed, 198 insertions(+), 198 deletions(-)
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-07-12 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 23:47 [Intel-wired-lan] [PATCH iwl-next] ice: move E810T functions to before device agnostic ones Jacob Keller
2023-07-12 8:30 ` Przemek Kitszel [this message]
2023-07-19 13:46 ` Arland, ArpanaX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07aefe7a-67e4-e523-a2e0-c5e64db91db2@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox