Re: [Intel-wired-lan] [PATCH net-next] ice: Fix implicit cast u32 to u16

[Alexander Lobakin <aleksander.lobakin@intel.com>]

From: Kalyan Kodamagula <kalyan.kodamagula@intel.com>
Date: Tue, 28 Feb 2023 09:49:15 +0100

> From: Marcin Szycik <marcin.szycik@intel.com>
> 
> Fix implicit cast by changing argument types of two functions to correct
> types.
> 
> Signed-off-by: Marcin Szycik <marcin.szycik@intel.com>
> Signed-off-by: Kalyan Kodamagula <kalyan.kodamagula@intel.com>

Regarding the actual patch (below),

> ---
>  drivers/net/ethernet/intel/ice/ice_ddp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_ddp.c b/drivers/net/ethernet/intel/ice/ice_ddp.c
> index d71ed210f9c4..830fa53b5e0a 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ddp.c
> +++ b/drivers/net/ethernet/intel/ice/ice_ddp.c
> @@ -701,14 +701,14 @@ struct ice_buf_build *ice_pkg_buf_alloc(struct ice_hw *hw)
>  	return bld;
>  }
>  
> -static bool ice_is_gtp_u_profile(u16 prof_idx)
> +static bool ice_is_gtp_u_profile(u32 prof_idx)
>  {
>  	return (prof_idx >= ICE_PROFID_IPV6_GTPU_TEID &&
>  		prof_idx <= ICE_PROFID_IPV6_GTPU_IPV6_TCP_INNER) ||
>  	       prof_idx == ICE_PROFID_IPV4_GTPU_TEID;
>  }
>  
> -static bool ice_is_gtp_c_profile(u16 prof_idx)
> +static bool ice_is_gtp_c_profile(u32 prof_idx)
>  {
>  	switch (prof_idx) {
>  	case ICE_PROFID_IPV4_GTPC_TEID:

What is this change really about? It might've been a part of some bigger
series, isn't it? Does it fix any truncating-related bugs or improve
codegen, which could be observed by objdiff or bloat-o-meter? It feels
completely out of context.

Thanks,
Olek
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan