Re: [Intel-wired-lan] [PATCH v7 net-next 01/15] genetlink: extend info user-storage to match NL cb ctx

[Paul Menzel <pmenzel@molgen.mpg.de>]

Dear Paolo,


Thank you for your patch.

Am 10.09.24 um 00:09 schrieb Paolo Abeni:
> This allows a more uniform implementation of non-dump and dump
> operations, and will be used later in the series to avoid some
> per-operation allocation.
> 
> Additionally rename the NL_ASSERT_DUMP_CTX_FITS macro, to
> fit a more extended usage.

Should a resent be necessary, you could also mention the new name 
`NL_ASSERT_CTX_FITS` in the commit message. (Maybe even a separate 
commit, so the actual change is easier to review.)

> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Reviewed-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
>   drivers/net/vxlan/vxlan_mdb.c        | 2 +-
>   include/linux/netlink.h              | 5 +++--
>   include/net/genetlink.h              | 8 ++++++--
>   net/core/netdev-genl.c               | 2 +-
>   net/core/rtnetlink.c                 | 2 +-
>   net/devlink/devl_internal.h          | 2 +-
>   net/ethtool/rss.c                    | 2 +-
>   net/netfilter/nf_conntrack_netlink.c | 2 +-
>   net/netlink/genetlink.c              | 4 ++--
>   9 files changed, 17 insertions(+), 12 deletions(-)

[…]

With this:

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul