From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E016D1A62D for ; Fri, 9 Jan 2026 14:19:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 312A060EB6; Fri, 9 Jan 2026 14:19:47 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id BUnNw3KCLZ6C; Fri, 9 Jan 2026 14:19:45 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6F1A360EB2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1767968385; bh=Z/6WGCpxh3iEXP0zVTdiymBjWOoqngiNJ6AVVfx3sNs=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=PIyMo2CpgyLN0aQ2CmfAUb4mMMURXVhQOYiFIb5iWQB9aUearrQWq2b0doh16tXbU rWA4JaQwT1lXChqAJ+8Hu4PY5xr10QVKT0sfNmYgKUnSxUwTM6YXuUh3eNkvn6kSfv x7xU1/cKRySe0cvWWjGUCQcyp9ZfG+0xZ4KO/YjVRSPbkLa/gZs83ihnEsGMF8rG+O 9npOHaxMF5K78taPwUhSwrc03f0dvqQTM8kXka+Noki/351BTGVUC3Dxk4N70yvAKB clttBqcXFG8kXWbAUlXnr03CazAOE9bC5RYrWYromyHBM8ffCmEtrUpB+oHHEogHDC iPZDWiNSgO3cw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 6F1A360EB2; Fri, 9 Jan 2026 14:19:45 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists1.osuosl.org (Postfix) with ESMTP id 2ADBC12E for ; Fri, 9 Jan 2026 14:19:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 0F42D60EB2 for ; Fri, 9 Jan 2026 14:19:43 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id LUbJrHs5oPZe for ; Fri, 9 Jan 2026 14:19:42 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=ivecera@redhat.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 0266160EB4 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0266160EB4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 0266160EB4 for ; Fri, 9 Jan 2026 14:19:41 +0000 (UTC) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-JKSJUgiINYezc9O3GZUFpg-1; Fri, 09 Jan 2026 09:19:35 -0500 X-MC-Unique: JKSJUgiINYezc9O3GZUFpg-1 X-Mimecast-MFC-AGG-ID: JKSJUgiINYezc9O3GZUFpg_1767968371 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1A172195608F; Fri, 9 Jan 2026 14:19:31 +0000 (UTC) Received: from [10.44.33.222] (unknown [10.44.33.222]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 80D741954196; Fri, 9 Jan 2026 14:19:23 +0000 (UTC) Message-ID: <09ffc379-85e5-41ce-b781-66ba6bb9a6c7@redhat.com> Date: Fri, 9 Jan 2026 15:19:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Krzysztof Kozlowski References: <20260108182318.20935-1-ivecera@redhat.com> <20260108182318.20935-4-ivecera@redhat.com> <20260109-cooperative-chinchilla-of-swiftness-aebbc8@quoll> Content-Language: en-US From: Ivan Vecera In-Reply-To: <20260109-cooperative-chinchilla-of-swiftness-aebbc8@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767968380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z/6WGCpxh3iEXP0zVTdiymBjWOoqngiNJ6AVVfx3sNs=; b=KF/EVT8i6RTPe09/J8eVJjGeZJP3l444JSdCZdOlCPrviuf/oJoXNBsNoFhkEqvnzc9MtC 28fcz8z0RhC2fRJ+MX2+6QGBSSju74yY/gSxPbCck/MDuD0n8rghB1SOTVAtFrqdNOjMP6 ZrCpvOwWE9RasjULboCQKiFmAHvLGTM= X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KF/EVT8i Subject: Re: [Intel-wired-lan] [PATCH net-next 03/12] dpll: Add helpers to find DPLL pin fwnode X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Dumazet , Tony Nguyen , Rob Herring , Leon Romanovsky , Andrew Lunn , linux-rdma@vger.kernel.org, Przemek Kitszel , Arkadiusz Kubalewski , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Paolo Abeni , devicetree@vger.kernel.org, Conor Dooley , Jiri Pirko , Richard Cochran , Prathosh Satish , Vadim Fedorenko , netdev@vger.kernel.org, Mark Bloch , linux-kernel@vger.kernel.org, Tariq Toukan , Alexander Lobakin , Jonathan Lemon , Krzysztof Kozlowski , Saeed Mahameed , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 1/9/26 10:55 AM, Krzysztof Kozlowski wrote: > On Thu, Jan 08, 2026 at 07:23:09PM +0100, Ivan Vecera wrote: >> Add helper functions to the DPLL core to retrieve a DPLL pin's firmware >> node handle based on the "dpll-pins" and "dpll-pin-names" properties. >> >> * `fwnode_dpll_pin_node_get()`: matches the given name against the >> "dpll-pin-names" property to find the correct index, then retrieves >> the reference from "dpll-pins". >> * `device_dpll_pin_node_get()`: a wrapper around the fwnode helper for >> convenience when using a `struct device`. >> >> These helpers simplify the process for consumer drivers (such as Ethernet >> controllers or PHYs) to look up their associated DPLL pins defined in >> the DT or ACPI, which can then be passed to the DPLL subsystem to acquire >> the pin object. >> >> Signed-off-by: Ivan Vecera >> --- >> drivers/dpll/dpll_core.c | 20 ++++++++++++++++++++ >> include/linux/dpll.h | 15 +++++++++++++++ >> 2 files changed, 35 insertions(+) >> > > I don't see cells defined in your binding. Neither updated property.c. And if the cells are not required? I mean that dpll-names only specifies array of phandles without parameters... e.g. dpll-pin-names = "abc", "def"; dpll-pins = <&dpll_pin_abc>, <&dpll_pin_def>; Should '#dpll-pin-cells' be defined as constantly equal to 0? Thanks, Ivan > > Best regards, > Krzysztof >