Re: [Intel-wired-lan] [PATCH net-next v4 2/2] i40e: Only MACs from host must be preserved

[Tony Nguyen <anthony.l.nguyen@intel.com>]

On 1/30/2023 11:49 PM, Jan Sokolowski wrote:
> Only MACs assigned from host must be preserved after VF reset/reload.
> Added vm MAC list to filter vm MAC request from others then

Please use imperative mood

> vm MACs do not preserved by host during VF reset/reload.
> This list is used to filter the MAC addresses list restored after reset.
> Without this patch host automatically restore all the MAC addresses
> after VF reset/reload.

How is the code doing what's described here?

Also, patch #1 is allocating/adding to the list, but it's not being 
freed until this patch? There should be no leaking memory in-between 
patches; each one should be able to stand alone without any issues.

> Signed-off-by: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
> Co-developed-by: Kamil Maziarz <kamil.maziarz@intel.com>
> Signed-off-by: Kamil Maziarz <kamil.maziarz@intel.com>
> Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
> ---
> v4: Moved some functions to earlier patch to fix compilation errors
> ---
>   .../ethernet/intel/i40e/i40e_virtchnl_pf.c    | 22 +++++++++++++++++++
>   1 file changed, 22 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> index f6b5d61cc9a7..b9ebfd724f54 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> @@ -1085,6 +1085,25 @@ static void i40e_del_vmmac_from_list(struct i40e_vf *vf, const u8 *macaddr)
>   	}
>   }
>   
> +/**
> + * i40e_free_vmmac_list
> + * @vf: pointer to the VF info
> + *
> + * remove whole list of MAC addresses for VM
> + **/
> +static void i40e_free_vmmac_list(struct i40e_vf *vf)
> +{
> +	struct i40e_vm_mac *entry, *tmp;
> +
> +	if (list_empty(&vf->vm_mac_list))
> +		return;
> +
> +	list_for_each_entry_safe(entry, tmp, &vf->vm_mac_list, list) {
> +		list_del(&entry->list);
> +		kfree(entry);
> +	}
> +}
> +
>   /**
>    * i40e_free_vf_res
>    * @vf: pointer to the VF info
> @@ -1160,6 +1179,9 @@ static void i40e_free_vf_res(struct i40e_vf *vf)
>   		wr32(hw, reg_idx, reg);
>   		i40e_flush(hw);
>   	}
> +
> +	i40e_free_vmmac_list(vf);
> +
>   	/* reset some of the state variables keeping track of the resources */
>   	vf->num_queue_pairs = 0;
>   	clear_bit(I40E_VF_STATE_MC_PROMISC, &vf->vf_states);
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan