From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Mateusz Palczewski <mateusz.palczewski@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH net v1] i40e: Fix to stop tx_timeout recovery if GLOBR fails
Date: Thu, 14 Jul 2022 13:52:59 -0700 [thread overview]
Message-ID: <0d08e910-2a3e-ae6f-1566-79ac4bd8e1d2@intel.com> (raw)
In-Reply-To: <20220713134120.2745317-1-mateusz.palczewski@intel.com>
On 7/13/2022 6:41 AM, Mateusz Palczewski wrote:
> When a tx_timeout fires, the PF attempts to recover by incrementally
> resetting. First we try a PFR, then CORER and finally a GLOBR. If the
> GLOBR fails, then we keep hitting the tx_timeout and incrementing the
> recovery level and issuing dmesgs, which is both annoying to the user
> and accomplishes nothing.
>
> If the GLOBR fails, then we're pretty much totally hosed, and there's
> not much else we can do to recover, so this makes it such that we just
> kill the VSI and stop hitting the tx_timeout in such a case.
>
> Fixes: 41c445ff0f48 ("i40e: main driver core")
> Signed-off-by: Alan Brady <alan.brady@intel.com>
> Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
By ordering, I believe Alan is the author? Please either correct
ordering or the author.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2022-07-14 20:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 13:41 [Intel-wired-lan] [PATCH net v1] i40e: Fix to stop tx_timeout recovery if GLOBR fails Mateusz Palczewski
2022-07-14 20:52 ` Tony Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d08e910-2a3e-ae6f-1566-79ac4bd8e1d2@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=mateusz.palczewski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox