Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bowers, AndrewX <andrewx.bowers@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH S28 v2 7/9] ice: Minor refactor in queue management
Date: Wed, 4 Sep 2019 22:27:23 +0000	[thread overview]
Message-ID: <0d8f7deee7f24e429b6dcb900058c56b@intel.com> (raw)
In-Reply-To: <20190903083108.19593-7-anthony.l.nguyen@intel.com>

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Tony Nguyen
> Sent: Tuesday, September 3, 2019 1:31 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH S28 v2 7/9] ice: Minor refactor in queue
> management
> 
> From: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
> 
> Remove q_left_tx and q_left_rx from the PF struct as these can be obtained
> by calling ice_get_avail_txq_count and ice_get_avail_rxq_count respectively.
> 
> The function ice_determine_q_usage is only setting num_lan_tx and
> num_lan_rx in the PF structure, and these are later assigned to
> vsi->alloc_txq and vsi->alloc_rxq respectively. This is an unnecessary
> indirection, so remove ice_determine_q_usage and just assign values for vsi-
> >alloc_txq and vsi->alloc_rxq in ice_vsi_set_num_qs and use these to set
> num_lan_tx and num_lan_rx respectively.
> 
> Signed-off-by: Anirudh Venkataramanan
> <anirudh.venkataramanan@intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> ---
> v2:
> Move ice_get_avail_txq_count() and ice_get_avail_rxq_count() to
> ice_main.c to avoid static namespace issues
> ---
>  drivers/net/ethernet/intel/ice/ice.h          |  4 +-
>  drivers/net/ethernet/intel/ice/ice_lib.c      | 25 ++++++----
>  drivers/net/ethernet/intel/ice/ice_main.c     | 50 +++++++++++--------
>  .../net/ethernet/intel/ice/ice_virtchnl_pf.c  | 14 +++---
>  4 files changed, 54 insertions(+), 39 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>



  reply	other threads:[~2019-09-04 22:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-03  8:31 [Intel-wired-lan] [PATCH S28 v2 1/9] ice: Reliably reset VFs Tony Nguyen
2019-09-03  8:31 ` [Intel-wired-lan] [PATCH S28 v2 2/9] ice: report link down for VF when PF's queues are not enabled Tony Nguyen
2019-09-04 22:25   ` Bowers, AndrewX
2019-09-03  8:31 ` [Intel-wired-lan] [PATCH S28 v2 3/9] ice: Check for DCB capability before initializing DCB Tony Nguyen
2019-09-04 22:26   ` Bowers, AndrewX
2019-09-03  8:31 ` [Intel-wired-lan] [PATCH S28 v2 4/9] ice: Report VF link status with opcode to get resources Tony Nguyen
2019-09-04 22:26   ` Bowers, AndrewX
2019-09-03  8:31 ` [Intel-wired-lan] [PATCH S28 v2 5/9] ice: update Tx context struct Tony Nguyen
2019-09-04 22:26   ` Bowers, AndrewX
2019-09-03  8:31 ` [Intel-wired-lan] [PATCH S28 v2 6/9] ice: Allow for delayed LLDP MIB change registration Tony Nguyen
2019-09-04 22:27   ` Bowers, AndrewX
2019-09-03  8:31 ` [Intel-wired-lan] [PATCH S28 v2 7/9] ice: Minor refactor in queue management Tony Nguyen
2019-09-04 22:27   ` Bowers, AndrewX [this message]
2019-09-03  8:31 ` [Intel-wired-lan] [PATCH S28 v2 8/9] ice: change default number of receive descriptors Tony Nguyen
2019-09-04 22:27   ` Bowers, AndrewX
2019-09-03  8:31 ` [Intel-wired-lan] [PATCH S28 v2 9/9] ice: Rework around device/function capabilities Tony Nguyen
2019-09-04 22:28   ` Bowers, AndrewX
2019-09-04 22:25 ` [Intel-wired-lan] [PATCH S28 v2 1/9] ice: Reliably reset VFs Bowers, AndrewX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d8f7deee7f24e429b6dcb900058c56b@intel.com \
    --to=andrewx.bowers@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox