Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next] ice: Enable configuration of number of qps per VF via devlink
Date: Fri, 23 Apr 2021 20:24:11 +0000	[thread overview]
Message-ID: <0f3220d28f6289bfef2e90aa8285f1c678695a54.camel@intel.com> (raw)
In-Reply-To: <20210423044603.1391-1-sridhar.samudrala@intel.com>

On Thu, 2021-04-22 at 21:46 -0700, Sridhar Samudrala wrote:

<snip>

> +/**
> + * ice_devlink_num_qps_per_vf_validate - Validate the number of qps
> per vf
> + * @devlink: pointer to the devlink instance
> + * @id: the parameter ID to validate
> + * @ctx: context to return the parameter value
> + * @extack: netlink extended ACK structure
> + *
> + * Check that the value passed is less than the max qps allowed for
> a VF and
> + * no VFs are created yet.
> + * Returns: zero on success, or an error code on failure and extack
> with a
> + * reason for failure.
> + */
> +static int
> +ice_devlink_num_qps_per_vf_validate(struct devlink *devlink, u32 id,
> +				    union devlink_param_value val,
> +				    struct netlink_ext_ack *extack)

I believe you changed a parameter, but forgot to update the kdoc:

drivers/net/ethernet/intel/ice/ice_devlink.c:526: warning: Function
parameter or member 'val' not described in
'ice_devlink_num_qps_per_vf_validate'
drivers/net/ethernet/intel/ice/ice_devlink.c:526: warning: Excess
function parameter 'ctx' description in
'ice_devlink_num_qps_per_vf_validate'


      reply	other threads:[~2021-04-23 20:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23  4:46 [Intel-wired-lan] [PATCH net-next] ice: Enable configuration of number of qps per VF via devlink Sridhar Samudrala
2021-04-23 20:24 ` Nguyen, Anthony L [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f3220d28f6289bfef2e90aa8285f1c678695a54.camel@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox