Re: [Intel-wired-lan] [PATCH iwl-next v2 2/2] ixgbe: Refactor returning internal error codes

[Tony Nguyen <anthony.l.nguyen@intel.com>]

On 12/5/2023 3:28 AM, Jedrzej Jagielski wrote:
> Change returning codes to the kernel ones instead of
> the internal ones for the entire ixgbe driver.
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
> ---

...

> @@ -3897,14 +3886,14 @@ static s32 ixgbe_get_ets_data(struct ixgbe_hw *hw, u16 *ets_cfg,
>   		return status;
>   
>   	if ((*ets_offset == 0x0000) || (*ets_offset == 0xFFFF))
> -		return IXGBE_NOT_IMPLEMENTED;
> +		return -ENOSYS;

Based on checkpatch, this doesn't look like a value we can use.

WARNING: ENOSYS means 'invalid syscall nr' and nothing else

>   	status = hw->eeprom.ops.read(hw, *ets_offset, ets_cfg);
>   	if (status)
>   		return status;
>   
>   	if ((*ets_cfg & IXGBE_ETS_TYPE_MASK) != IXGBE_ETS_TYPE_EMC_SHIFTED)
> -		return IXGBE_NOT_IMPLEMENTED;
> +		return -ENOSYS;
>   
>   	return 0;
>   }
> @@ -3927,7 +3916,7 @@ s32 ixgbe_get_thermal_sensor_data_generic(struct ixgbe_hw *hw)
>   
>   	/* Only support thermal sensors attached to physical port 0 */
>   	if ((IXGBE_READ_REG(hw, IXGBE_STATUS) & IXGBE_STATUS_LAN_ID_1))
> -		return IXGBE_NOT_IMPLEMENTED;
> +		return -ENOSYS;
>   
>   	status = ixgbe_get_ets_data(hw, &ets_cfg, &ets_offset);
>   	if (status)
> @@ -3987,7 +3976,7 @@ s32 ixgbe_init_thermal_sensor_thresh_generic(struct ixgbe_hw *hw)
>   
>   	/* Only support thermal sensors attached to physical port 0 */
>   	if ((IXGBE_READ_REG(hw, IXGBE_STATUS) & IXGBE_STATUS_LAN_ID_1))
> -		return IXGBE_NOT_IMPLEMENTED;
> +		return -ENOSYS;
>   
>   	status = ixgbe_get_ets_data(hw, &ets_cfg, &ets_offset);
>   	if (status)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan