Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Catherine Sullivan <catherine.sullivan@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S15 09/15] i40e: remove FD atr control from debugfs
Date: Thu,  3 Sep 2015 17:18:56 -0400	[thread overview]
Message-ID: <1441315142-173025-10-git-send-email-catherine.sullivan@intel.com> (raw)
In-Reply-To: <1441315142-173025-1-git-send-email-catherine.sullivan@intel.com>

From: Shannon Nelson <shannon.nelson@intel.com>

Since the flow-director-atr priv flag was added to our ethtool interface,
we don't need the on/off control in debugfs.

Signed-off-by: Shannon Nelson <shannon.nelson@intel.com>
Change-ID: Ib3b599916434ab30ccd40074e71d7a81609b5bb5
---
 drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
index e19d479..2f0e2f5 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
@@ -953,24 +953,6 @@ static void i40e_dbg_dump_veb_all(struct i40e_pf *pf)
 	}
 }
 
-/**
- * i40e_dbg_cmd_fd_ctrl - Enable/disable FD sideband/ATR
- * @pf: the PF that would be altered
- * @flag: flag that needs enabling or disabling
- * @enable: Enable/disable FD SD/ATR
- **/
-static void i40e_dbg_cmd_fd_ctrl(struct i40e_pf *pf, u64 flag, bool enable)
-{
-	if (enable) {
-		pf->flags |= flag;
-	} else {
-		pf->flags &= ~flag;
-		pf->auto_disable_flags |= flag;
-	}
-	dev_info(&pf->pdev->dev, "requesting a PF reset\n");
-	i40e_do_reset_safe(pf, BIT(__I40E_PF_RESET_REQUESTED));
-}
-
 #define I40E_MAX_DEBUG_OUT_BUFFER (4096*4)
 /**
  * i40e_dbg_command_write - write into command datum
@@ -1759,10 +1741,6 @@ static ssize_t i40e_dbg_command_write(struct file *filp,
 		raw_packet = NULL;
 		kfree(asc_packet);
 		asc_packet = NULL;
-	} else if (strncmp(cmd_buf, "fd-atr off", 10) == 0) {
-		i40e_dbg_cmd_fd_ctrl(pf, I40E_FLAG_FD_ATR_ENABLED, false);
-	} else if (strncmp(cmd_buf, "fd-atr on", 9) == 0) {
-		i40e_dbg_cmd_fd_ctrl(pf, I40E_FLAG_FD_ATR_ENABLED, true);
 	} else if (strncmp(cmd_buf, "fd current cnt", 14) == 0) {
 		dev_info(&pf->pdev->dev, "FD current total filter count for this interface: %d\n",
 			 i40e_get_current_fd_count(pf));
@@ -1989,8 +1967,6 @@ static ssize_t i40e_dbg_command_write(struct file *filp,
 		dev_info(&pf->pdev->dev, "  send indirect aq_cmd <flags> <opcode> <datalen> <retval> <cookie_h> <cookie_l> <param0> <param1> <param2> <param3> <buffer_len>\n");
 		dev_info(&pf->pdev->dev, "  add fd_filter <dest q_index> <flex_off> <pctype> <dest_vsi> <dest_ctl> <fd_status> <cnt_index> <fd_id> <packet_len> <packet>\n");
 		dev_info(&pf->pdev->dev, "  rem fd_filter <dest q_index> <flex_off> <pctype> <dest_vsi> <dest_ctl> <fd_status> <cnt_index> <fd_id> <packet_len> <packet>\n");
-		dev_info(&pf->pdev->dev, "  fd-atr off\n");
-		dev_info(&pf->pdev->dev, "  fd-atr on\n");
 		dev_info(&pf->pdev->dev, "  fd current cnt");
 		dev_info(&pf->pdev->dev, "  lldp start\n");
 		dev_info(&pf->pdev->dev, "  lldp stop\n");
-- 
1.9.3


  parent reply	other threads:[~2015-09-03 21:18 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-03 21:18 [Intel-wired-lan] [next PATCH S15 00/15] i40e/i40evf updates Catherine Sullivan
2015-09-03 21:18 ` [Intel-wired-lan] [next PATCH S15 01/15] i40e: Add missing parameter comment to ndo_bridge_setlink Catherine Sullivan
2015-09-10 22:17   ` Bowers, AndrewX
2015-09-03 21:18 ` [Intel-wired-lan] [next PATCH S15 02/15] i40e: use priv flags to control flow director Catherine Sullivan
2015-09-10 22:26   ` Bowers, AndrewX
2015-09-03 21:18 ` [Intel-wired-lan] [next PATCH S15 03/15] i40e: Change some messages from info to debug only Catherine Sullivan
2015-09-10 22:38   ` Bowers, AndrewX
2015-09-03 21:18 ` [Intel-wired-lan] [next PATCH S15 04/15] i40e: Lock for VSI's MAC filter list Catherine Sullivan
2015-09-11 15:59   ` Bowers, AndrewX
2015-09-29 19:08   ` Jesse Brandeburg
2015-09-30 16:18     ` Sullivan, Catherine
2015-09-03 21:18 ` [Intel-wired-lan] [next PATCH S15 05/15] i40e: Remove 100M SGMII unless hw is X722 Catherine Sullivan
2015-09-11 16:03   ` Bowers, AndrewX
2015-09-03 21:18 ` [Intel-wired-lan] [next PATCH S15 06/15] i40e/i40evf: Add WB_ON_ITR offload support Catherine Sullivan
2015-09-11 16:08   ` Bowers, AndrewX
2015-09-03 21:18 ` [Intel-wired-lan] [next PATCH S15 07/15] i40e: remove obsolete version check Catherine Sullivan
2015-09-11 16:09   ` Bowers, AndrewX
2015-09-03 21:18 ` [Intel-wired-lan] [next PATCH S15 08/15] i40e: allow FD SB if MFP mode only has 1 partition Catherine Sullivan
2015-09-11 16:11   ` Bowers, AndrewX
2015-09-03 21:18 ` Catherine Sullivan [this message]
2015-09-11 16:14   ` [Intel-wired-lan] [next PATCH S15 09/15] i40e: remove FD atr control from debugfs Bowers, AndrewX
2015-09-03 21:18 ` [Intel-wired-lan] [next PATCH S15 10/15] i40e/i40evf: remove redundant declarations of a variable and a function Catherine Sullivan
2015-09-11 16:16   ` Bowers, AndrewX
2015-09-03 21:18 ` [Intel-wired-lan] [next PATCH S15 11/15] i40e: Store off PHY capabilities Catherine Sullivan
2015-09-11 16:20   ` Bowers, AndrewX
2015-09-03 21:18 ` [Intel-wired-lan] [next PATCH S15 12/15] i40e: X722 is on the IOSF bus and does not report the PCI bus info Catherine Sullivan
2015-09-22 21:17   ` Bowers, AndrewX
2015-09-03 21:19 ` [Intel-wired-lan] [next PATCH S15 13/15] i40e: remove unnecessary string copy operations Catherine Sullivan
2015-09-22 21:20   ` Bowers, AndrewX
2015-09-03 21:19 ` [Intel-wired-lan] [next PATCH S15 14/15] i40evf: speed up init Catherine Sullivan
2015-09-22 21:23   ` Bowers, AndrewX
2015-09-03 21:19 ` [Intel-wired-lan] [next PATCH S15 15/15] i40e/i40evf: Bump i40e version to 1.3.28 and i40evf to 1.3.19 Catherine Sullivan
2015-09-22 21:24   ` Bowers, AndrewX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441315142-173025-10-git-send-email-catherine.sullivan@intel.com \
    --to=catherine.sullivan@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox