From: Joe Perches <joe@perches.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] i40e: Fix i40e_print_features() VEB mode output
Date: Wed, 02 Dec 2015 02:12:29 -0800 [thread overview]
Message-ID: <1449051149.3716.20.camel@perches.com> (raw)
In-Reply-To: <1449050215.3224.29.camel@intel.com>
On Wed, 2015-12-02 at 01:56 -0800, Jeff Kirsher wrote:
> On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote:
> > Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string
> > building")
> > added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in
> > function i40e_print_features.
> >
> > Fix it.
> >
> > Miscellanea:
> >
> > o Remove unnecessary string variable
> > o Add space before not after fixed strings
> > o Use kmalloc not kzalloc
> > o Don't initialize i to 0, use result of first snprintf
> >
> > Noticed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Don't you mean Reported-by? ?I am not aware of Noticed-by as being a
> recognized signature.
At least for the get_maintainer script, "<anything>-by:" is a signature
next prev parent reply other threads:[~2015-12-02 10:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1448475679-57194-1-git-send-email-jeffrey.t.kirsher@intel.com>
[not found] ` <1448475679-57194-5-git-send-email-jeffrey.t.kirsher@intel.com>
[not found] ` <5655FD72.70902@cogentembedded.com>
[not found] ` <1448476535.3021.5.camel@intel.com>
[not found] ` <1448480194.20113.48.camel@perches.com>
[not found] ` <1449002936.1593.10.camel@perches.com>
[not found] ` <1449041100.3224.17.camel@intel.com>
2015-12-02 8:38 ` [Intel-wired-lan] [PATCH] i40e: Fix i40e_print_features() VEB mode output Joe Perches
2015-12-02 9:56 ` Jeff Kirsher
2015-12-02 10:12 ` Joe Perches [this message]
2015-12-02 20:48 ` David Miller
2015-12-02 21:09 ` Joe Perches
2015-12-03 12:13 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449051149.3716.20.camel@perches.com \
--to=joe@perches.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox