From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2 13/13] e1000e: fix misuse of ret_val variable and error handling
Date: Wed, 13 Apr 2016 23:41:20 -0700 [thread overview]
Message-ID: <1460616080.2960.53.camel@intel.com> (raw)
In-Reply-To: <1460588914-20143-14-git-send-email-jacob.e.keller@intel.com>
On Wed, 2016-04-13 at 16:08 -0700, Jacob Keller wrote:
> A patch introduced the use of ret_val variable but only assigned it
> once
> and didn't use it. e1000_probe already has a rval variable, which is
> what was checked, so remove use of ret_val in favor of rval.
>
> Fixes: 7739e79c2ff7 ("e1000e: Fix ptp time reset on network
> interruption", 2016-04-12)
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
> ?drivers/net/ethernet/intel/e1000e/netdev.c | 3 +--
> ?1 file changed, 1 insertion(+), 2 deletions(-)
Dropped, because it does not apply.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160413/b77723b4/attachment-0001.asc>
next prev parent reply other threads:[~2016-04-14 6:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 23:08 [Intel-wired-lan] [PATCH v1 00/13] Fix several GCC6 warnings Jacob Keller
2016-04-13 23:08 ` [Intel-wired-lan] [PATCH v2 01/13] ixgbe: use BIT() macro Jacob Keller
2016-04-20 17:22 ` Bowers, AndrewX
2016-04-13 23:08 ` [Intel-wired-lan] [PATCH v2 02/13] ixgbe: resolve shift of negative value warning Jacob Keller
2016-04-20 17:24 ` Bowers, AndrewX
2016-04-13 23:08 ` [Intel-wired-lan] [PATCH v2 03/13] ixgbevf: make use of BIT() macro to avoid shift of signed values Jacob Keller
2016-04-14 4:22 ` Jeff Kirsher
2016-04-14 14:58 ` Keller, Jacob E
2016-04-20 17:32 ` Bowers, AndrewX
2016-04-13 23:08 ` [Intel-wired-lan] [PATCH v2 04/13] i40e/i40evf: fix I40E_MASK signed shift overflow warnings Jacob Keller
2016-04-20 20:00 ` Bowers, AndrewX
2016-04-13 23:08 ` [Intel-wired-lan] [PATCH v2 05/13] i40e: make use of BIT() macro to prevent left shift of signed values Jacob Keller
2016-04-20 20:06 ` Bowers, AndrewX
2016-04-13 23:08 ` [Intel-wired-lan] [PATCH v2 06/13] i40evf: make use of BIT() macro to avoid signed left shift Jacob Keller
2016-04-20 20:07 ` Bowers, AndrewX
2016-04-13 23:08 ` [Intel-wired-lan] [PATCH v2 07/13] igb: use BIT() macro or unsigned prefix Jacob Keller
2016-04-13 23:08 ` [Intel-wired-lan] [PATCH v2 08/13] igb: make igb_update_pf_vlvf static Jacob Keller
2016-04-13 23:08 ` [Intel-wired-lan] [PATCH v2 09/13] igbvf: remove unused variable and dead code Jacob Keller
2016-04-13 23:08 ` [Intel-wired-lan] [PATCH v2 10/13] igbvf: use BIT() macro instead of shifts Jacob Keller
2016-04-13 23:08 ` [Intel-wired-lan] [PATCH v2 11/13] e1000e: use BIT() macro for bit defines Jacob Keller
2016-04-13 23:08 ` [Intel-wired-lan] [PATCH v2 12/13] e1000e: mark shifted values as unsigned Jacob Keller
2016-04-13 23:08 ` [Intel-wired-lan] [PATCH v2 13/13] e1000e: fix misuse of ret_val variable and error handling Jacob Keller
2016-04-14 6:41 ` Jeff Kirsher [this message]
2016-04-14 17:19 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460616080.2960.53.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox