Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] ixgbevf: Remove unused parameter
Date: Wed, 27 Apr 2016 14:19:58 -0700	[thread overview]
Message-ID: <1461791998.2851.19.camel@intel.com> (raw)
In-Reply-To: <1461791950.2851.18.camel@intel.com>

On Wed, 2016-04-27 at 14:19 -0700, Jeff Kirsher wrote:
> On Tue, 2016-04-26 at 23:29 +0000, Nguyen, Anthony L wrote:
> > ixgbevf_update_xcast_mode() is not using the netdev parameter;
> > removing it since it's unnecessary.
> >?
> > Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> > ---
> > ?drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +-
> > ?drivers/net/ethernet/intel/ixgbevf/vf.c?????????? | 4 +---
> > ?drivers/net/ethernet/intel/ixgbevf/vf.h?????????? | 2 +-
> > ?3 files changed, 3 insertions(+), 5 deletions(-)
> 
> 2 issues with this patch, first it was corrupted by whatever means
> you
> used to send this patch. ?Second this patch fails to compile (after I
> had to apply it by hand) because it was not generated against my
> lastest dev-queue branch.
> 
> There are only three things I ask when generating kernel patches:
> 1- always use my dev-queue branch to generate kernel patches against
> our Intel wired LAN drivers
> 2- run checkpatch.pl against your patch and fix the reported errors
> and
> possibly warnings
> 3- Compile test your patch before sending it off to intel-wired-lan at l
> is
> ts.osuosl.org?mailing list

Oh forgot to mention, dropping this patch for the v2 I created for Tony
:-(
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160427/26b19dc7/attachment.asc>

      reply	other threads:[~2016-04-27 21:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26 23:29 [Intel-wired-lan] [PATCH] ixgbevf: Remove unused parameter Nguyen, Anthony L
2016-04-27 21:19 ` Jeff Kirsher
2016-04-27 21:19   ` Jeff Kirsher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461791998.2851.19.camel@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox