Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Keller, Jacob E <jacob.e.keller@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] fm10k: don't continue probe if PCI device not in normal IO state
Date: Thu, 23 Jun 2016 20:12:43 +0000	[thread overview]
Message-ID: <1466712762.20929.1.camel@intel.com> (raw)
In-Reply-To: <1466659490.2692.6.camel@intel.com>

On Wed, 2016-06-22 at 22:24 -0700, Jeff Kirsher wrote:
> On Tue, 2016-06-14 at 16:26 -0700, Jacob Keller wrote:
> > In the event of an uncorrectable AER error occuring when the driver
> > has
> > not loaded, the recovery routines are not done. This is done
> > because
> > future loads of the driver may not be aware of the IO state and may
> > not
> > be able to recover at all. In this case, when we next load the
> > driver it
> > fails due to what appears to be a surprise remove event. Instead,
> > add
> > a check to ensure that the device is in the normal IO state before
> > continuing to probe. This allows us to give a more descriptive
> > message
> > of what is wrong.
> > 
> > Without this change, the driver will attempt to probe up to our
> > first
> > call of .reset_hw() which will be unable to read registers and act
> > as if
> > a surprise remove event occurred.
> > 
> > Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> > ---
> > ?drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 6 ++++++
> > ?1 file changed, 6 insertions(+)
> 
> This does not apply at all, the code was already removed in a
> previous
> patch. ?So I am dropping this patch.

I'll take a look and re-submit a version on top of queue if we still
need something.

Thanks,
Jake

      reply	other threads:[~2016-06-23 20:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14 23:26 [Intel-wired-lan] [PATCH] fm10k: don't continue probe if PCI device not in normal IO state Jacob Keller
2016-06-23  5:24 ` Jeff Kirsher
2016-06-23 20:12   ` Keller, Jacob E [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466712762.20929.1.camel@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox