Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2] checkpatch.pl: seed camelcase from the provided kernel tree root
Date: Wed, 31 Aug 2016 19:46:02 -0700	[thread overview]
Message-ID: <1472697962.4176.77.camel@perches.com> (raw)
In-Reply-To: <1472697190.2453.14.camel@intel.com>

On Wed, 2016-08-31 at 19:33 -0700, Jeff Kirsher wrote:
> On Thu, 2016-09-01 at 01:04 +0000, Brown, Aaron F wrote:
> > From: Keller, Jacob E

Hi all.

> > > > ---------------------------------------------------------------------
> > > > The first is clearly a false warning, thinks checkpatch is the tool
> > > > that found the error rather than the tool being fixed.? ;)?? The second is just
> > > > a long line in the perl code, which I don't really consider a blocking issue so...
> > > Ya I saw those. I saw many lines over 80 characters in the file so I
> > > just assumed we don't bother checking the tool with itself.
> > Well, it showed up in as a patch so I ran it through...? But yeah, it
> > does not make sense to enforce rules intended for the kernel against
> > something else.? Especially as the precedent for line length is clearly
> > already in the file
> Although it technically is a part of the kernel source since it is in
> scripts. ?So the question is, should kernel scripts follow the coding
> standards? ?If so, then yes it should follow its own rules for kernel
> source.
> 
> Personally I do not think it should be an issue for the contents of
> /scripts in the kernel source, but that would be an interesting question to
> pose to Joe Perches and the other checkpatch.pl warlords.

Warlord? ?Damn. ?Where are my spoils of war?

Perl is already basically unintelligible.
80 column perl would be a whole lot worse.

Anyway, I don't look at scripts with checkpatch.

I think it's really only useful for .[ch] files.


  reply	other threads:[~2016-09-01  2:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-29 21:00 [Intel-wired-lan] [PATCH v2] checkpatch.pl: seed camelcase from the provided kernel tree root Jacob Keller
2016-08-31 20:27 ` Brown, Aaron F
2016-08-31 22:37   ` Keller, Jacob E
2016-09-01  1:04     ` Brown, Aaron F
2016-09-01  2:33       ` Jeff Kirsher
2016-09-01  2:46         ` Joe Perches [this message]
2016-09-01  3:17           ` Jeff Kirsher
2016-09-01  3:26             ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472697962.4176.77.camel@perches.com \
    --to=joe@perches.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox