Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] ixgbe: prevent driver configuration changes while XDP is loaded
Date: Tue, 06 Jun 2017 13:43:36 -0700	[thread overview]
Message-ID: <1496781816.86439.2.camel@intel.com> (raw)
In-Reply-To: <59370DDD.5050008@gmail.com>

On Tue, 2017-06-06 at 13:17 -0700, John Fastabend wrote:
> On 06/06/2017 01:14 PM, Jeff Kirsher wrote:
> > On Mon, 2017-05-01 at 22:06 -0700, John Fastabend wrote:
> > > XDP checks to ensure the MTU is valid and LRO is disabled when it
> > > is
> > > loaded. But user configuration after XDP is loaded could change
> > > these
> > > and cause a misconfiguration.
> > > 
> > > This patch adds checks to ensure config changes are valid.
> > > 
> > > Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
> > > ---
> > >   drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |   17
> > > +++++++++++++++++
> > >   1 file changed, 17 insertions(+)
> > 
> > I know you have moved onto a new job, which is probably taking up
> > most
> > of your time.  I just need to know if you will be re-spinning this
> > patch based on the feedback from Alex.
> > 
> 
> I planned to get the xdp_redirect patches updated and sent out
> in the next few weeks. When I get around to that I'll also push
> an update to this assuming no one beats me to it.

Ok thanks for the update, I will drop the current patch and will await
an updated version.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20170606/1d7b3c21/attachment.asc>

      reply	other threads:[~2017-06-06 20:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-02  5:06 [Intel-wired-lan] [PATCH] ixgbe: prevent driver configuration changes while XDP is loaded John Fastabend
2017-05-19 22:16 ` Singh, Krishneil K
2017-05-21 23:02 ` Alexander Duyck
2017-06-06 16:39 ` Bowers, AndrewX
2017-06-06 20:14 ` Jeff Kirsher
2017-06-06 20:17   ` John Fastabend
2017-06-06 20:43     ` Jeff Kirsher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496781816.86439.2.camel@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox