From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Abeni Date: Thu, 15 Mar 2018 18:20:31 +0100 Subject: [Intel-wired-lan] [RFC PATCH 0/2] net:setup XPS mapping for each online CPU In-Reply-To: References: <1521129082.2681.13.camel@redhat.com> Message-ID: <1521134431.2681.26.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: Hi, On Thu, 2018-03-15 at 15:59 +0000, Eric Dumazet wrote: > On Thu, Mar 15, 2018 at 8:51 AM Paolo Abeni wrote: > > I'm sorry, I do not follow. AFAICS with unconnected sockets without XPS > > we always hit the netdev_pick_tx()/skb_tx_hash()/skb_flow_dissect() > > overhead in xmit path. > > Then fix this if you want, instead of fixing one NIC only, or by enforcing > XPS by all NIC. > > For unconnected sockets, picking the TX queue based on current cpu is good, > we do not have to enforce ordering as much as possible. > > (pfifo_fast no longer can enforce it anyway) Thank you for the prompt reply. I'm double checking to avoid misinterpretation on my side: are you suggesting to plug a CPU-based selection logic for unconnected sockets in netdev_pick_tx() or to cook patches like 2/2 for all the relevant NICs? Thanks! Paolo