From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EC9CC00140 for ; Wed, 10 Aug 2022 14:22:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 93D9B417B0; Wed, 10 Aug 2022 14:22:07 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 93D9B417B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1660141327; bh=Mc2FoNjQUZCv9DJF/15qcbxn6ea2aWQbupxAVkhQKz4=; h=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:Cc:From; b=guuduQFLMnWuDsF/kfFyH/99GX0TCD/BIx18sWPy1MRwCTR2Popl+BiJ5MS8OU8pO snUW+DBFVLIsR0kWmJTAy9Al1i3sZQ34asoS9fR3rW3U//CeU49OjF7hLnyuYJm9tj 6Hl5PJOOgZb8wtTayfPhDeFHvWt+0BWEjD3+HuNkqNqqizZO+YHIavWyiDdRD+38Vh NmWrWy6oXr12vkU5DiFWr8xfI1vAu4gD+lK7tziOl9FCdeVDr7uAUw7e7iH85IV8Ui LIi0sdsh1JuURbY20IFnBIMHQiy6ZwfjtAvzuT4ZFMMFj62XnZAyS6JDuwmceDSR5J 2j+diDrpD0qYA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JlDihh1g6V8a; Wed, 10 Aug 2022 14:22:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 661064136C; Wed, 10 Aug 2022 14:22:06 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 661064136C Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 9A15A1BF488 for ; Wed, 10 Aug 2022 14:22:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 80E0640C13 for ; Wed, 10 Aug 2022 14:22:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 80E0640C13 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fUAwC_9uMxD2 for ; Wed, 10 Aug 2022 14:22:04 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 3715F40150 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by smtp2.osuosl.org (Postfix) with ESMTPS id 3715F40150 for ; Wed, 10 Aug 2022 14:22:04 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6400,9594,10435"; a="291882949" X-IronPort-AV: E=Sophos;i="5.93,227,1654585200"; d="scan'208";a="291882949" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2022 07:22:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,227,1654585200"; d="scan'208";a="638121301" Received: from gsiwik.igk.intel.com ([10.102.18.50]) by orsmga001.jf.intel.com with ESMTP; 10 Aug 2022 07:22:00 -0700 From: Grzegorz Siwik To: intel-wired-lan@lists.osuosl.org Date: Wed, 10 Aug 2022 16:21:51 +0200 Message-Id: <1660141315-216111-1-git-send-email-grzegorz.siwik@intel.com> X-Mailer: git-send-email 1.8.3.1 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660141324; x=1691677324; h=from:to:cc:subject:date:message-id; bh=wrddqTzw6J6RUfq9Bqhb7zDaV5feDHuU2uXufLW/PfM=; b=Da7ku4Kf9X2VWEILKKUQpHycuUmv1A4W2QyzmuU0tOrNjKVUqctho6C0 IjTEQdGykj1MKsiA4fi9Ca6JvI/w2Db0hLPumuS6wUf9T6uBicR+4rtpN d2odm5dShs1hkExdCLO4LR8VM9MgXM1uLVGxV+Y81ew+aQRjEeue7hLb9 agZFrFGn+JkTvQyP1XZTZcxXvj0aCQHavP0ZVdguTxZScrkFjyeIGkXuT NtVmcyPl3hIRssuu2VDWhwT+vIaV1oLYm4G4WnVLH1XCF7g08M7qgSWqc N3hgt950U7220BcLEo3l79j9wRaPx+qhVJ+rsKZ1ngyzMiupHA5zKS/x6 Q==; X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Da7ku4Kf Subject: [Intel-wired-lan] [PATCH net v3 0/4] ice: Fixes for double vlan promiscuous mode X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Grzegorz Siwik MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" This series fixes known issues related to double vlan promiscuous mode. When at least two interfaces are bonded and a bridge is enabled on the bond, an error can occur when the bridge is removed and re-added. The reason for the error is because promiscuous mode was not fully cleared from the VLAN VSI in the hardware. Ignore ERR_ALREADY_EXISTS error when setting promiscuous mode. This fix is needed because the driver could set promiscuous mode when it still has not cleared properly. If the requested promiscuous mode setting already exists, an -EEXIST error message would be printed. This is incorrect because promiscuous mode is either on/off and shouldn't print an error when the requested configuration is already set. Avoid enabling or disabling vlan 0 when trying to set promiscuous vlan mode if double vlan mode is enabled. This fix is needed because the driver tries to add the vlan 0 filter twice (once for inner and once for outer) when double VLAN mode is enabled. --- v2: Fixed error message when setting same promiscuous mode --- v3: Fixed style issues, changed to return directly. --- Benjamin Mikailenko (1): ice: Ignore error message when setting same promiscuous mode Grzegorz Siwik (3): ice: Fix double VLAN error when entering promisc mode ice: Ignore ERR_ALREADY_EXISTS when setting promisc mode ice: Fix clearing of promisc mode with bridge over bond drivers/net/ethernet/intel/ice/ice_fltr.c | 8 ++++---- drivers/net/ethernet/intel/ice/ice_lib.c | 8 +++++++- drivers/net/ethernet/intel/ice/ice_main.c | 13 ++++++++++++- drivers/net/ethernet/intel/ice/ice_switch.c | 9 ++++++++- 4 files changed, 31 insertions(+), 7 deletions(-) -- 1.8.3.1 _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan