From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neftin, Sasha Date: Tue, 15 Dec 2020 15:23:01 +0200 Subject: [Intel-wired-lan] Fw: [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems i219LM In-Reply-To: References: <20201214153450.874339-1-mario.limonciello@dell.com> <80862f70-18a4-4f96-1b96-e2fad7cc2b35@redhat.com> Message-ID: <18c1c152-9298-a4c5-c4ed-92c9fd91ea8a@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On 12/14/2020 20:40, Mark Pearson wrote: > Thanks Hans > > On 14/12/2020 13:31, Mark Pearson wrote: >> >> >> ------------------------------------------------------------------------ >> *From:* Hans de Goede >> *Sent:* December 14, 2020 13:24 >> *To:* Mario Limonciello ; Jeff Kirsher >> ; Tony Nguyen ; >> intel-wired-lan at lists.osuosl.org ; >> David Miller ; Aaron Ma ; >> Mark Pearson >> *Cc:* linux-kernel at vger.kernel.org ; >> Netdev ; Alexander Duyck >> ; Jakub Kicinski ; Sasha >> Netfin ; Aaron Brown ; >> Stefan Assmann ; darcari at redhat.com >> ; Yijun.Shen at dell.com ; >> Perry.Yuan at dell.com ; anthony.wong at canonical.com >> >> *Subject:* [External] Re: [PATCH v4 0/4] Improve s0ix flows for systems >> i219LM >> >> Hi All, >> > >> >> ### >> >> I've added Mark Pearson from Lenovo to the Cc so that Lenovo >> can investigate this issue further. >> >> Mark, this thread is about an issue with enabling S0ix support for >> e1000e (i219lm) controllers. This was enabled in the kernel a >> while ago, but then got disabled again on vPro / AMT enabled >> systems because on some systems (Lenovo X1C7 and now also X1C8) >> this lead to suspend/resume issues. >> >> When AMT is active then there is a handover handshake for the >> OS to get access to the ethernet controller from the ME. The >> Intel folks have checked and the Windows driver is using a timeout >> of 1 second for this handshake, yet on Lenovo systems this is >> taking 2 seconds. This likely has something to do with the >> ME firmware on these Lenovo models, can you get the firmware >> team at Lenovo to investigate this further ? > Absolutely - I'll ask them to look into this again. > we need to explain why on Windows systems required 1s and on Linux systems up to 2.5s - otherwise it is not reliable approach - you will encounter others buggy system. (ME not POR on the Linux systems - is only one possible answer) > We did try to make progress with this previously - but it got a bit > stuck and hence the need for these patches....but I believe things may > have changed a bit so it's worth trying again > > Mark > Sasha