From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
Cc: larysa.zaremba@intel.com, netdev@vger.kernel.org,
kalesh-anakkur.purayil@broadcom.com,
intel-wired-lan@lists.osuosl.org,
Jakub Kicinski <kuba@kernel.org>,
Igor Bagnucki <igor.bagnucki@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v4] ice: Add netif_device_attach/detach into PF reset flow
Date: Wed, 21 Aug 2024 10:43:58 +0200 [thread overview]
Message-ID: <190cec09-37ef-4649-9a69-7cab32b6d35b@intel.com> (raw)
In-Reply-To: <ZsWHsaUbYo9Qb6v2@boxer>
On 8/21/24 08:22, Maciej Fijalkowski wrote:
> On Tue, Aug 20, 2024 at 06:15:24PM +0200, Dawid Osuchowski wrote:
>> @@ -7591,6 +7594,7 @@ static void ice_rebuild(struct ice_pf *pf, enum ice_reset_req reset_type)
>> {
>> struct device *dev = ice_pf_to_dev(pf);
>> struct ice_hw *hw = &pf->hw;
>> + struct ice_vsi *vsi = ice_get_main_vsi(pf);
>
> we have an unwritten rule that is called 'reverse christmas tree' which
> requires us to have declarations of variables sorted from longest to
> shortest.
Hah, the rule is written down actually :P
https://docs.kernel.org/process/maintainer-netdev.html
prev parent reply other threads:[~2024-08-21 8:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 16:15 [Intel-wired-lan] [PATCH iwl-net v4] ice: Add netif_device_attach/detach into PF reset flow Dawid Osuchowski
2024-08-21 6:22 ` Maciej Fijalkowski
2024-08-21 8:10 ` Dawid Osuchowski
2024-08-21 8:43 ` Przemek Kitszel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=190cec09-37ef-4649-9a69-7cab32b6d35b@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=dawid.osuchowski@linux.intel.com \
--cc=igor.bagnucki@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox