From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0710EB1073 for ; Tue, 10 Mar 2026 15:28:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A72398198A; Tue, 10 Mar 2026 15:28:25 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id cWlBvWQ3faWl; Tue, 10 Mar 2026 15:28:25 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 17E11818C4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1773156505; bh=aVv/PSZT5NGeZjfHxwg8OpWgNHlsgZDJ/5CMzeiUbdo=; h=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=R591bn4NaNhVTyq6Tvf4ZfupKw8IJ19pWnLW1Pvbr1R1vcsoq8bxPXHCojnXQvWLY mCHPsLU+UlmMOp4ukl+3W7kPI6gcb++v0s8vBw4kmSUBYvdDPRoaD5TR16nydm/swQ kXGSXy/mFsHgRVPKkAUSfKGCh8X6Z7L38Lq0RjGCqsqVMpfJ5ekxBIPrp9eRtR3Ufw U6y26nQaNpEifUFx4/dQ3keB9PWyBwyLmRFtfD2TXm+gWIzl4uk0nLa97317ITfjfN xSZfOQvAFGfpzFvTo4HMcW/Iy6OVcajkWJC73BrOJevqTOq4fkMmwbSziOcfOF+mIH DHeYciSkMy1hg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 17E11818C4; Tue, 10 Mar 2026 15:28:25 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id 807E235C for ; Tue, 10 Mar 2026 14:28:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7E3C58404F for ; Tue, 10 Mar 2026 14:28:19 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 2MhsXLS4DqUh for ; Tue, 10 Mar 2026 14:28:18 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=5.189.157.229; helo=kylie.crudebyte.com; envelope-from=linux_oss@crudebyte.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 6283681FD2 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 6283681FD2 Received: from kylie.crudebyte.com (kylie.crudebyte.com [5.189.157.229]) by smtp1.osuosl.org (Postfix) with ESMTPS id 6283681FD2 for ; Tue, 10 Mar 2026 14:28:18 +0000 (UTC) From: Christian Schoenebeck To: amd-gfx@lists.freedesktop.org, apparmor@lists.ubuntu.com, bpf@vger.kernel.org, ceph-devel@vger.kernel.org, cocci@inria.fr, dm-devel@lists.linux.dev, dri-devel@lists.freedesktop.org, gfs2@lists.linux.dev, intel-gfx@lists.freedesktop.org, intel-wired-lan@lists.osuosl.org, iommu@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-clk@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-omap@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sctp@vger.kernel.org, linux-security-module@vger.kernel.org, linux-sh@vger.kernel.org, linux-sound@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, samba-technical@lists.samba.org, sched-ext@lists.linux.dev, target-devel@vger.kernel.org, tipc-discussion@lists.sourceforge.net, v9fs@lists.linux.dev, Philipp Hahn , Philipp Hahn Cc: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Date: Tue, 10 Mar 2026 14:47:03 +0100 Message-ID: <1948861.tdWV9SEqCh@weasel> In-Reply-To: <20260310-b4-is_err_or_null-v1-24-bd63b656022d@avm.de> References: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> <20260310-b4-is_err_or_null-v1-24-bd63b656022d@avm.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-Mailman-Approved-At: Tue, 10 Mar 2026 15:28:18 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=kylie; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Content-ID:Content-Description; bh=aVv/PSZT5NGeZjfHxwg8OpWgNHlsgZDJ/5CMzeiUbdo=; b=dTpIUmFyfV+bP6Hy0ueZpN32tu piiOrm2xYxIB724JO1nPYEvLrwNppM7ldi2VsLNiB9a22ZPzaNJQ0YaGHJwVuraOF2yk5SpAHZold s8t7GSMCpZMXoj2MN+HCYF9oJcPgVF+TLl3oulmGF4t7YrhkwJ3IfsTmzXldUh96w/myd3pDSVX1g /e8bzPXWMBYBNoEloTPI5IYSewDyrYj60Js0etFfclp4hEgkn7HaHPBIdN5mmqp8OC3Z4JyMZY1In us3k02cy2EDC8Yr2DD9TZj2Bfv2JCzi8o1CBU/q/X+4deOd5/tymAnt0Bem3HGOfb0TZNQXc+sRV/ 1upKIM10UX7QbQ98BeJxn1cHAUt80a13aLlrns2kgX3r4ZD43IvQ3qOgYizweNeHFZvB+bpwBSNFD hlDW1qIdKmIN+wC7qSL6cU7m+YgH+eIF1AeR8pLLvTFBNqmI6qti9D+O96RBcbYAwE/olpfjlTGn5 mdLSL9FFfI7mx4Sepl5WAdeD1XVerb2KTcAMA8AXYimzng7DssEnPDbX6u+t3yAcQjc1BrWIujZyx Gao2D20IgKGUx784nxNUpYJ2ZiCkXzoDKyugnEIdTC+VrOwC2OEJanP1Uq3/BrGj0qOrmxYFeI51c 48zjYWWU3v40e6itkF189TkI8Acs6/RLaheNlL7MM=; X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=crudebyte.com X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (4096-bit key, unprotected) header.d=crudebyte.com header.i=@crudebyte.com header.a=rsa-sha256 header.s=kylie header.b=dTpIUmFy Subject: Re: [Intel-wired-lan] [PATCH 24/61] net/9p: Prefer IS_ERR_OR_NULL over manual NULL check X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tuesday, 10 March 2026 12:48:50 CET Philipp Hahn wrote: > Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL > check. > > Change generated with coccinelle. > > To: Eric Van Hensbergen > To: Latchesar Ionkov > To: Dominique Martinet > To: Christian Schoenebeck > To: "David S. Miller" > To: Eric Dumazet > To: Jakub Kicinski > To: Paolo Abeni > To: Simon Horman > Cc: v9fs@lists.linux.dev > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Philipp Hahn > --- > include/net/9p/client.h | 2 +- > net/9p/trans_rdma.c | 8 ++++---- > 2 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Christian Schoenebeck > diff --git a/include/net/9p/client.h b/include/net/9p/client.h > index > 838a94218b593f3fb19e6827c472753380193461..4bde6bd716f323c819745e64c7aac0dea > 7beb72f 100644 --- a/include/net/9p/client.h > +++ b/include/net/9p/client.h > @@ -364,7 +364,7 @@ static inline struct p9_fid *p9_fid_get(struct p9_fid > *fid) > > static inline int p9_fid_put(struct p9_fid *fid) > { > - if (!fid || IS_ERR(fid)) > + if (IS_ERR_OR_NULL(fid)) > return 0; > > if (tracepoint_enabled(9p_fid_ref)) > diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c > index > aa5bd74d333f3b5e6fd1e4344d26bc0201ff7f7f..60461344b536bcb6e94112aace75a88b6 > a99ad86 100644 --- a/net/9p/trans_rdma.c > +++ b/net/9p/trans_rdma.c > @@ -252,16 +252,16 @@ static void rdma_destroy_trans(struct p9_trans_rdma > *rdma) if (!rdma) > return; > > - if (rdma->qp && !IS_ERR(rdma->qp)) > + if (!IS_ERR_OR_NULL(rdma->qp)) > ib_destroy_qp(rdma->qp); > > - if (rdma->pd && !IS_ERR(rdma->pd)) > + if (!IS_ERR_OR_NULL(rdma->pd)) > ib_dealloc_pd(rdma->pd); > > - if (rdma->cq && !IS_ERR(rdma->cq)) > + if (!IS_ERR_OR_NULL(rdma->cq)) > ib_free_cq(rdma->cq); > > - if (rdma->cm_id && !IS_ERR(rdma->cm_id)) > + if (!IS_ERR_OR_NULL(rdma->cm_id)) > rdma_destroy_id(rdma->cm_id); > > kfree(rdma);