From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3511FCD98C4 for ; Tue, 10 Oct 2023 21:21:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id D142E81B72; Tue, 10 Oct 2023 21:21:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org D142E81B72 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1696972902; bh=It0WmVsfR5dwJsJTyEr+XXvaG9kQFODBdlYkYj7abos=; h=Date:To:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=xV73ehytOY+v1rUAjTbiiaUi/kXLpeLljwYleHEBlopLMoN+MSz3SVTQ5GXQHX4iR UKS6wZ/MI4lAH5/ovBP0V3ejQ3S9vmmY/IG3HcgUwp3qVrYAu/rwYouFAd1F7qnH52 MB/ls/Q7O+bN/qwuNt3Vif6xzMAVfXine/LiuOlMOlMyOXUFdd7wxSJgOepSUTnq0s q1awGHHePifA6KCR7aQOqoCLlbAMaBXFfJtwcfui3cN2p4FkbcBFxo+niEEzH4iAeQ W7O+Scou0srud0TSuS5zhGDSR7nsWg+3r88HpI1poeGa9DCt4vvp8XEuX0De7rtKc9 1HWAl+8y/fG4A== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S05HFWLx9u1s; Tue, 10 Oct 2023 21:21:42 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id F047081C21; Tue, 10 Oct 2023 21:21:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org F047081C21 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 91CD51BF310 for ; Tue, 10 Oct 2023 21:21:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 68A7440260 for ; Tue, 10 Oct 2023 21:21:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 68A7440260 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RudFN2v_z3gl for ; Tue, 10 Oct 2023 21:21:39 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by smtp2.osuosl.org (Postfix) with ESMTPS id 62C0C40012 for ; Tue, 10 Oct 2023 21:21:39 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 62C0C40012 X-IronPort-AV: E=McAfee;i="6600,9927,10859"; a="374851881" X-IronPort-AV: E=Sophos;i="6.03,213,1694761200"; d="scan'208";a="374851881" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2023 14:21:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10859"; a="753551832" X-IronPort-AV: E=Sophos;i="6.03,213,1694761200"; d="scan'208";a="753551832" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Oct 2023 14:21:38 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 10 Oct 2023 14:21:37 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 10 Oct 2023 14:21:37 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 10 Oct 2023 14:21:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cqpdf9Vg4TO3rMPxcjR+E5eJYjQvBAF+VSpqkNYXelKmyIvjrbvFt1HeHHdYSzH7kVj05Q5NPNqWgDh4rAJ8iOHCGx5RVtc5nI7SWjtkKcNwJKjVZystrs92nYOUXuSWOsaThl5AbC5NTCgYTfq3yNYw7dZCDM3BNMGSfXPqnsBFnonI4xZIde4H12+ZNdMzYniqf7kzZZVJ6sZc19FjBSe4XBHSYtaglfdf6efFcK5pb15lYi1MkmmNCZ8yIbrz/BJQEUorI6rJ1mgQsbdO6twRocqCvAPGA0c2F9wohKwwl1ttywiH1OCxwGm7bQ0MOY9eGoBr/X4KuOzP04Ldiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=weLU2CeJdJM7PUPrXN7ft0IQP3wYomfeOI5Wseol9kQ=; b=ceFkLIaOVj5fGYsfBEAgOAysvWfXA/6O54F2Koc1ZG8OTeh+I+SlO8ck77E38fxOzhafFlgsfEXBQo6CqIWar6qfA4C7Fw163ze5V+qfik7xwy6/ysenyxq5u/SKxdg2X8p6qExMQHCUj5cIq+2+YKLL4e3c4kLdsWTpcE9sICDiy6Mk8se3UzGmAQuwVC0YQxDJFJRBElx1BzfnSsUj38muvf853QdEsM3/D1LprgipHvVnx1XwO1JMK0BdehG/cmK4LvMjO5N9h5OtKt0NyAoCecnsAJpi8u8J6Iez1PkNiDg2E/OlnY7V7HxXIDPWxGg2FHaPjSd/KoClk2nY0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4914.namprd11.prod.outlook.com (2603:10b6:303:90::24) by DS0PR11MB7286.namprd11.prod.outlook.com (2603:10b6:8:13c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Tue, 10 Oct 2023 21:21:35 +0000 Received: from CO1PR11MB4914.namprd11.prod.outlook.com ([fe80::b598:4b13:38aa:893e]) by CO1PR11MB4914.namprd11.prod.outlook.com ([fe80::b598:4b13:38aa:893e%6]) with mapi id 15.20.6863.032; Tue, 10 Oct 2023 21:21:35 +0000 Message-ID: <19f84dd5-e769-aca9-a8ea-89008bfd9226@intel.com> Date: Tue, 10 Oct 2023 14:21:34 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.15.1 Content-Language: en-US To: Justin Stitt , Tony Nguyen , "David S. Miller" , "Eric Dumazet" , Jakub Kicinski , Paolo Abeni References: <20231010-strncpy-drivers-net-ethernet-intel-i40e-i40e_ddp-c-v1-1-f01a23394eab@google.com> From: Jesse Brandeburg In-Reply-To: <20231010-strncpy-drivers-net-ethernet-intel-i40e-i40e_ddp-c-v1-1-f01a23394eab@google.com> X-ClientProxiedBy: MW4PR04CA0171.namprd04.prod.outlook.com (2603:10b6:303:85::26) To CO1PR11MB4914.namprd11.prod.outlook.com (2603:10b6:303:90::24) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4914:EE_|DS0PR11MB7286:EE_ X-MS-Office365-Filtering-Correlation-Id: a9d6f01e-709b-435a-b0c2-08dbc9d6e1c2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4s6bdiIPWaxtuHCK248jQVu+iSNPw4xuvvVj/evh4RJw2rsq8yKkP2YcnSThanl7hTz+thD0UFeQ1aOk52fDTsRaHEQP3ADzVYJZM0meoJlxJN2OG3k/1y68oiFjgIeZfBXXwxYPWnnx/g95EjHmgeIDLtecczADmAy/GocTmKn1sGbUkqvBCLCfnIHlz5Ly+Oht+cPGtlLdg71Ruq8o3wFqoZejBSzVE3/llkjQktiyo6Xy2uiIn9vW8oWFdDAFLw93JlykJm0MP6ST0ezTNorZSvp5DEpeR3jRBSggRmbaGEHlAHkpBLWjK9VUvupHWOY+7695u3eLJBjbAW+5RV3zjJdq4ufvXC8oRr5spKS8JBHGZbmez2MNJbgu3UM7+9IL5J/zlKt2uEXDLuql/4WiJBHmE5GBGUvBteY6NqDy6czOsHcwM8o8WNkKZOQDr++PlkmdChizP6KaaP/UCmS1nW4YMCx93ylPZ5BNMEj+qyTzL7/fDfQdYTyfHC3MSNFw//mOFEPzr7aiVvGXLjZpS0bNtHDa08rxYyqBysjH9PhcaZaiBkH1OCbnJL+5lx42xkbIqMoFzUx/K2WE3AccKOygDzSS5ck9js9SUuZ6O6LVpzlNfJ75JV08lx7fGE8dXGuvJUIvarioSOocuw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4914.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(346002)(136003)(39860400002)(396003)(376002)(230922051799003)(186009)(64100799003)(1800799009)(451199024)(6512007)(53546011)(6506007)(478600001)(26005)(2616005)(66556008)(6486002)(44832011)(31696002)(4744005)(2906002)(5660300002)(110136005)(66476007)(66946007)(8676002)(8936002)(4326008)(41300700001)(316002)(82960400001)(36756003)(38100700002)(86362001)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGdzK2M5ajZWR0hyNU5zQWNPRlhQS05pUHgzZ2EvWXNmME5JZlJsOC9XRFZ3?= =?utf-8?B?b1c4N1pOb0pCd2hONWZJbDBZZ01iZ2Z6akltL0lHTUlMQURDazJxMHMrK3V0?= =?utf-8?B?SFZqNFYvQVc3UzNPUEo3M3RtWFRSaDdWNnVKQUlOdVZyeTZLOW1oamt2NWtX?= =?utf-8?B?c2xPNUVoSmdlTE16UnB1VG9YcmdRMlluQzNtT3pxV0JsaDhWZGxnSmhsWnN5?= =?utf-8?B?bTRtaXp5V0xiU0hDL3Z0eGdvOGZtcit4ZC9HODJ0aDV0V1NZbEFVYXArUGN4?= =?utf-8?B?UzZsQ0dQakc2Ym5OT3RmYnEzTFpYWjFMa2FJMjd0bi9DUm41TjZHbWw4bGxm?= =?utf-8?B?SU9xR2tiYS9VNG9pRGQvemp1eWhBTVhkMnlzNFJLdW5nVWNnMGZvTmtlU0FN?= =?utf-8?B?N09hWDRRTlFkdTQ1ZnVWM3ZJKzNlQzd5bTk4NnVQaS8rT2NGb0xpVFVtMWR6?= =?utf-8?B?K1RLYWdoUWM5VmpFLzZ3dW1HNithM1lKeVZMWVpFa0JXN0g1QUhoYjNZM0xR?= =?utf-8?B?cjZHcDB1QXFlaHYwN3ljQkNFZXRBdS9iWWhITW5VQ1ZwVXVzY0JDbzlQNGE1?= =?utf-8?B?eTdxM3lQM1lBanVmc3EyeCs3VFlWUThVRzVYY20xcllZT2ZmdGE5QzdFSmF6?= =?utf-8?B?bVdYZVVKTWMzS3l3OWFNS0NWNU12SjFId0JhSVlvYjhtVkwrd3BCbnRBdDlh?= =?utf-8?B?MnBzTU1WY2sxRmhZdmZETHFXYUllamprSzVIcndKMXUxSzZ1d3pMaDl6U00r?= =?utf-8?B?T1RXalpBMmp2VU4xMk1wWFpiaDhYZ3BKaUhCcWpQd00vWnFkZDFhTmowUTl4?= =?utf-8?B?Wk13RmVWekNYZ3d5Tm9tTHBRZDA4NjQzQzNjeFd1TWxJSVdzYW5LSzZWd2pX?= =?utf-8?B?dE4zcVU1Mkt0NEswWjl6MVh5L3hhTDlaR2JGdHRqUjNJM0hUaGNRVk9MN2k4?= =?utf-8?B?WlR0QVJpQVh5ZTFLMVJvM3JFeThDVEtKMExlb094blVOZkNtSmhXc2I5UXpD?= =?utf-8?B?b1pjVEMzQnpRaTQ2NkVwakpKa2lBakdrZTltTmNkU0xVcDF4QmhiTUIxRlJl?= =?utf-8?B?WUE4OGIvYUJhbTZmZUdQOC9Rb1JxcU1EcGhMdXNUQkdkTnFpT0YxbjVkczdj?= =?utf-8?B?T2lXRFMyQkIvV3J5Qmc3MDNUM1NxNm84czJsczAvdWRqanRXOUFWcEREa1c5?= =?utf-8?B?QUFuSW1wU1YzMy9sSHVOUmpPaFNUQkZWSGlIRjYyRWZKdWJyQkVUbHBtSzZh?= =?utf-8?B?R0JhZHAwWDQvdVZtdGRvSzNxOXFiTHZoSyswd29JQVJ1YmNYZEVwUUpMSkg0?= =?utf-8?B?L0RxY3E5cEg1TjBuNkNiVklFTS9tRDkva1JnbXdtdzNUMUdTV2o5eHZKQ3A2?= =?utf-8?B?VXpCQ1dKUlgvQU16UkdaT0QveW51SnF2T3RVcmZ2MUg4RTZrT3g3VXlVMkNl?= =?utf-8?B?ZmJFV2MvbkdEVW9kamRvOG53VXRmQXBpVW41RDdCRHUzRTV4eXo0Rjc5dVhU?= =?utf-8?B?VFJ6U2lad0NVNlZHWURpOGE2Y0FSRmhUQUNHanRxRTNrUVFmYUV6aFJhMVUw?= =?utf-8?B?N0ZIcHNWNnNCUHgzdVlES0t0SFFYWkVmdUNwL09YZlZDYks5aXhpQ2xFaFR6?= =?utf-8?B?WnRPZzFuWTF6Y1lIdVFvODZlS0o3TzZlTTZRZ1FBai9qd2dlTzBpdktoMHpO?= =?utf-8?B?dncwUjJVYmgwTFJCbzNQd25kOWpDazFHVXFvS29ueFFrKzZ1OEttZERZWVRC?= =?utf-8?B?NnVQcU1iK1RuUWhsb2p4b3ZSMTJuVXNVV24yNHJFcE9HWGhpUGNEb0dMcjIy?= =?utf-8?B?dUJmbXlQcndGc09WcGc4aGlaaHhOZ0V2UWVCdVpuL2hGWmpoMWx6ZlpKYlk3?= =?utf-8?B?TUYrajF2NlNVK0J0MGRzQnFuNUcrbzUvYnJJcXlsVFNHM1Zwa2ZmdXFVYm1w?= =?utf-8?B?UXQxdkx0UHQ5STA0OStsMjdxdnRsTUVoMFoyTHRnbWNVVDFJeTYrNTNRQ1FI?= =?utf-8?B?OHBxQVRUWWJ0RUNJM3lIQ1RialZVZ3FhSVZ2QkNPMlY1ZEhMMlBGcDQ1a0c0?= =?utf-8?B?SzlxTU51WU9mWThBNmk4K2l1OWcyZUsyUmhTSW5JNWtSS25ONm9rMHd4VFJl?= =?utf-8?B?SVczVWdKK2RFbmFtVGVucjF2N1pvN2wxMW1GUG1LcU90NkYvdU43TWk4WXlw?= =?utf-8?B?Y0E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: a9d6f01e-709b-435a-b0c2-08dbc9d6e1c2 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 21:21:35.1923 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hayYCvdPaUni5c3DkCB7Cjqvuwm08JK8qj4LmtO/AGK0Spp+arlljqJY1VlrS7/RCd+1AuNP8tk8PRlND2GLgewD7Y7Gypp2SSqMpk+Bisw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7286 X-OriginatorOrg: intel.com X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696972899; x=1728508899; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=TyVVUtCSN4kekF8ZoiR5vih+N2Pe6wiFjPimW4rXNKU=; b=OB6tuIJUUzlAUNDDkT+wvRd+PwxlBUinLrfYreOV/brDFTN6n22qm0LV K+PnXNRY1gBzQDH9vn0k2UzIMrm8+kQa2vwqE8k2fGOeodo22Fk2lli8E 9Fs9s6iepIipTxxKzMfEKjLzzy1qtZdGvp2Vo4nCutR+AoxY4a6KF9jkN aeL9Rwy262uL3HZYG0TZnYvO0VNexqapQo233+2/RFkCt16h2hUv6l/OX PTCuGjrTrsGwAFBOs6DPgiteYBM5DyC9mh1fHi0LrxIKn1hFTt8OosNGV sx226+kjrPEA5ABQq8R8/rmoFAuL+rOLgYZV0E0ezFgc5EQ6aWBghLjGI w==; X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=OB6tuIJU X-Mailman-Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Subject: Re: [Intel-wired-lan] [PATCH] i40e: use scnprintf over strncpy+strncat X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 10/10/2023 1:53 PM, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > Moreover, `strncat` shouldn't really be used either as per > fortify-string.h: > * Do not use this function. While FORTIFY_SOURCE tries to avoid > * read and write overflows, this is only possible when the sizes > * of @p and @q are known to the compiler. Prefer building the > * string with formatting, via scnprintf() or similar. > > Instead, use `scnprintf` with "%s%s" format string. This code is now > more readable and robust. Please see my comments on the igbvf patch. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan