Re: [Intel-wired-lan] [PATCH v2 1/4] Revert "igb: Disable threaded IRQ for igb_msix_other"

[Przemek Kitszel <przemyslaw.kitszel@intel.com>]

On 11/6/24 12:14, Wander Lairson Costa wrote:
> This reverts commit 338c4d3902feb5be49bfda530a72c7ab860e2c9f.
> 
> Sebastian noticed the ISR indirectly acquires spin_locks, which are
> sleeping locks under PREEMPT_RT, which leads to kernel splats.

I don't like to slow things down, but it would be great to have a Link:
to the report, and the (minified) splat attached.

> 
> Fixes: 338c4d3902feb ("igb: Disable threaded IRQ for igb_msix_other")
> Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Signed-off-by: Wander Lairson Costa <wander@redhat.com>
> 
> ---
> 
> Changelog:
> 
> v2: Add the Fixes tag
> Signed-off-by: Wander Lairson Costa <wander@redhat.com>
> ---
>   drivers/net/ethernet/intel/igb/igb_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
> index b83df5f94b1f5..f1d0881687233 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -907,7 +907,7 @@ static int igb_request_msix(struct igb_adapter *adapter)
>   	int i, err = 0, vector = 0, free_vector = 0;
>   
>   	err = request_irq(adapter->msix_entries[vector].vector,
> -			  igb_msix_other, IRQF_NO_THREAD, netdev->name, adapter);
> +			  igb_msix_other, 0, netdev->name, adapter);
>   	if (err)
>   		goto err_out;
>