From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7991EE77184 for ; Thu, 19 Dec 2024 16:25:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 23CEE8040E; Thu, 19 Dec 2024 16:25:24 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id At5mkNRha6M7; Thu, 19 Dec 2024 16:25:23 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7750780427 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1734625523; bh=TCCotu8UrVZHJEECd2/Ae9IP9booNjuAKP9NllMpbqA=; h=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=C7jf5xh1PjccPZj1+STyzkDagksbkq+soMNEcn722OdmvLJrF1B+teRa0Q8tA+Bhh H5VyQKI2D0327fPf9Yup1RddVBPtfd8U20opzHEF0lwdsEiFtKDT+BHTMVZnKLr5vl WQ5lWpSnaVyJUpmCH9DsGtcxN6uKvCCz7rFIiyqltIqcttEj0TomCBt74LlgOAO1uz ADtLpjc4tS4aCtXbpgoqPE2tDUFEwYIukwN07Gahm52dl9+wUGxtBG2GyuBakCjs9s 5EIJIPRHWEZ7CldjwA6p6LWzQHpQwhgBcgIrWwbjA16r3H9bCbo00pFe9HxGnHuXMn MR91vZQVDFYVQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 7750780427; Thu, 19 Dec 2024 16:25:23 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id 32313C0 for ; Thu, 19 Dec 2024 07:24:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 0F9AD61395 for ; Thu, 19 Dec 2024 07:24:50 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id VdcX6PcZt9Pw for ; Thu, 19 Dec 2024 07:24:49 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=198.175.65.17; helo=mgamail.intel.com; envelope-from=yong.liang.choong@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org E3058608AA DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org E3058608AA Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by smtp3.osuosl.org (Postfix) with ESMTPS id E3058608AA for ; Thu, 19 Dec 2024 07:24:48 +0000 (UTC) X-CSE-ConnectionGUID: IEwTuZhrSfKe9z2JQr59pw== X-CSE-MsgGUID: aDzc5DU3T96adVFNWiTm/w== X-IronPort-AV: E=McAfee;i="6700,10204,11290"; a="35120985" X-IronPort-AV: E=Sophos;i="6.12,247,1728975600"; d="scan'208";a="35120985" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2024 23:24:46 -0800 X-CSE-ConnectionGUID: XiIO2PtrQJSFbBfzd+zw4Q== X-CSE-MsgGUID: c207iclTSYiTooKVnU97ig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,247,1728975600"; d="scan'208";a="98013114" Received: from choongyo-mobl.gar.corp.intel.com (HELO [10.247.82.175]) ([10.247.82.175]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2024 23:24:43 -0800 Message-ID: <1bc573ec-1f69-4fc6-9bb4-c0a4c38c10aa@linux.intel.com> Date: Thu, 19 Dec 2024 15:24:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Furong Xu <0x1207@gmail.com>, Vladimir Oltean Cc: Faizal Rahim , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vinicius Costa Gomes , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org References: <20241216064720.931522-1-faizal.abdul.rahim@linux.intel.com> <20241216064720.931522-1-faizal.abdul.rahim@linux.intel.com> <20241216064720.931522-7-faizal.abdul.rahim@linux.intel.com> <20241216064720.931522-7-faizal.abdul.rahim@linux.intel.com> <20241217002254.lyakuia32jbnva46@skbuf> <20241217200952.000059f2@gmail.com> Content-Language: en-US From: Choong Yong Liang In-Reply-To: <20241217200952.000059f2@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Thu, 19 Dec 2024 16:25:22 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734593087; x=1766129087; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=oZqFuW7QFS4Vc/TSp3AxQi8Ft5gm5pNg6tJATdW+lY0=; b=IgTK/ZXqwLmzHFjyZeJciYszJLMkacb69QA4oAAf8m8gRa/JYKPyZWq5 i5tgKgelct9jIFWUvgVUZCFk3XToBBNLaJTyiNdYgRBu4rQysh39e7x1X zZd27+Evm78M3vhFqq5D8L3/Ad/8xByhifOZwgnIRoIOJNzGNKf+/Cpla lzLL0NObvClR3F8d3mI2y+Qbllhpsvf83kBcMITlCqqJTX1Y10qHGdVo0 AK6+soIj+SOkT119JdySdaTwITgPIEq2+YbUnbtzh2ppcoLAi0sdN3pdX AsBi4Ecu04nng32eKQ2o+0n0y4NgvR+kDEzOOP/mQHU90DrUg14DM/wIy w==; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=IgTK/ZXq Subject: Re: [Intel-wired-lan] [PATCH iwl-next 6/9] igc: Add support for frame preemption verification X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 17/12/2024 8:09 pm, Furong Xu wrote: > On Tue, 17 Dec 2024 02:22:54 +0200, Vladimir Oltean wrote: > >> Anyway, while browsing through this software implementation of a >> verification process, I cannot help but think we'd be making a huge >> mistake to allow each driver to reimplement it on its own. We just >> recently got stmmac to do something fairly clean, with the help and >> great perseverence of Furong Xu (now copied). >> >> I spent a bit of time extracting stmmac's core logic and putting it in >> ethtool. If Furong had such good will so as to regression-test the >> attached patch, do you think you could use this as a starting place >> instead, and implement some ops and call some library methods, instead >> of writing the entire logic yourself? >> > > I am quiet busy these days, especially near the end of the year :) > > Maybe I can help testing the attached patch when the next time net-next opens. > > Thanks. > I'm a colleague of Faizal and I'd be happy to help out with testing the patch. I'll take care of testing it on the stmmac side and will sort out any issues that come up. If there are any necessary fixes or improvements, I'll handle those and provide feedback accordingly.