From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next-queue] fm10k: use snprintf() instead of sprintf() to avoid buffer overflow
Date: Wed, 26 Aug 2015 09:44:58 -0700 [thread overview]
Message-ID: <20150826094458.00007a6c@unknown> (raw)
In-Reply-To: <1440460921-28318-1-git-send-email-jacob.e.keller@intel.com>
On Mon, 24 Aug 2015 17:01:58 -0700
Jacob Keller <jacob.e.keller@intel.com> wrote:
> Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
> drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c | 6 +++---
> drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 8 ++++----
> 2 files changed, 7 insertions(+), 7 deletions(-)
The changes look fine, but I've seen multiple comments to the list that
there needs to be a body in the commit message.
Suggest:
Subject:
fm10k: use snprintf()
Body:
Avoid buffer overflow and follow best practices by using snprintf()
instead of sprintf().
next prev parent reply other threads:[~2015-08-26 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 0:01 [Intel-wired-lan] [next-queue] fm10k: use snprintf() instead of sprintf() to avoid buffer overflow Jacob Keller
2015-08-25 0:01 ` [Intel-wired-lan] [next-queue] fm10k: Correct MTU for jumbo frames Jacob Keller
2015-08-25 0:02 ` [Intel-wired-lan] [next-queue] fm10k: do not use enum as boolean Jacob Keller
2015-09-30 19:05 ` Singh, Krishneil K
2015-08-25 0:02 ` [Intel-wired-lan] [next-queue] fm10k: do not assume VF always has 1 queue Jacob Keller
2015-08-26 16:44 ` Jesse Brandeburg [this message]
2015-08-26 16:46 ` [Intel-wired-lan] [next-queue] fm10k: use snprintf() instead of sprintf() to avoid buffer overflow Keller, Jacob E
2015-09-30 19:08 ` Singh, Krishneil K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826094458.00007a6c@unknown \
--to=jesse.brandeburg@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox