From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next, S23, 06/13 v2] i40e/i40evf: tunnels can be generic
Date: Thu, 21 Jan 2016 16:07:20 -0800 [thread overview]
Message-ID: <20160121160720.00000e23@unknown> (raw)
In-Reply-To: <CAKgT0Ueubf1ex4C2=avpPHgPVUAnRY4F6JZJyecvXqufHA2Etg@mail.gmail.com>
On Wed, 20 Jan 2016 23:25:28 -0800
Alexander Duyck <alexander.duyck@gmail.com> wrote:
> > - if (!(tx_flags & I40E_TX_FLAGS_UDP_TUNNEL)) {
> > + if ((tx_flags & I40E_TX_FLAGS_TUNNEL)) {
>
> You only need one set of parenthesis here instead of two since you
> have flipped the logic. Otherwise the rest of the patch looks fine.
Thanks, v3 sent.
prev parent reply other threads:[~2016-01-22 0:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 22:43 [Intel-wired-lan] [next, S23, 06/13 v2] i40e/i40evf: tunnels can be generic Jesse Brandeburg
2016-01-21 7:25 ` Alexander Duyck
2016-01-22 0:07 ` Jesse Brandeburg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160121160720.00000e23@unknown \
--to=jesse.brandeburg@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox