Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.duyck@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH v5 06/12] igb: Only sync size of expected frame in ethtool testing
Date: Mon, 06 Feb 2017 18:26:26 -0800	[thread overview]
Message-ID: <20170207022620.9864.29933.stgit@localhost.localdomain> (raw)
In-Reply-To: <20170207022339.9864.87863.stgit@localhost.localdomain>

From: Alexander Duyck <alexander.h.duyck@intel.com>

We only need to sync the size of the frame that is read to test.  We don't
need to sync the entire Rx buffer.  This way the testing is more consistent
with how we handle things in the receive path.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
v4: Split this code out of patch 6 of the original series.

 drivers/net/ethernet/intel/igb/igb_ethtool.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
index 612cf13b7a3a..d5966feb7b96 100644
--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
@@ -1818,7 +1818,7 @@ static int igb_clean_test_rings(struct igb_ring *rx_ring,
 		/* sync Rx buffer for CPU read */
 		dma_sync_single_for_cpu(rx_ring->dev,
 					rx_buffer_info->dma,
-					IGB_RX_BUFSZ,
+					size,
 					DMA_FROM_DEVICE);
 
 		/* verify contents of skb */
@@ -1828,7 +1828,7 @@ static int igb_clean_test_rings(struct igb_ring *rx_ring,
 		/* sync Rx buffer for device write */
 		dma_sync_single_for_device(rx_ring->dev,
 					   rx_buffer_info->dma,
-					   IGB_RX_BUFSZ,
+					   size,
 					   DMA_FROM_DEVICE);
 
 		/* unmap buffer on Tx side */


  parent reply	other threads:[~2017-02-07  2:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07  2:25 [Intel-wired-lan] [next PATCH v5 00/12] igb: Add support for writable pages and build_skb Alexander Duyck
2017-02-07  2:25 ` [Intel-wired-lan] [next PATCH v5 01/12] igb: Add support for DMA_ATTR_WEAK_ORDERING Alexander Duyck
2017-02-17  3:26   ` Brown, Aaron F
2017-02-07  2:25 ` [Intel-wired-lan] [next PATCH v5 02/12] igb: Use length to determine if descriptor is done Alexander Duyck
2017-02-17  3:26   ` Brown, Aaron F
2017-02-07  2:25 ` [Intel-wired-lan] [next PATCH v5 03/12] igb: Clear Rx buffer_info in configure instead of clean Alexander Duyck
2017-02-17  3:26   ` Brown, Aaron F
2017-02-07  2:26 ` [Intel-wired-lan] [next PATCH v5 04/12] igb: Don't bother clearing Tx buffer_info in igb_clean_tx_ring Alexander Duyck
2017-02-17  3:27   ` Brown, Aaron F
2017-02-07  2:26 ` [Intel-wired-lan] [next PATCH v5 05/12] igb: Limit maximum frame Rx based on MTU Alexander Duyck
2017-02-17  3:27   ` Brown, Aaron F
2017-02-07  2:26 ` Alexander Duyck [this message]
2017-02-17  3:28   ` [Intel-wired-lan] [next PATCH v5 06/12] igb: Only sync size of expected frame in ethtool testing Brown, Aaron F
2017-02-07  2:26 ` [Intel-wired-lan] [next PATCH v5 07/12] igb: Use page_address offset from page instead of masking virtual address Alexander Duyck
2017-02-17  3:28   ` Brown, Aaron F
2017-02-07  2:26 ` [Intel-wired-lan] [next PATCH v5 08/12] igb: Add support for ethtool private flag to allow use of legacy Rx Alexander Duyck
2017-02-17  3:28   ` Brown, Aaron F
2017-02-07  2:27 ` [Intel-wired-lan] [next PATCH v5 09/12] igb: Add support for using order 1 pages to receive large frames Alexander Duyck
2017-02-17  3:29   ` Brown, Aaron F
2017-02-07  2:27 ` [Intel-wired-lan] [next PATCH v5 10/12] igb: Add support for padding packet Alexander Duyck
2017-02-17  3:29   ` Brown, Aaron F
2017-02-07  2:27 ` [Intel-wired-lan] [next PATCH v5 11/12] igb: Break out Rx buffer page management Alexander Duyck
2017-02-17  3:30   ` Brown, Aaron F
2017-02-07  2:27 ` [Intel-wired-lan] [next PATCH v5 12/12] igb: Re-add support for build_skb in igb Alexander Duyck
2017-02-17  3:30   ` Brown, Aaron F

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170207022620.9864.29933.stgit@localhost.localdomain \
    --to=alexander.duyck@gmail.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox