From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] igb: Fix error that repeat to add filter when changing adapter speed
Date: Wed, 3 May 2017 08:43:48 -0700 [thread overview]
Message-ID: <20170503084348.0000464c@intel.com> (raw)
In-Reply-To: <1493774409-7536-1-git-send-email-gangfeng.huang@ni.com>
On Wed, 3 May 2017 09:20:09 +0800
Gangfeng <gangfeng.huang@ni.com> wrote:
> From: Gangfeng Huang <gangfeng.huang@ni.com>
>
> Function igb_nfc_filter_exit()/igb_nfc_filter_restore() should be paried,
> igb_nfc_filter_restore exist in igb_up(), but igb_nfc_filter_exit() exist
> in __igb_close(), so move the igb_nfc_filter_exit() to igb_down().
Hi, thanks for your patch. Are you fixing a bug here? If so, your
commit message should say what you're fixing and how to reproduce it.
Say why you are doing something, not just what you're doing.
In this case, it looks like you probably are fixing a bug, but
definitely need a better commit message.
prev parent reply other threads:[~2017-05-03 15:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 1:20 [Intel-wired-lan] [PATCH] igb: Fix error that repeat to add filter when changing adapter speed Gangfeng
2017-05-03 15:43 ` Jesse Brandeburg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170503084348.0000464c@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox